From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAaxt-0006g3-OL for guix-patches@gnu.org; Mon, 23 Apr 2018 08:53:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAaxq-0005GJ-KQ for guix-patches@gnu.org; Mon, 23 Apr 2018 08:53:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fAaxq-0005GB-H1 for guix-patches@gnu.org; Mon, 23 Apr 2018 08:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fAaxq-00042V-5q for guix-patches@gnu.org; Mon, 23 Apr 2018 08:53:02 -0400 Subject: [bug#31172] [PATCH 1/1] gnu: Add psm2. Resent-Message-ID: From: ludovic.courtes@inria.fr (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180416074607.17992-1-pierre-antoine.rouby@inria.fr> <20180416074931.18094-1-pierre-antoine.rouby@inria.fr> Date: Mon, 23 Apr 2018 14:52:15 +0200 In-Reply-To: <20180416074931.18094-1-pierre-antoine.rouby@inria.fr> (Rouby Pierre-Antoine's message of "Mon, 16 Apr 2018 09:49:31 +0200") Message-ID: <87sh7m2igw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Rouby Pierre-Antoine Cc: 31172@debbugs.gnu.org Hello, Rouby Pierre-Antoine skribis: > * gnu/packages/linux.scm (psm2): New variable. Overall LGTM! Some comments: > +(define-public psm2 > + (package > + (name "psm2") > + (version "10.3-46") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/intel/opa-psm2.git") > + (commit "5fabd0e699a920e74333f789923fd1c02bb7c629"))) I think you can use the =E2=80=9CPSM2_10.3-46=E2=80=9D tag for clarity here. > + (arguments > + '(#:modules ((guix build utils) > + (guix build gnu-build-system)) This #:modules isn=E2=80=99t needed since it=E2=80=99s already the default = set of modules. > + #:phases (modify-phases %standard-phases > + (delete 'configure) > + (delete 'check) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out"))) > + (setenv "DESTDIR" out) > + (invoke "make" "install") Setting DESTDIR doesn=E2=80=99t quite work; it leads to an incorrect layout= with some files going to $prefix/usr: --8<---------------cut here---------------start------------->8--- $ find /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46 /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46 /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/lib /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/lib/udev /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/lib/udev/rules.d /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/lib/udev/rules.d/4= 0-psm.rules /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/lib/udev/rules.d/4= 0-psm-compat.rules /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/share /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/share/doc /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/share/doc/psm2-10.= 3-46 /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/share/doc/psm2-10.= 3-46/COPYING /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/lib /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/lib/libpsm2 /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/lib/libpsm2/li= bpsm2-compat.cmds /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/lib64 /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/lib64/libpsm2.= so.2 /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/lib64/psm2-com= pat /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/lib64/psm2-com= pat/libpsm_infinipath.so.1 /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/lib64/libpsm2.= so /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/lib64/libpsm2.= so.2.1 /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/lib64/libpsm2.a /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/psm2.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/hfi1_deprecated.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/ptl_ips /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/ptl_ips/ipserror.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/psmi_wrappers.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/opa_intf.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/linux-x86_64 /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/linux-x86_64/bit_ops.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/linux-x86_64/sysdep.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/opa_udebug.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/opa_debug.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/opa_byteorder.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/opa_common.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/opa_revision.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/opa_service.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/psm2_mock_testing.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/hfi1di= ag/opa_user.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/psm2_m= q.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/usr/include/psm2_a= m.h /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/etc /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/etc/modprobe.d /gnu/store/i1ln5bgdkspm959nv7k42ysgycgsm3v6-psm2-10.3-46/etc/modprobe.d/lib= psm2-compat.conf --8<---------------cut here---------------end--------------->8--- Also we should avoid lib64/. Could you send an updated patch? Eventually we should try adding psm2 as an input to =E2=80=98openmpi=E2=80= =99 so that it is built with PSM2 modules. Thank you! Ludo=E2=80=99.