unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#31523] [PATCH 0/2] Getting rid of 'title' in 'file-system' declarations
@ 2018-05-18 22:12 Ludovic Courtès
  2018-05-18 22:19 ` [bug#31523] [PATCH 1/2] file-systems: Remove 'title' field and add <file-system-label> Ludovic Courtès
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Ludovic Courtès @ 2018-05-18 22:12 UTC (permalink / raw)
  To: 31523

Hello Guix!

These patches allow us to get rid of the infamous ‘title’ field in
‘file-system’ declarations, which has always been problematic.  It does
so by introducing a new <file-system-label> data type, such that one can
write:

               (file-system
                 (mount-point "/home")
                 (type "ext4")
                 (device (file-system-label "my-home")))

which probably looks clearer and is definitely less error prone.

The ‘title’ field is removed but some macrology takes care of
implementing backward compatibility by detecting ‘title’ fields, issuing
a deprecation warning, and adjusting the ‘device’ value according to the
‘title’.

The “installed-os” test passes.

Feedback welcome!

Ludo’.

Ludovic Courtès (2):
  file-systems: Remove 'title' field and add <file-system-label>.
  system: Remove uses of the 'title' field of <file-system>.

 doc/guix.texi                                |  68 ++++++------
 gnu/bootloader/grub.scm                      |  10 +-
 gnu/build/file-systems.scm                   |  54 +++-------
 gnu/build/linux-boot.scm                     |  12 ++-
 gnu/build/shepherd.scm                       |   3 +-
 gnu/services/base.scm                        |  17 ++-
 gnu/system.scm                               |  36 ++++---
 gnu/system/examples/bare-bones.tmpl          |   3 +-
 gnu/system/examples/beaglebone-black.tmpl    |   3 +-
 gnu/system/examples/lightweight-desktop.tmpl |   4 +-
 gnu/system/examples/vm-image.tmpl            |   3 +-
 gnu/system/file-systems.scm                  | 108 ++++++++++++++++---
 gnu/system/install.scm                       |   4 +-
 gnu/system/vm.scm                            |   7 +-
 gnu/tests.scm                                |   3 +-
 gnu/tests/install.scm                        |  26 ++---
 guix/scripts/system.scm                      |  31 +++---
 tests/guix-system.sh                         |   9 +-
 tests/system.scm                             |   6 +-
 19 files changed, 227 insertions(+), 180 deletions(-)

-- 
2.17.0

^ permalink raw reply	[flat|nested] 7+ messages in thread
[parent not found: <87tvqrqiw8.fsf@lapdog.tobias.gr>]

end of thread, other threads:[~2018-05-29 13:12 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-18 22:12 [bug#31523] [PATCH 0/2] Getting rid of 'title' in 'file-system' declarations Ludovic Courtès
2018-05-18 22:19 ` [bug#31523] [PATCH 1/2] file-systems: Remove 'title' field and add <file-system-label> Ludovic Courtès
2018-05-18 22:19   ` [bug#31523] [PATCH 2/2] system: Remove uses of the 'title' field of <file-system> Ludovic Courtès
2018-05-26 13:24 ` [bug#31523] [PATCH 0/2] Getting rid of 'title' in 'file-system' declarations Ludovic Courtès
2018-05-26 14:10 ` Nils Gillmann
2018-05-28 12:53   ` bug#31523: " Ludovic Courtès
     [not found] <87tvqrqiw8.fsf@lapdog.tobias.gr>
2018-05-29 13:11 ` [bug#31523] " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).