From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fOQCH-0000Vh-SZ
	for guix-patches@gnu.org; Thu, 31 May 2018 12:13:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fOQCE-0001X0-MG
	for guix-patches@gnu.org; Thu, 31 May 2018 12:13:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:48339)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fOQCE-0001Wt-IF
	for guix-patches@gnu.org; Thu, 31 May 2018 12:13:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fOQCE-0004SX-7N
	for guix-patches@gnu.org; Thu, 31 May 2018 12:13:02 -0400
Subject: [bug#31621] [PATCH 2/3] gnu: service: Add hpcguix-web.
Resent-Message-ID: <handler.31621.B31621.152778315817108@debbugs.gnu.org>
From: ludovic.courtes@inria.fr (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180529085219.3eqr2xljbjtm7d7x@abyayala>
	<20180530094704.14910-1-pierre-antoine.rouby@inria.fr>
Date: Thu, 31 May 2018 18:12:30 +0200
In-Reply-To: <20180530094704.14910-1-pierre-antoine.rouby@inria.fr> (Rouby
	Pierre-Antoine's message of "Wed, 30 May 2018 11:47:04 +0200")
Message-ID: <87sh67ls7l.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Rouby Pierre-Antoine <pierre-antoine.rouby@inria.fr>
Cc: ng0@n0.is, 31621@debbugs.gnu.org

Rouby Pierre-Antoine <pierre-antoine.rouby@inria.fr> skribis:

> * gnu/service/web.scm (<hpcguix-web-configuration>): New record-type.
>   (%hpcguix-web-accounts): New variable.
>   (%hpcguix-web-activation,hpcguix-web-shepherd-service,
>   hpcguix-web-service-type): New procedures.
> * doc/guix.texi (Web Services): Add 'hpcguix-web'.

I think you had written a system test no?  Did it end up in a different
patch?

Apart from that it LGTM, thank you, and thanks Nils for the review!

Ludo=E2=80=99.