From: ludovic.courtes@inria.fr (Ludovic Courtès)
To: Rouby Pierre-Antoine <pierre-antoine.rouby@inria.fr>
Cc: ng0@n0.is, 31621@debbugs.gnu.org
Subject: [bug#31621] [PATCH 2/3] gnu: service: Add hpcguix-web.
Date: Thu, 31 May 2018 18:12:30 +0200 [thread overview]
Message-ID: <87sh67ls7l.fsf@gnu.org> (raw)
In-Reply-To: <20180530094704.14910-1-pierre-antoine.rouby@inria.fr> (Rouby Pierre-Antoine's message of "Wed, 30 May 2018 11:47:04 +0200")
Rouby Pierre-Antoine <pierre-antoine.rouby@inria.fr> skribis:
> * gnu/service/web.scm (<hpcguix-web-configuration>): New record-type.
> (%hpcguix-web-accounts): New variable.
> (%hpcguix-web-activation,hpcguix-web-shepherd-service,
> hpcguix-web-service-type): New procedures.
> * doc/guix.texi (Web Services): Add 'hpcguix-web'.
I think you had written a system test no? Did it end up in a different
patch?
Apart from that it LGTM, thank you, and thanks Nils for the review!
Ludo’.
next prev parent reply other threads:[~2018-05-31 16:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 13:24 [bug#31621] [PATCH 1/3] gnu: Add hpcguix-web Rouby Pierre-Antoine
2018-05-28 13:28 ` [bug#31621] [PATCH 2/3] gnu: service: " Rouby Pierre-Antoine
2018-05-29 8:31 ` Rouby Pierre-Antoine
2018-05-29 8:52 ` Nils Gillmann
2018-05-30 7:25 ` Pierre-Antoine Rouby
2018-05-30 9:47 ` Rouby Pierre-Antoine
2018-05-31 16:12 ` Ludovic Courtès [this message]
2018-05-28 13:28 ` [bug#31621] [PATCH 3/3] gnu: tests: " Rouby Pierre-Antoine
2018-05-29 8:57 ` [bug#31621] [PATCH 1/3] gnu: " Nils Gillmann
2018-05-30 9:41 ` Rouby Pierre-Antoine
2018-05-31 16:09 ` Ludovic Courtès
2018-05-31 22:38 ` Roel Janssen
2018-06-01 8:05 ` bug#31621: [PATCH 2/3] gnu: service: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh67ls7l.fsf@gnu.org \
--to=ludovic.courtes@inria.fr \
--cc=31621@debbugs.gnu.org \
--cc=ng0@n0.is \
--cc=pierre-antoine.rouby@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).