From: Oleg Pykhalov <go.wigust@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: 32394@debbugs.gnu.org
Subject: [bug#32394] [PATCH] gnu: restic: Fix tests.
Date: Wed, 08 Aug 2018 20:58:32 +0300 [thread overview]
Message-ID: <87sh3og2pj.fsf@gmail.com> (raw)
In-Reply-To: <20180808132215.GA16151@jasmine.lan> (Leo Famulari's message of "Wed, 8 Aug 2018 09:22:15 -0400")
[-- Attachment #1.1: Type: text/plain, Size: 461 bytes --]
Hello Leo,
Thank you for review.
Leo Famulari <leo@famulari.name> writes:
> On Wed, Aug 08, 2018 at 08:29:06AM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/backup.scm (restic)[arguments]: Replace 'check' phase.
>
> Thanks, LGTM! Should we report the issues upstream?
I've played little bit more and found that
‘internal/backend/rest/rest_int_test.go’ is actually passes.
Pushed 4976ebddf1a4735ee12808083876f573121993bf as with changes:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Don't remove internal/backend/rest/rest_int_test.go --]
[-- Type: text/x-patch, Size: 1388 bytes --]
diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index bca070d3f..251dadf84 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -850,9 +850,6 @@ is like a time machine for your data. ")
(build-system go-build-system)
(arguments
`(#:import-path "github.com/restic/restic"
- #:modules ((srfi srfi-26)
- (guix build go-build-system)
- (guix build utils))
#:unpack-path "github.com/restic"
;; We don't need to install the source code for end-user applications.
#:install-source? #f
@@ -870,11 +867,8 @@ is like a time machine for your data. ")
(with-directory-excursion (string-append
"src/github.com/restic/restic-"
,version)
- (for-each (cut delete-file <>)
- '(;; Requires a network.
- "internal/backend/rest/rest_int_test.go"
- ;; unexpected error: fusermount: exit status 1
- "cmd/restic/integration_fuse_test.go"))
+ ;; unexpected error: fusermount: exit status 1
+ (delete-file "cmd/restic/integration_fuse_test.go")
(invoke "go" "run" "build.go" "--test"))))
(replace 'install
[-- Attachment #1.3: Type: text/plain, Size: 126 bytes --]
I'm not sure about reporting to upstream, because I think fusermount
fail in a build process is Guix specific. WDYT?
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-08-08 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 5:29 [bug#32394] [PATCH] gnu: restic: Fix tests Oleg Pykhalov
2018-08-08 13:22 ` Leo Famulari
2018-08-08 17:58 ` Oleg Pykhalov [this message]
2018-08-08 18:50 ` Leo Famulari
2018-08-08 20:44 ` Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh3og2pj.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=32394@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).