From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48116)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVTey-0001hk-1v
	for guix-patches@gnu.org; Fri, 07 Dec 2018 22:52:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVTet-00035O-2n
	for guix-patches@gnu.org; Fri, 07 Dec 2018 22:52:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:33218)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gVTes-000357-Oy
	for guix-patches@gnu.org; Fri, 07 Dec 2018 22:52:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVTes-0003BN-Fo
	for guix-patches@gnu.org; Fri, 07 Dec 2018 22:52:02 -0500
Subject: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are
	sorted.
Resent-Message-ID: <handler.33575.B33575.154424111912221@debbugs.gnu.org>
From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=)
References: <20181202074210.31361-1-arunisaac@systemreboot.net>
Date: Sat, 08 Dec 2018 11:51:43 +0800
In-Reply-To: <20181202074210.31361-1-arunisaac@systemreboot.net> (Arun Isaac's
	message of "Sun, 2 Dec 2018 13:12:10 +0530")
Message-ID: <87sgz8ekvk.fsf@member.fsf.org>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 33575@debbugs.gnu.org

Arun Isaac <arunisaac@systemreboot.net> writes:

> * guix/scripts/lint.scm (check-inputs-should-be-sorted): New procedure.
> (%checkers): Add it.
> [...]
>  
> +(define (check-inputs-should-be-sorted package)
> +  ;; Emit a warning if inputs, native inputs or propagated inputs of PACKAGE
> +  ;; are not lexicographically ordered.

Hello, consider 'gspell', it has some native-inputs for build and some
for test:

    (native-inputs
     `(("glib" ,glib "bin")
       ("pkg-config" ,pkg-config)
       ("xmllint" ,libxml2)

       ;; For tests.
       ("aspell-dict-en" ,aspell-dict-en)
       ("xorg-server" ,xorg-server)))

Currently I'd seperated them by a comment like this.

If they are sorted, I have to add comment for each test input:

  `(("aspell-dict-en", aspecll-dict-en) ; for test
    ("glib" ,glib "bin")
    ("pkg-config" ,pkg-config)
    ("xmllint" ,libxml2)
    ("xorg-server" ,xorg-server))       ; for test

Which will be a little annoying...