From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gnpUO-00019O-9l for guix-patches@gnu.org; Sun, 27 Jan 2019 13:49:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gnpUN-0007FQ-Et for guix-patches@gnu.org; Sun, 27 Jan 2019 13:49:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48661) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gnpUN-0007F0-B7 for guix-patches@gnu.org; Sun, 27 Jan 2019 13:49:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gnpUM-0006Mm-Ih for guix-patches@gnu.org; Sun, 27 Jan 2019 13:49:02 -0500 Subject: [bug#34222] [PATCH 11/15] gnu: Add ruby-cliver. Resent-Message-ID: References: <87y376ghl0.fsf@cbaines.net> <20190127170820.28937-1-mail@cbaines.net> <20190127170820.28937-11-mail@cbaines.net> <87sgxerofh.fsf@elephly.net> From: Christopher Baines In-reply-to: <87sgxerofh.fsf@elephly.net> Date: Sun, 27 Jan 2019 18:48:34 +0000 Message-ID: <87sgxegcn1.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 34222@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ricardo Wurmus writes: > Christopher Baines writes: > >> Requirement of ruby-parser. >> >> * gnu/packages/ruby.scm (ruby-cliver): New variable. > [=E2=80=A6] > >> + (arguments >> + '(#:phases >> + (modify-phases %standard-phases >> + ;; Avoid this issue with rspec@2 >> + ;; NoMethodError: undefined method `last_comment' >> + (replace 'check >> + (lambda* (#:key tests? #:allow-other-keys) >> + (when tests? >> + (invoke "rspec")) >> + #t))))) >> + (native-inputs >> + `(("bundler" ,bundler) >> + ("ruby-rspec" ,ruby-rspec-2))) > > Is this a problem that would disappear when using a later version of > Rspec? I don't think so, I get a different exception which looks to me like an incompatibility between the tests and rspec@3 in Guix. This `last_comment' related error is a issue between Rspec 2 and more recent versions of Rake, and I've updated the comment as below to try and explain this. + (Build-system ruby-build-system) + (arguments + '(#:phases + (modify-phases %standard-phases + ;; Avoid a incompatibility between rspec@2 and rake. Using rspec@3 + ;; would be nice, but the tests look to be incompatible: + ;; + ;; NoMethodError: undefined method `last_comment' + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (invoke "rspec")) + #t))))) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlxN/QJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcZqg//UMLwelOrRsQlClAhS00Qhio13muASIzxszkSoeQFF+p2OAgFTqgfMklA phnYZgXdW4sICncyADjXu9Jeu5CHJDhob1ISEfghyHJ/CbHKRf4y5XUPmQsyNQNP HjLc0G+xs1+McEYUAzDC1g89LLeMClxSpABYg15dHlSkxulgGIhtr5WMF2jvRRa8 xU2mqV89SEOui5EqJ459ekqWejCvaUEsQnwRlvx0g8N3cFcYYTMNsNGWAZZPUcc9 EakZRIShXKJilP07Kjssjkjz0Lww9H0Kszw12Y3JpZsSFsctlkcX2XlFbMuJo2kf 7yQhQJEg6RKuGZH6AOWRnEKq3816Ha76g0mVAuzu3MYqCMSydVBHQ/qkRIJGi9Y5 DVMWDd3ElbK8/9ab1bM/md2JhGa3A+Xd68vZWe95h27JolCcwkfRtePXzhPWNF+q yG+hNSst9rAbJBP7Kzv4Dq1Q1KA5Dih0dPkqE383C2KTg/c5R523CmH652U3tT3b oAdt3xQf2IFp+HCTh5D1cFvgyolK5VYE/WxO8klr/RDPbtxqEt0kyLWCei0qeKGs VqmWB/O2hljBTp4mMByWJd0tHigY8rIK+PIFBWZRV+PCh2m7mBnIpJkhLeRPI76r EhozmIGVosJnzVtSu6XAws+UgBGaWz/WemsGzNbSKS2uCovn9FM= =zc2P -----END PGP SIGNATURE----- --=-=-=--