* [bug#34365] [PATCH] gnu: Add python-daemon.
@ 2019-02-07 9:42 Vagrant Cascadian
2019-02-07 9:49 ` Ricardo Wurmus
0 siblings, 1 reply; 6+ messages in thread
From: Vagrant Cascadian @ 2019-02-07 9:42 UTC (permalink / raw)
To: 34365
[-- Attachment #1: Type: text/plain, Size: 2703 bytes --]
* gnu/packages/python-xyz.scm (python-daemon): New variable.
---
gnu/packages/python-xyz.scm | 51 +++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index d2b348942..f8a6db720 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -2188,6 +2188,57 @@ logging and tracing of the execution.")
(define-public python2-joblib
(package-with-python2 python-joblib))
+(define-public python-daemon
+ (package
+ (name "python-daemon")
+ (version "2.2.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "python-daemon" version))
+ (sha256
+ (base32
+ "09fcjdjzk9ywmpnrj62iyxqgcygzdafsz41qlrk2dknzbagcmzmg"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'disable-tests
+ (lambda _
+ ;; FIXME: Determine why test fails
+ (substitute* "test/test_daemon.py"
+ (("test_detaches_process_context")
+ "skip_test_detaches_process_context")))))))
+ (propagated-inputs
+ `(("python-docutils" ,python-docutils)
+ ("python-lockfile" ,python-lockfile)
+ ("python-setuptools" ,python-setuptools)))
+ (native-inputs
+ `(("python-unittest2" ,python-unittest2)
+ ("python-testtools" ,python-testtools)
+ ("python-testscenarios" ,python-testscenarios)
+ ("python-mock" ,python-mock)
+ ("python-docutils" ,python-docutils)))
+ (home-page "https://pagure.io/python-daemon/")
+ (synopsis "Python library for making a Unix daemon process")
+ (description "Python-daemon is a library that assists a Python program to
+turn itself into a well-behaved Unix daemon process, as specified in PEP 3143.
+
+This library provides a @code{DaemonContext} class that manages the following
+important tasks for becoming a daemon process:
+@enumerate
+@item Detach the process into its own process group.
+@item Set process environment appropriate for running inside a chroot.
+@item Renounce suid and sgid privileges.
+@item Close all open file descriptors.
+@item Change the working directory, uid, gid, and umask.
+@item Set appropriate signal handlers.
+@item Open new file descriptors for stdin, stdout, and stderr.
+@item Manage a specified PID lock file.
+@item Register cleanup functions for at-exit processing.
+@end enumerate")
+ (license (list license:asl2.0 license:gpl3+))))
+
(define-public python-docutils
(package
(name "python-docutils")
--
2.20.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* [bug#34365] [PATCH] gnu: Add python-daemon.
2019-02-07 9:42 [bug#34365] [PATCH] gnu: Add python-daemon Vagrant Cascadian
@ 2019-02-07 9:49 ` Ricardo Wurmus
2019-02-07 11:42 ` Vagrant Cascadian
0 siblings, 1 reply; 6+ messages in thread
From: Ricardo Wurmus @ 2019-02-07 9:49 UTC (permalink / raw)
To: Vagrant Cascadian; +Cc: 34365
Hi Vagrant,
> * gnu/packages/python-xyz.scm (python-daemon): New variable.
Thanks for the patch!
> + (add-before 'check 'disable-tests
> + (lambda _
> + ;; FIXME: Determine why test fails
> + (substitute* "test/test_daemon.py"
> + (("test_detaches_process_context")
> + "skip_test_detaches_process_context")))))))
Before pushing this I’ll add a final #T to this phase. (In the past #F
would indicate failure, but that’s on longer the case. “substitute*”
annoyingly returns an unspecified value.)
> + (propagated-inputs
> + `(("python-docutils" ,python-docutils)
> + ("python-lockfile" ,python-lockfile)
> + ("python-setuptools" ,python-setuptools)))
> + (native-inputs
> + `(("python-unittest2" ,python-unittest2)
> + ("python-testtools" ,python-testtools)
> + ("python-testscenarios" ,python-testscenarios)
> + ("python-mock" ,python-mock)
> + ("python-docutils" ,python-docutils)))
Docutils is both among native inputs as well as regular inputs. Is this
intended?
> + (license (list license:asl2.0 license:gpl3+))))
What does this list mean?
--
Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread* [bug#34365] [PATCH] gnu: Add python-daemon.
2019-02-07 9:49 ` Ricardo Wurmus
@ 2019-02-07 11:42 ` Vagrant Cascadian
2019-02-07 13:07 ` Ricardo Wurmus
0 siblings, 1 reply; 6+ messages in thread
From: Vagrant Cascadian @ 2019-02-07 11:42 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: 34365
[-- Attachment #1: Type: text/plain, Size: 2167 bytes --]
On 2019-02-07, Ricardo Wurmus wrote:
>> * gnu/packages/python-xyz.scm (python-daemon): New variable.
>
> Thanks for the patch!
Thanks for the lightning fast review!
>> + (add-before 'check 'disable-tests
>> + (lambda _
>> + ;; FIXME: Determine why test fails
>> + (substitute* "test/test_daemon.py"
>> + (("test_detaches_process_context")
>> + "skip_test_detaches_process_context")))))))
>
> Before pushing this I’ll add a final #T to this phase. (In the past #F
> would indicate failure, but that’s on longer the case. “substitute*”
> annoyingly returns an unspecified value.)
My eyes still have trouble identifying where exactly this would
go... and #T/#F vs. #t/#f has me a bit confused for good measure!
Obviously, it'd be better to fix the test, or at least understand why it
fails...
>> + (propagated-inputs
>> + `(("python-docutils" ,python-docutils)
>> + ("python-lockfile" ,python-lockfile)
>> + ("python-setuptools" ,python-setuptools)))
>> + (native-inputs
>> + `(("python-unittest2" ,python-unittest2)
>> + ("python-testtools" ,python-testtools)
>> + ("python-testscenarios" ,python-testscenarios)
>> + ("python-mock" ,python-mock)
>> + ("python-docutils" ,python-docutils)))
>
> Docutils is both among native inputs as well as regular inputs. Is this
> intended?
I *think* it only needs to be in native-inputs; I think propagated
outputs was generated by the importer... and now that my attention is
drawn to it, I'm dubious of python-setuptools needing to be in
propagated-inputs as well. I can update it and check again later...
>> + (license (list license:asl2.0 license:gpl3+))))
>
> What does this list mean?
I guess it's best practice in Guix to make a comment when multiple
licenses are listed?
Apparently only setup.py is gpl3+, everything else is apache 2.0
licensed. That was my quick look at the code itself, and basically
confirmed by:
https://sources.debian.org/src/python-daemon/2.2.3-1/debian/copyright/
live well,
vagrant
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [bug#34365] [PATCH] gnu: Add python-daemon.
2019-02-07 11:42 ` Vagrant Cascadian
@ 2019-02-07 13:07 ` Ricardo Wurmus
2019-02-07 14:49 ` Vagrant Cascadian
0 siblings, 1 reply; 6+ messages in thread
From: Ricardo Wurmus @ 2019-02-07 13:07 UTC (permalink / raw)
To: Vagrant Cascadian; +Cc: 34365
Vagrant Cascadian <vagrant@debian.org> writes:
>> Before pushing this I’ll add a final #T to this phase. (In the past #F
>> would indicate failure, but that’s on longer the case. “substitute*”
>> annoyingly returns an unspecified value.)
>
> My eyes still have trouble identifying where exactly this would
> go... and #T/#F vs. #t/#f has me a bit confused for good measure!
Oh sorry. It should go after the (substitute* …) clause. We sometimes
capitalize variable names and values when referring to them. We would
write “#t” here.
>>> + (license (list license:asl2.0 license:gpl3+))))
>>
>> What does this list mean?
>
> I guess it's best practice in Guix to make a comment when multiple
> licenses are listed?
Yes. We don’t have a syntactic way to express license algebra, so we
usually add a comment when a list of licenses applies.
> Apparently only setup.py is gpl3+, everything else is apache 2.0
> licensed. That was my quick look at the code itself, and basically
> confirmed by:
>
> https://sources.debian.org/src/python-daemon/2.2.3-1/debian/copyright/
Excellent. This can be added as a short comment above the license
field.
Thanks!
--
Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#34365] [PATCH] gnu: Add python-daemon.
2019-02-07 13:07 ` Ricardo Wurmus
@ 2019-02-07 14:49 ` Vagrant Cascadian
2019-02-11 9:48 ` bug#34365: " Danny Milosavljevic
0 siblings, 1 reply; 6+ messages in thread
From: Vagrant Cascadian @ 2019-02-07 14:49 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: 34365
[-- Attachment #1.1: Type: text/plain, Size: 916 bytes --]
On 2019-02-07, Ricardo Wurmus wrote:
> Vagrant Cascadian <vagrant@debian.org> writes:
>
>>> Before pushing this I’ll add a final #T to this phase. (In the past #F
>>> would indicate failure, but that’s on longer the case. “substitute*”
>>> annoyingly returns an unspecified value.)
...
>>>> + (license (list license:asl2.0 license:gpl3+))))
>>>
>>> What does this list mean?
...
>> Apparently only setup.py is gpl3+, everything else is apache 2.0
>> licensed. That was my quick look at the code itself, and basically
>> confirmed by:
>>
>> https://sources.debian.org/src/python-daemon/2.2.3-1/debian/copyright/
>
> Excellent. This can be added as a short comment above the license
> field.
Ok, the attached patch should address the above two issues and removed
the needless python-setuptools and python-docutils propagated inputs
mentioned earlier.
live well,
vagrant
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-python-daemon.patch --]
[-- Type: text/x-diff, Size: 2898 bytes --]
From e22c1ac09a3db62eca7db12d4322672ab18c2ffc Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@debian.org>
Date: Thu, 7 Feb 2019 01:27:41 -0800
Subject: [PATCH] gnu: Add python-daemon.
* gnu/packages/python-xyz.scm (python-daemon): New variable.
---
gnu/packages/python-xyz.scm | 51 +++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index d2b348942..cf293c004 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -2188,6 +2188,57 @@ logging and tracing of the execution.")
(define-public python2-joblib
(package-with-python2 python-joblib))
+(define-public python-daemon
+ (package
+ (name "python-daemon")
+ (version "2.2.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "python-daemon" version))
+ (sha256
+ (base32
+ "09fcjdjzk9ywmpnrj62iyxqgcygzdafsz41qlrk2dknzbagcmzmg"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'disable-tests
+ (lambda _
+ ;; FIXME: Determine why test fails
+ (substitute* "test/test_daemon.py"
+ (("test_detaches_process_context")
+ "skip_test_detaches_process_context"))
+ #t)))))
+ (propagated-inputs
+ `(("python-lockfile" ,python-lockfile)))
+ (native-inputs
+ `(("python-unittest2" ,python-unittest2)
+ ("python-testtools" ,python-testtools)
+ ("python-testscenarios" ,python-testscenarios)
+ ("python-mock" ,python-mock)
+ ("python-docutils" ,python-docutils)))
+ (home-page "https://pagure.io/python-daemon/")
+ (synopsis "Python library for making a Unix daemon process")
+ (description "Python-daemon is a library that assists a Python program to
+turn itself into a well-behaved Unix daemon process, as specified in PEP 3143.
+
+This library provides a @code{DaemonContext} class that manages the following
+important tasks for becoming a daemon process:
+@enumerate
+@item Detach the process into its own process group.
+@item Set process environment appropriate for running inside a chroot.
+@item Renounce suid and sgid privileges.
+@item Close all open file descriptors.
+@item Change the working directory, uid, gid, and umask.
+@item Set appropriate signal handlers.
+@item Open new file descriptors for stdin, stdout, and stderr.
+@item Manage a specified PID lock file.
+@item Register cleanup functions for at-exit processing.
+@end enumerate")
+ ;; Only setup.py is gpl3+, everything else is apache 2.0 licensed.
+ (license (list license:asl2.0 license:gpl3+))))
+
(define-public python-docutils
(package
(name "python-docutils")
--
2.20.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-11 9:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-07 9:42 [bug#34365] [PATCH] gnu: Add python-daemon Vagrant Cascadian
2019-02-07 9:49 ` Ricardo Wurmus
2019-02-07 11:42 ` Vagrant Cascadian
2019-02-07 13:07 ` Ricardo Wurmus
2019-02-07 14:49 ` Vagrant Cascadian
2019-02-11 9:48 ` bug#34365: " Danny Milosavljevic
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).