From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:50933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxG2X-0004L9-IO for guix-patches@gnu.org; Fri, 22 Feb 2019 13:59:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxG1M-0007zW-Eb for guix-patches@gnu.org; Fri, 22 Feb 2019 13:58:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35026) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gxG1K-0007tp-HP for guix-patches@gnu.org; Fri, 22 Feb 2019 13:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gxG1K-0003t5-BZ for guix-patches@gnu.org; Fri, 22 Feb 2019 13:58:02 -0500 Subject: [bug#34615] [PATCH] gnu: Add libtommath. Resent-Message-ID: From: Tobias Geerinckx-Rice References: <20190222122014.21600-1-efraim@flashner.co.il> In-reply-to: <20190222122014.21600-1-efraim@flashner.co.il> Date: Fri, 22 Feb 2019 19:57:25 +0100 Message-ID: <87sgwfvega.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 34615@debbugs.gnu.org Efraim, Thanks! Efraim Flashner wrote: > * gnu/packages/algebra.scm (libtommath): New variable. > + (add-after 'unpack 'prepare-build > + (lambda _ > + ;; Don't pull in coreutils. > + (substitute* "makefile_include.mk" > + (("arch") "uname -m")) I'd add an empty line here or separate this into two fases just to=20 be very clear, since=E2=80=A6 > + (delete-file "makefile") > + (symlink "makefile.shared" "makefile") > + #t)) =E2=80=A6I got a bit lost between all these makefiles. Could you explain=20 exactly what's going on? Is this to avoid repeating =E2=80=98-f makefile.shared=E2=80=99 elsewhere? > + (add-after 'check 'make-static More accurate: 'install-static-library. While libtommath.a is =E2=80=98only=E2=80=99 332K, that's almost half of th= e=20 entire output size. Is it worth moving to a separate :static=20 output? > + (synopsis "portable number theoretic multiple-precision=20 > integer library") s/p/P/ multiprecision.scm is a better fit and already has sister package=20 tomsfastmath to keep this one company. > +integer library written entirely in C. The library is designed=20 > to provide a s/The library is/It's/ IMO. > +simple to work with API =E2=80=98simple-to-work-with API=E2=80=99, unfortunately. Kind regards, T G-R