unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <mail@ambrevar.xyz>
To: 34758@debbugs.gnu.org
Subject: [bug#34758] Acknowledgement ([PATCH 1/4] gnu: Add libmirage.)
Date: Tue, 05 Mar 2019 18:44:25 +0100	[thread overview]
Message-ID: <87sgw1fc7a.fsf@ambrevar.xyz> (raw)
In-Reply-To: <handler.34758.B.15518068039570.ack@debbugs.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]

libmirage, cdemu-daemon and cdemu-client seems to be fine.

The VHBA kernel module is not package properly and this a blocker for
cdemu-daemon.

1. This raises the more general issue of building kernel modules on Guix.

For the record, here is the VHBA makefile:

--8<---------------cut here---------------start------------->8---
VHBA_VERSION := 20170610

KERNELRELEASE ?= $(shell uname -r)
KDIR ?= /lib/modules/$(KERNELRELEASE)/build
PWD ?= $(shell pwd)

obj-m := vhba.o
ccflags-y := -DVHBA_VERSION=\"$(VHBA_VERSION)\" -Werror

default: modules
install: modules_install

modules modules_install clean:
	$(MAKE) -C $(KDIR) M=$(PWD) $@
--8<---------------cut here---------------end--------------->8---

As you can see, it relies on the Makefile (and probably a bunch of other
files) in /lib/modules/$(KERNELRELEASE)/build.

In our linux-libre package, "build" is a broken symlink, e.g. to
/tmp/guix-build-linux-libre-4.20.12.../linux-4.20.12.

Shouldn't we include this folder in the linux-libre package?  Without
it, I can't see how to build kernel modules.

Once we have this, we will be able to build vhba-module.



2. Next question: how do we load this module?  In `operating-system' we
have `initrd-modules', but in this case vhba is probably not needed in
the initrd.  What we really want, I think, is a union of kernel modules
in say

/run/booted-system/kernel/lib/modules/4.20.7/

Makes sense?

Thoughts?

--
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  parent reply	other threads:[~2019-03-05 17:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 17:26 [bug#34758] [PATCH 1/4] gnu: Add libmirage Pierre Neidhardt
2019-03-05 17:28 ` [bug#34758] [PATCH 2/4] gnu: Add vhba Pierre Neidhardt
2019-03-05 17:28   ` [bug#34758] [PATCH 3/4] gnu: Add cdemu-daemon Pierre Neidhardt
2019-03-22 21:13     ` Ludovic Courtès
2019-03-05 17:28   ` [bug#34758] [PATCH 4/4] gnu: Add cdemu-client Pierre Neidhardt
2019-03-22 21:14     ` Ludovic Courtès
2019-03-22 21:25       ` Pierre Neidhardt
2019-03-22 21:12   ` [bug#34758] [PATCH 2/4] gnu: Add vhba Ludovic Courtès
2019-03-22 21:24     ` Pierre Neidhardt
2019-03-22 21:27       ` Pierre Neidhardt
2019-03-23 14:52       ` Ludovic Courtès
2019-03-25  8:35         ` Pierre Neidhardt
2019-03-25 21:10           ` Ludovic Courtès
     [not found] ` <handler.34758.B.15518068039570.ack@debbugs.gnu.org>
2019-03-05 17:44   ` Pierre Neidhardt [this message]
2019-03-22 21:10 ` [bug#34758] [PATCH 1/4] gnu: Add libmirage Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgw1fc7a.fsf@ambrevar.xyz \
    --to=mail@ambrevar.xyz \
    --cc=34758@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).