From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:33234)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hdw2B-000187-M3
 for guix-patches@gnu.org; Thu, 20 Jun 2019 08:19:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hdw0x-0001qa-0f
 for guix-patches@gnu.org; Thu, 20 Jun 2019 08:18:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:34461)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hdw0w-0001qH-US
 for guix-patches@gnu.org; Thu, 20 Jun 2019 08:18:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hdw0w-0005sa-PJ
 for guix-patches@gnu.org; Thu, 20 Jun 2019 08:18:02 -0400
Subject: bug#36244: [PATCH] guix: canonical-newline-port: Fix handling of
 carriage return at buffer end.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.36244.D36244.156103304422525.done@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190616141829.28689-1-rob@vllmrt.net>
Date: Thu, 20 Jun 2019 13:59:13 +0200
In-Reply-To: <20190616141829.28689-1-rob@vllmrt.net> (Robert Vollmert's
 message of "Sun, 16 Jun 2019 16:18:29 +0200")
Message-ID: <87sgs4jwmm.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Robert Vollmert <rob@vllmrt.net>
Cc: 36244-done@debbugs.gnu.org

Hi Robert,

Robert Vollmert <rob@vllmrt.net> skribis:

> Prior to this change the added test fails for me locally at byte
> 1024. It might depend on some default buffer sizes.
>
> Fixes https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35863
>
> * tests/utils.scm ("canonical-newline-port-1024"): Add test.
> * guix/utils.scm (canonical-newline-port): Correct comments on CR/LF.
> Remove CR even when they're at the end of the buffer.

Good catch.  I tweaked the commit log and applied it.

Thanks,
Ludo=E2=80=99.