[bug#37493] [bug#37519] [PATCH v2 2/2] gnu: add iwd.

[bug#37493] [bug#37519] [PATCH v2 2/2] gnu: add iwd.

[Ludovic Courtès]

Hi Brice,

"brice@waegenei.re" <brice@waegenei.re> skribis:

> On 29 September, 2019 23:01 CEST, Ludovic Courtès <ludo@gnu.org> wrote: 
>  
>> I didn’t know about the add_key(2) syscall, but looking at the man page,
>> it seems that the “asymmetric” type is not supported (but EBADMSG is not
>> documented either…).
>
> It was missing the kernel module pkcs8_key_parser, as explained in src/pkcs8.conf. Since we can't load it at build time, I disabled the test. Following is the content of src/pkcs8.conf:
>
>  # When distributions use CONFIG_PKCS8_PRIVATE_KEY_PARSER=m kernel option,
> # using keyctl(2) will fail for loading PKCS#8 private keys since there is
> # no automatic module loading for key type parsers.  This entry ensures
> # that the kernel module pkcs8_key_parser.ko is loaded at boot time.

Oh, I see, thanks for explaining.

So what about skipping the test altogether (because we cannot guarantee
that the kernel will have that kernel module), along the lines of the
Alpine patch you showed, but with a comment explaining why we skip the
test?

Thank you,
Ludo’.

[bug#37519] [PATCH v2 2/2] gnu: add iwd.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 1379 bytes --]

Hi,

> > It was missing the kernel module pkcs8_key_parser, as explained in src/pkcs8.conf. Since we can't load it at build time, I disabled the test.

It's fine to do it like that in that case, but just some food for thought:

We often disable tests in cases like that because writing system tests for something like that is annoying if one has to do it manually.

Would it be possible to discover packages which need those kinds of tests (if necessary just specify an "argument" in the package record) and automatically create&run system tests for them?  Guix would then run all the tests in a qemu-system container.

Something like

  $ make TESTS=packages check-system

which would:

* Traverse all the packages with (#:run-tests-as-system-tests? #t)
* Automatically set up a system test to run the tests of all of these packages.  Basically we could just provide guix-daemon inside a qemu guest and build the same derivation again in there, letting it load Linux kernel modules however it wants.

Especially Linux kernel-requiring (or worse, -modifying) tests are otherwise impossible to do.

Long term, I don't feel good excluding all those tests just because they are low-level.

Docs:

>there is no automatic module loading for key type parsers

Why not?  Weird... there's require_module, was it not thought of--or is it inapplicable somehow?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]