unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "brice@waegenei.re" <brice@waegenei.re>
Cc: 37519@debbugs.gnu.org, 37493@debbugs.gnu.org
Subject: [bug#37493] [bug#37519] [PATCH v2  2/2] gnu: add iwd.
Date: Tue, 01 Oct 2019 10:27:03 +0200	[thread overview]
Message-ID: <87sgocuazs.fsf@gnu.org> (raw)
In-Reply-To: <793d-5d921680-4d-485b8300@90758574> (brice@waegenei.re's message of "Mon, 30 Sep 2019 16:50:55 +0200")

Hi Brice,

"brice@waegenei.re" <brice@waegenei.re> skribis:

> On 29 September, 2019 23:01 CEST, Ludovic Courtès <ludo@gnu.org> wrote: 
>  
>> I didn’t know about the add_key(2) syscall, but looking at the man page,
>> it seems that the “asymmetric” type is not supported (but EBADMSG is not
>> documented either…).
>
> It was missing the kernel module pkcs8_key_parser, as explained in src/pkcs8.conf. Since we can't load it at build time, I disabled the test. Following is the content of src/pkcs8.conf:
>
>  # When distributions use CONFIG_PKCS8_PRIVATE_KEY_PARSER=m kernel option,
> # using keyctl(2) will fail for loading PKCS#8 private keys since there is
> # no automatic module loading for key type parsers.  This entry ensures
> # that the kernel module pkcs8_key_parser.ko is loaded at boot time.

Oh, I see, thanks for explaining.

So what about skipping the test altogether (because we cannot guarantee
that the kernel will have that kernel module), along the lines of the
Alpine patch you showed, but with a comment explaining why we skip the
test?

Thank you,
Ludo’.

       reply	other threads:[~2019-10-01  8:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <793d-5d921680-4d-485b8300@90758574>
2019-10-01  8:27 ` Ludovic Courtès [this message]
2019-10-01 22:30   ` [bug#37519] [PATCH v2 2/2] gnu: add iwd Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgocuazs.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=37493@debbugs.gnu.org \
    --cc=37519@debbugs.gnu.org \
    --cc=brice@waegenei.re \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).