From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:50133)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ifQCB-00037m-E1
 for guix-patches@gnu.org; Thu, 12 Dec 2019 10:16:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ifQCA-0007sJ-Fb
 for guix-patches@gnu.org; Thu, 12 Dec 2019 10:16:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:54832)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ifQCA-0007rq-BF
 for guix-patches@gnu.org; Thu, 12 Dec 2019 10:16:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ifQCA-0006vy-55
 for guix-patches@gnu.org; Thu, 12 Dec 2019 10:16:02 -0500
Subject: [bug#37730] [PATCH] Topologically sort recursively-imported packages
Resent-Message-ID: <handler.37730.D37730.157616371326486@debbugs.gnu.org>
References: <CAAc=MEycXPYeT_ZhkyQNO7Gusjj7tNixdAr7mVQgoS82ruoZrQ@mail.gmail.com>
 <87lfti5rip.fsf@gnu.org>
 <CAAc=MEyzhSWtmLwrfXmz1tr3_R74xenERX53gRuP4hOiiGXX8g@mail.gmail.com>
 <CAAc=MEwpYfW5OdgNv6Xm-db2LoKo=hnEE+70Q5DHu+23K19WMw@mail.gmail.com>
 <87immqpww5.fsf@gnu.org>
 <CAAc=MEwYSqMqdOE62YeH248DrvyE9vk0t3U8wOagdq-hY+cK9w@mail.gmail.com>
 <87pngvje7f.fsf@gnu.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <87pngvje7f.fsf@gnu.org>
Date: Thu, 12 Dec 2019 16:15:01 +0100
Message-ID: <87sglp379m.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Brian Leung <bkleung89@gmail.com>, 37730-done@debbugs.gnu.org


Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Hi Brian,
>
> Brian Leung <bkleung89@gmail.com> skribis:
>
>>> If that=E2=80=99s fine with you, I=E2=80=99d be willing to apply this p=
atch, and then
>>> apply other bits of your patch (the tests and stream removal) on top of
>>> it.  How does that sound?
>>
>> Sure, your patch seems clearer to me.
>
> I pushed patches that combine mine and yours:
>
>   4982de4c32 import: crate: Add recursive import test.
>   70a8e13277 import: utils: 'recursive-import' returns a list rather than=
 a stream.
>   ddd5915900 import: utils: 'recursive-import' returns packages in topolo=
gical order.

Thank you!

> Let me know if you notice anything wrong!

I believe the docstring of RECURSIVE-IMPORT in (guix import utils) needs
to be adjusted.  It still refers to streams.

--=20
Ricardo