From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:54937)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jEDq3-0002Ty-Eb
 for guix-patches@gnu.org; Tue, 17 Mar 2020 11:09:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jEDq2-0008OD-7j
 for guix-patches@gnu.org; Tue, 17 Mar 2020 11:09:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:33440)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jEDq2-0008N0-3M
 for guix-patches@gnu.org; Tue, 17 Mar 2020 11:09:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jEDq1-00037t-Tg
 for guix-patches@gnu.org; Tue, 17 Mar 2020 11:09:01 -0400
Subject: [bug#40104] [PATCH 1/1] gnu: Add emacs-org-static-blog.
Resent-Message-ID: <handler.40104.B40104.158445769011939@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <20200317141253.25851-1-brice@waegenei.re>
 <20200317141253.25851-2-brice@waegenei.re>
Date: Tue, 17 Mar 2020 16:07:58 +0100
In-Reply-To: <20200317141253.25851-2-brice@waegenei.re> (Brice Waegeneire's
 message of "Tue, 17 Mar 2020 15:12:53 +0100")
Message-ID: <87sgi7t3xt.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 40104@debbugs.gnu.org

Hello,

Brice Waegeneire <brice@waegenei.re> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-static-blog): New variable.

Thank you.

> +(define-public emacs-org-static-blog
> +  (package
> +   (name "emacs-org-static-blog")
> +   (version "20200117.800")

Could you explain in a comment why using an unstable release is
required?

> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri (string-append
> +           "https://melpa.org/packages/org-static-blog-"
> +           version ".el"))

It seems upstream is at Github, not MELPA. Could you use Github instead?

> +   (home-page
> +    "https://github.com/bastibe/org-static-blog")
> +   (synopsis
> +    "Simple org-mode based static blog generator")

Nitpick: Simple Org mode based static blog generator

> +   (description
> +    "Org-static-blog is one more static blog generator, it focuses on being
> +simple.  All files are simple org-mode files in a directory.  

Nitpick: All file are simple Org files in a directory.

> The only
> +requirement is that every org file must have a #+TITLE and a #+DATE, and
> +optionally, #+FILETAGS.")

Nitpick: every Org file must have a @samp{title} and a @samp{date}
keywords, and optionally, a @samp{filetags} keyword.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou