From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:59539)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jEVQh-0007IW-J5
 for guix-patches@gnu.org; Wed, 18 Mar 2020 05:56:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jEVQg-0003t6-Kx
 for guix-patches@gnu.org; Wed, 18 Mar 2020 05:56:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:33852)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jEVQg-0003sA-FP
 for guix-patches@gnu.org; Wed, 18 Mar 2020 05:56:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jEVQg-0007Ui-Eb
 for guix-patches@gnu.org; Wed, 18 Mar 2020 05:56:02 -0400
Subject: [bug#39710] [PATCH] Add foobillardplus
Resent-Message-ID: <handler.39710.B39710.158452534528785@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87wo8gfieo.fsf@nicolasgoaziou.fr>
Date: Wed, 18 Mar 2020 10:55:33 +0100
In-Reply-To: <87wo8gfieo.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
 "Fri, 21 Feb 2020 09:34:23 +0100")
Message-ID: <87sgi69ecq.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 39710@debbugs.gnu.org

Hi,

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

>>>From f54b3ec7e59fb09550ce73443c570098a907267f Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
> Date: Fri, 21 Feb 2020 09:32:01 +0100
> Subject: [PATCH] gnu: Add foobillardplus.
>
> * gnu/packages/games.scm (foobillardplus): New variable.
> * gnu/packages/patches/foobillardplus-pkg-config.patch: New file.
> * gnu/local.mk: Reference new file.

[...]

> +(define-public foobillardplus
> +  (let ((svn-revision 170))

Could you add a comment explaining why you choose this revision rather
than the latest release?

Otherwise LGTM, thanks!

Ludo=E2=80=99.