From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:59056) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHEip-0004Jy-5i for guix-patches@gnu.org; Wed, 25 Mar 2020 18:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHEio-0005QB-99 for guix-patches@gnu.org; Wed, 25 Mar 2020 18:42:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51997) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jHEio-0005Q1-3t for guix-patches@gnu.org; Wed, 25 Mar 2020 18:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jHEin-0002cB-VY for guix-patches@gnu.org; Wed, 25 Mar 2020 18:42:01 -0400 Subject: [bug#40227] [PATCH] gnu: icu4c: Fix CVE-2020-10531. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20200325215427.GA29579@jasmine.lan> References: <87v9msyyii.fsf@devup.no> <20200325215427.GA29579@jasmine.lan> Date: Wed, 25 Mar 2020 23:41:05 +0100 Message-ID: <87sghwys5a.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 40227-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Wed, Mar 25, 2020 at 09:23:33PM +0100, Marius Bakke wrote: >> I'm not sure if the new test case as well as this git commit header is >> necessary. IMO it mostly adds noise to the patch. I.e. the whole file >> could be shortened to 6 lines + your comments at the top. >>=20 >> But no strong opinion, there is an argument to be made for preserving >> upstream commits in their entirety too (I think). >>=20 >> So, LGTM either way. Thank you! > > I commented out the changes to the test suite and pushed as > 7d57a190f6896c04b5dad66bf4360bc48a4052ff. What I meant was that they could be omitted entirely to shorten the patch (less lines to comb through for reviewers), but no worries! The important thing is that we get the security fix, thanks for watching out for those as always. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl573gEACgkQoqBt8qM6 VPpXOwgAj2bxdvLOQx97jTNhT6yxPORYcpCHGX6XOW3FRuYWiCT2cCgMJ76IGTjI JsbhdkHD04WAVKoUYcUOXVIS3q3xP+OdfOqrm/NNlyKVI7CoW2/+QMPfITecOt7w VeQjd98Z5d+6Q7a3Z0veY4KFGx+KCEcGEAvrQSzOC3d0ex7lyKllU1hrZN5Row4z PNJ8WwqpbCEF+zUddxTvQa63wYMR70aTpvV6+CbEW9WZuuxNmwLHNEgyf5exZgxa r0JQ3eQ+aWYHq7tRtJY18CI3eTYmzBG7sAGi9HaM4z459FJaefcXXSGvDJQ8vpdf 6mLnLBfTZlqcHXel1Oz/5IoEr8JbTQ== =aRlZ -----END PGP SIGNATURE----- --=-=-=--