From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:33130)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jJkpF-0001OI-OT
 for guix-patches@gnu.org; Wed, 01 Apr 2020 17:23:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jJkpC-0004PM-NO
 for guix-patches@gnu.org; Wed, 01 Apr 2020 17:23:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:55469)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jJkpB-0004Om-P4
 for guix-patches@gnu.org; Wed, 01 Apr 2020 17:23:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jJkpB-0003V6-Jq
 for guix-patches@gnu.org; Wed, 01 Apr 2020 17:23:01 -0400
Subject: [bug#40246] [PATCH] gnu: Add cramfs-tools.
Resent-Message-ID: <handler.40246.B40246.158577617713435@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <CAEwRq=r09qqcCfgC=CpMJZ4g3JztS8SkDieSHMPpMjpOH39QyA@mail.gmail.com>
Date: Wed, 01 Apr 2020 23:22:46 +0200
In-Reply-To: <CAEwRq=r09qqcCfgC=CpMJZ4g3JztS8SkDieSHMPpMjpOH39QyA@mail.gmail.com>
 (Vincent Legoll's message of "Thu, 26 Mar 2020 23:34:03 +0100")
Message-ID: <87sghmsxy1.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: 40246@debbugs.gnu.org

Hi Vincent,

Vincent Legoll <vincent.legoll@gmail.com> skribis:

> From ff79a4b2d798bba222ac502a7aa1f7ef0a97e249 Mon Sep 17 00:00:00 2001
> From: Vincent Legoll <vincent.legoll@gmail.com>
> Date: Thu, 26 Mar 2020 23:12:53 +0100
> Subject: [PATCH] gnu: Add cramfs-tools.
>
> * gnu/packages/linux.scm (cramfs-tools): New variable.

[...]

> +    (name "cramfs-tools")
> +    (version "2.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/npitre/cramfs-tools/archive/v"

As reported by =E2=80=98guix lint=E2=80=99, please don=E2=80=99t refer to a=
 generated tarball.

Instead you can use a hosted =E2=80=9Chand-crafted=E2=80=9D tarball if ther=
e=E2=80=99s one or,
more likely, =E2=80=98git-fetch=E2=80=99.

> +    (synopsis "Tools to manage Cramfs filesystems")
> +    (description "Cramfs is a Linux filesystem designed to be simple, sm=
all,
> +and to compress things well.  It is used on a number of embedded systems=
 and
> +small devices.  This version has additional features such as uncompressed
> +blocks and random block placement.")

Could you write =E2=80=9Cfile systems=E2=80=9D (two words)?  This is by con=
vention in
GNU and Guix.

Thanks in advance!

Ludo=E2=80=99.