From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qOLyHVKBrV7zUgAA0tVLHw (envelope-from ) for ; Sat, 02 May 2020 14:18:58 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 2FAUMVyBrV5caAAAbx9fmQ (envelope-from ) for ; Sat, 02 May 2020 14:19:08 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E6D4D942D0A for ; Sat, 2 May 2020 14:19:06 +0000 (UTC) Received: from localhost ([::1]:51986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUsyx-00008d-6f for larch@yhetil.org; Sat, 02 May 2020 10:19:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUsyt-00008M-2a for guix-patches@gnu.org; Sat, 02 May 2020 10:19:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUsys-0002yx-AI for guix-patches@gnu.org; Sat, 02 May 2020 10:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUsyr-0002y2-Tk for guix-patches@gnu.org; Sat, 02 May 2020 10:19:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jUsyr-0000AA-P3 for guix-patches@gnu.org; Sat, 02 May 2020 10:19:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40931] [PATCH v2] gnu: add j4-dmenu-desktop Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 May 2020 14:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40931 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alex McGrath , 40931@debbugs.gnu.org Cc: Alex McGrath Received: via spool by 40931-submit@debbugs.gnu.org id=B40931.1588429108586 (code B ref 40931); Sat, 02 May 2020 14:19:01 +0000 Received: (at 40931) by debbugs.gnu.org; 2 May 2020 14:18:28 +0000 Received: from localhost ([127.0.0.1]:53565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUsyK-00009O-CM for submit@debbugs.gnu.org; Sat, 02 May 2020 10:18:28 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:55529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUsyI-00009B-2B for 40931@debbugs.gnu.org; Sat, 02 May 2020 10:18:26 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 2E7AD2BA; Sat, 2 May 2020 10:18:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 02 May 2020 10:18:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=QPxaukRvVQjrOtOh3dQT3129JX H4FCkk2CwT5BziZ58=; b=kkMYDhN936zXXMaMzMazpst4ObyT701hS1h0njoZPq 4+e3djnrNKAqZFfNFLqXhA8Z7ZOzZo7KY1GcqVy4PWB2kQE+Uinc73LurI1eypg8 /+eGBGGOjbK+HywJ+9DOZHFEc3xb8U6OhMPmAeQVM7L0MFCC3byng0gew38G90LI fsfqBZNzq8UDGog6XhETwtK6seaa/s1Q8ijebnoRXTNRBy6xz8t1Ag1YqXhbPJKE /EcFg/NrRXerum2YbciBzRgr8cag0i0ITpBsku5gJt2wqioeWc4QADh2TRKQYyMz Hcy9ixkevlOKJocLKUCOtqSiMm++mWPbp8sQN8A83sgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QPxauk RvVQjrOtOh3dQT3129JXH4FCkk2CwT5BziZ58=; b=dVMkofEYIOPYjCoM2CORqY Ra7GgrzEjofT19FnUdxVbKLxaEHyiznuNfcQT84pgSTFBCBwL9Ghn3W9oguaQ5Sd HIhE3JnxyphOhG9hhD/ICge2o0Mo7PWJfDhmxg/oPzl1rAqwWPVl/FHIO6kZYUEb jdU1GU6WgemJpMjtbcwj5ZDfZeFJEBqVH3/0pTcP8RQSSneQ7rYETPOdlrpLJGws 9A7avtla7PjW976sICBP3pCmB+7h/007ffZApHQF0K5hPgjBvwrNP0HZtLXBHPxH ufio+0/VTejFvnd27kZnwNy2RxHUfUSS1YfV2oVLeJ9F6u8ypLGQE8+dhum1qqDQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieelgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtderre dtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucggtffrrghtthgvrhhnpeejkeefkeelgeevjeetheeljeeute duueelvdffvedufeevtddvfeevieefheevtdenucffohhmrghinhepghhithhhuhgsrdgt ohhmnecukfhppeekgedrvddtvddrieekrdejheenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 26C193065F95; Sat, 2 May 2020 10:18:19 -0400 (EDT) From: Marius Bakke In-Reply-To: <20200429075231.6699-1-amk@amk.ie> References: <20200428103705.22597-1-amk@amk.ie> <20200429075231.6699-1-amk@amk.ie> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sat, 02 May 2020 16:18:17 +0200 Message-ID: <87sggi2zfa.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -2.01 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=fastmail.com header.s=fm2 header.b=kkMYDhN9; dkim=fail (rsa verify failed) header.d=messagingengine.com header.s=fm2 header.b=dVMkofEY; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fastmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-2.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49502614834458]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; R_DKIM_REJECT(1.00)[fastmail.com:s=fm2,messagingengine.com:s=fm2]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; FREEMAIL_FROM(0.00)[fastmail.com]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.15), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; DKIM_TRACE(0.00)[fastmail.com:-,messagingengine.com:-]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[mbakke@fastmail.com,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[amk.ie:email]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_SEVEN(0.00)[11]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[fastmail.com : SPF not aligned (relaxed),none] X-TUID: jT+jnPNV9yl0 --=-=-= Content-Type: text/plain Alex McGrath writes: > * gnu/packages/xdisorg.scm (j4-dmenu-desktop): New variable. Thanks! Unfortunately the patch no longer applies, can you rebase it on the current master branch? [...] > +(define-public j4-dmenu-desktop > + (package > + (name "j4-dmenu-desktop") > + (version "2.17") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/enkore/j4-dmenu-desktop.git") > + (commit (string-append "r" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc")))) > + (build-system cmake-build-system) > + (arguments > + `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release" "-DWITH_GIT_CACHE=off" "-DWITH_TESTS=off") Note that cmake-build-system exposes #:build-type, so you don't have to pass "-DCMAKE_BUILD_TYPE". By default it uses RelWithDebugInfo which is better because it adds debug information. There are cases where we want "Release" instead (size or performance concerns), but it probably is fine for this package? > + #:tests? #f)) ;; tests fetch an external git repo Is it possible to provide this repo as a native-input? See e.g. 'ghc'. Don't stress it if it's not possible, though. > + (synopsis "A fast desktop menu") Just "Fast desktop menu" ('./pre-inst-env guix lint j4-dmenu-desktop' should warn about this). > + (description "j4-dmenu-desktop is a replacement for i3-dmenu-desktop. It's purpose is to find desktop files and offer you a menu to start an application using dmenu.") Use two spaces between sentences, and try to wrap lines at ~78 characters. 'guix lint' will warn about this, too. :-) Can you send an updated patch? Thanks in advance! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6tgSkACgkQoqBt8qM6 VPpBgggAp7f7NzWe1/tIFRiLeFIVJ+VwCcRrLmG0SznWxM9JeoZhou7XmrN6kyC4 5A8vIgPMDugHH2tuBUW+qLkhC8XCUpE0B519LYCg3t7cZpFWvN7daA5Kngt/7+2+ l8eg7H1ILi9ssqpgk/v9xEUpu4zBVhXg7g81stBnN/rNMB97f9SVeYn/uszPt8Bx cCHUQ/qRKIeow/kjB+AcshyXA0n8cEGh+bsamWxujjyem6QhdVuoMNB1P4oyGYlM +WwEsGh+bScJF+q8MoV+DfmDEU4L+NBsXRi1qRlvqFbuRtL6hDqXS/g3I/joGAPG YAvDQ3r1YN42qXsswUenPORkvwlnpQ== =MOIQ -----END PGP SIGNATURE----- --=-=-=--