unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Brett Gilio <brettg@gnu.org>
To: andremegafone@gmail.com (André Alexandre Gomes)
Cc: 42586@debbugs.gnu.org
Subject: [bug#42586] [PATCH] emacs-google-translate
Date: Thu, 06 Aug 2020 22:45:03 -0500	[thread overview]
Message-ID: <87sgczi0g0.fsf@gnu.org> (raw)
In-Reply-To: <87mu3jd5jp.fsf@gmail.com> ("André Alexandre Gomes"'s message of "Tue, 28 Jul 2020 16:26:34 +0100")

andremegafone@gmail.com (André Alexandre Gomes) writes:

> I missed the attachment in the last message, sorry!
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 8618a07a21..36f8d27743 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -78,6 +78,7 @@
>  ;;; Copyright © 2020 Eric Bavier <bavier@posteo.net>
>  ;;; Copyright © 2020 Morgan Smith <Morgan.J.Smith@outlook.com>
>  ;;; Copyright © 2020 Peng Mei Yu <i@pengmeiyu.com>
> +;;; Copyright © 2020 André A. Gomes <andremegafone@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -16975,7 +16976,7 @@ the GIF result.")
>  (define-public emacs-google-translate
>    (package
>      (name "emacs-google-translate")
> -    (version "0.11.18")
> +    (version "0.12.0")
>      (source
>       (origin
>         (method git-fetch)

Hello Andre,

Thank you for your contribution. There are a few problems we need to
address before continuing. I will try to explain:

1. Each package comes with a checksum hash that needs to match to verify
the authenticity of the originating source. You modified the version,
but did not update that hash. This has can be obtained directly through
git or by running our build system on your change and letting the build
fail and it'll output the correct hash. On that note, please make sure
you are checking your changes by running the build system against them,
it would have caught this discrepency.

2. Your submission appears to be a git diff, we use git formatted
patches emailed through git send-mail to share and apply patches in our
work tree. Will you please resend your change (with the revised checksum
hash) using git format-patch and git send-mail? When doing so, please
take care to review our commit message protocol. These can be reviewed
from our contributing page.

If you need further explanations, or can not find the links to the
information I am referencing, let me know!

Thanks,
Brett Gilio




  parent reply	other threads:[~2020-08-07  3:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 15:26 [bug#42586] [PATCH] emacs-google-translate André Alexandre Gomes
2020-07-28 16:36 ` [bug#42586] Update André Alexandre Gomes
2020-08-07  3:45 ` Brett Gilio [this message]
2020-08-07  4:03   ` bug#42586: [PATCH] emacs-google-translate Brett Gilio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgczi0g0.fsf@gnu.org \
    --to=brettg@gnu.org \
    --cc=42586@debbugs.gnu.org \
    --cc=andremegafone@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).