unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mike Rosset <mike.rosset@gmail.com>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 43182@debbugs.gnu.org
Subject: [bug#43182] [PATCH 3/3] gnu: nomad: Update to 0.2.0-alpha-100-g6a565d3.
Date: Sun, 06 Sep 2020 23:55:47 -0700	[thread overview]
Message-ID: <87sgbugjnw.fsf@gmail.com> (raw)
In-Reply-To: <874koanmlg.fsf@gnu.org>


Mathieu Othacehe <othacehe@gnu.org> writes:

> Hello Mike,
>
> I pushed the two first ones, thanks.
>
>> * gnu/packages/guile-xyz.scm (nomad): Update to 0.2.0-alpha-100-g6a565d3.
>
> For this one, you need to describe every change exhaustively, according
> to the commit message convention. For instance:
>
> [native-inputs]: Add "gettext".
> [propagated-inputs]: Move "glib-networking" to ....
> [inputs]: ... here.
>
> and so on.

I'll reword this commit message.

>> +                 `("GI_TYPELIB_PATH" ":" prefix (,gi-path ,(getenv "GI_TYPELIB_PATH")))
>> +                 `("GIO_EXTRA_MODULES" ":" prefix (,(getenv "GIO_EXTRA_MODULES")))
>
> You can wrap a few lines here to stay under the 78 columns limit.
>
>> +                 `("GST_PLUGIN_SYSTEM_PATH" ":" prefix ,gst-plugins)
>> +                 `("NOMAD_WEB_EXTENSION_DIR" ":" prefix (,ext-path)))
>
> If NOMAD_WEB_EXTENSION_DIR is wrapped, it is up to the user to set
> it. Don't we want to keep it as a native-search-paths so that any
> extension package to nomad is automatically added to this variable?
>

No, web extension is a GTK term for extending the WebKit process
which runs outside of the GTK/Glib process.

The extensions are dynamic libraries and you need to tell the
WebKitWebContext where to look for them. Normally I'd just substitute
in the $(libexecdir).  But we need to use the libs in the build directory for
testing.  And I can't use libtool --mode=execute -dlopen. Because the
WebKit process does the dlopen.

We don't actually do much with the WebProcess right now.  But later it's
a pathway to DOM introspection using scheme... at least in theory.

So it's easier to just set NOMAD_WEB_EXTENSION_DIR in pre-inst-env.  For
end users setting NOMAD_WEB_EXTENSION_DIR explicitly in a wrap will have
no impact. Since nomad extensions are done in scheme and use the normal
search path mechanisms for guile.

Mike




  reply	other threads:[~2020-09-07  6:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 13:47 [bug#43182] [PATCH] gnu: nomad: Update to 0.2.0-alpha-100-g6a565d3 Mike Rosset
2020-09-03 14:42 ` Mike Rosset
2020-09-03 14:48   ` Mike Rosset
2020-09-04  6:17     ` Mathieu Othacehe
2020-09-04 14:40 ` [bug#43182] [PATCH 1/3] gnu: emacsy-minimal: Update to v0.4.1-31-g415d96f Mike Rosset
2020-09-04 14:40   ` [bug#43182] [PATCH 2/3] gnu: g-golf: Update to git hash 84e894e Mike Rosset
2020-09-04 14:40   ` [bug#43182] [PATCH 3/3] gnu: nomad: Update to 0.2.0-alpha-100-g6a565d3 Mike Rosset
2020-09-07  6:10     ` Mathieu Othacehe
2020-09-07  6:55       ` Mike Rosset [this message]
2020-09-07 11:02         ` Ricardo Wurmus
2020-09-07 16:24           ` Mike Rosset
2020-09-07  7:58       ` Mike Rosset
2020-09-07  7:53 ` [bug#43182] [PATCH] " Mike Rosset
2020-09-07  8:58   ` bug#43182: " Mathieu Othacehe
2020-09-07  9:27     ` [bug#43182] " Mike Rosset

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgbugjnw.fsf@gmail.com \
    --to=mike.rosset@gmail.com \
    --cc=43182@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).