From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qLclL8I/WV/WCgAA0tVLHw (envelope-from ) for ; Wed, 09 Sep 2020 20:49:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4DkLK8I/WV/iJwAAB5/wlQ (envelope-from ) for ; Wed, 09 Sep 2020 20:49:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 33625940224 for ; Wed, 9 Sep 2020 20:49:06 +0000 (UTC) Received: from localhost ([::1]:37160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kG71d-00036J-29 for larch@yhetil.org; Wed, 09 Sep 2020 16:49:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kG71a-00036C-CZ for guix-patches@gnu.org; Wed, 09 Sep 2020 16:49:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kG71a-0007PI-3j for guix-patches@gnu.org; Wed, 09 Sep 2020 16:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kG71a-0007zW-2T for guix-patches@gnu.org; Wed, 09 Sep 2020 16:49:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41143] [PATCH 2/2] mapped-devices: Add 'lvm-device-mapping' Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Sep 2020 20:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41143 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: tsmish Cc: 41143@debbugs.gnu.org Received: via spool by 41143-submit@debbugs.gnu.org id=B41143.159968451930686 (code B ref 41143); Wed, 09 Sep 2020 20:49:02 +0000 Received: (at 41143) by debbugs.gnu.org; 9 Sep 2020 20:48:39 +0000 Received: from localhost ([127.0.0.1]:34900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG71D-0007ys-2P for submit@debbugs.gnu.org; Wed, 09 Sep 2020 16:48:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG71A-0007yg-RM for 41143@debbugs.gnu.org; Wed, 09 Sep 2020 16:48:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43739) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kG714-0007Ld-3E; Wed, 09 Sep 2020 16:48:30 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=55678 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kG712-0001Gb-LU; Wed, 09 Sep 2020 16:48:29 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Wed, 09 Sep 2020 22:48:22 +0200 In-Reply-To: (tsmish's message of "Sat, 9 May 2020 01:22:07 +0000") Message-ID: <87sgbqllrd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: NLzHCrcfSmAZ tsmish skribis: > "vgscan --mknodes" is a bit of a hack. Everyone else relies on udev to > create files in /dev/mapper, but since initrd doesn't have working > udevd, they need to be created this way. Oh, I guess that=E2=80=99s fine. Could you place this as a comment above t= he =E2=80=9Cvgscan=E2=80=9D invocation? > Also, while this code is able to boot from root on LVM, grub in > current configuration can't find required files, This can be fixed by > placing (format port "insmod lvm") in grub configuration builder, but > this is somewhat hacky. Uh, future work. :-) > +(define (open-lvm-device source target) > + #~(begin > + (use-modules > + (srfi srfi-1) > + (srfi srfi-26)) Since this gets spliced into the initrd expression (not at the top level), we cannot have =E2=80=98use-modules=E2=80=99 here (well, it may not= work as expected, as you found out with srfi-26 macros). I=E2=80=99d suggest adding (srfi srfi-1) to the =E2=80=98use-modules=E2=80= =99 form in =E2=80=98raw-initrd=E2=80=99, in (gnu system linux-initrd), so you can rely= on it (srfi-26 is already there). It would be great to have a system test for LVM support. We have tests for Btrfs, RAID with mdadm, etc., but these are system installation tests in (gnu tests install). Do you think we could have either an installation test or maybe a less expensive test for LVM? Thanks for your work! Ludo=E2=80=99.