From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IMgnBLtxZF8SaQAA0tVLHw (envelope-from ) for ; Fri, 18 Sep 2020 08:37:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CCmEO7pxZF98VwAAbx9fmQ (envelope-from ) for ; Fri, 18 Sep 2020 08:37:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5909D9404D2 for ; Fri, 18 Sep 2020 08:37:14 +0000 (UTC) Received: from localhost ([::1]:57468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJBtI-0006oi-Rc for larch@yhetil.org; Fri, 18 Sep 2020 04:37:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJBoI-0002j2-J6 for guix-patches@gnu.org; Fri, 18 Sep 2020 04:32:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57470) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJBoI-0006GV-8H for guix-patches@gnu.org; Fri, 18 Sep 2020 04:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJBoI-0000pa-4w for guix-patches@gnu.org; Fri, 18 Sep 2020 04:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42338] [PATCH 01/34] guix: import: Add composer importer. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Sep 2020 08:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42338 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 42338@debbugs.gnu.org Received: via spool by 42338-submit@debbugs.gnu.org id=B42338.16004179102592 (code B ref 42338); Fri, 18 Sep 2020 08:32:02 +0000 Received: (at 42338) by debbugs.gnu.org; 18 Sep 2020 08:31:50 +0000 Received: from localhost ([127.0.0.1]:40775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJBo6-0000fV-5d for submit@debbugs.gnu.org; Fri, 18 Sep 2020 04:31:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJBo3-0000Z2-Mh for 42338@debbugs.gnu.org; Fri, 18 Sep 2020 04:31:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58699) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJBnx-0006Az-CC; Fri, 18 Sep 2020 04:31:41 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41992 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kJBnw-00060I-OT; Fri, 18 Sep 2020 04:31:41 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200713002055.1553f136@tachikoma.lepiller.eu> <20200712222538.18092-1-julien@lepiller.eu> <87mu21heay.fsf@gnu.org> <20200918004333.127aa5da@tachikoma.lepiller.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Jour du Travail de =?UTF-8?Q?l'Ann=C3=A9e?= 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 18 Sep 2020 10:31:39 +0200 In-Reply-To: <20200918004333.127aa5da@tachikoma.lepiller.eu> (Julien Lepiller's message of "Fri, 18 Sep 2020 00:43:33 +0200") Message-ID: <87sgbf1o5w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: KJaUilKDXDWl Hi! Julien Lepiller skribis: > From 6d521ca9f066f82488abefd5d3630e38305c0fd1 Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Tue, 29 Oct 2019 08:07:38 +0100 > Subject: [PATCH 01/34] guix: import: Add composer importer. > > * guix/import/composer.scm: New file. > * guix/scripts/import/composer.scm: New file. > * guix/tests/composer.scm: New file. > * Makefile.am: Add them. > * guix/scripts/import.scm: Add composer importer. > * doc/guix.texi (Invoking guix import): Mention it. [...] > +@item composer > +@cindex COMPOSER s/COMPOSER/Composer/ ? > +Import metadat from the @uref{https://getcomposer.org/, Composer} package ^ metadata > +archive used by the PHP community. Could you add an example command line like we have for some of the other importers? (It=E2=80=99s also useful for us as a test against the actual s= ervers=E2=80=A6) > + (let ((package (json-fetch > + (string-append (%composer-base-url) "/p/" name ".json= ")))) > + (if package > + (let* ((packages (assoc-ref package "packages")) > + (package (assoc-ref packages name)) > + (versions (filter > + (lambda (version) > + (and (not (string-contains version "dev")) > + (not (string-contains version "beta"))= )) > + (map car package))) Like I wrote before, I recommend =E2=80=98define-json-mapping=E2=80=99. If= you prefer you can make that change later on once you=E2=80=99ve pushed this first ver= sion, but I really think it=E2=80=99ll help maintainability. This should also help avoid (map car =E2=80=A6), which is frowned upon in G= uix. :-) > + (versions (map > + (lambda (version) Rather indent as: (map (lambda (version) Otherwise LGTM!=20=20 Ludo=E2=80=99.