From: "Ludovic Courtès" <ludo@gnu.org>
To: bavier@posteo.net
Cc: 43616@debbugs.gnu.org, Eric Bavier <bavier@member.fsf.org>
Subject: [bug#43616] [PATCH] tests: Simplify shell exit status negation;
Date: Sat, 26 Sep 2020 23:12:32 +0200 [thread overview]
Message-ID: <87sgb4fdj3.fsf@gnu.org> (raw)
In-Reply-To: <20200925180004.26836-1-bavier@posteo.net> (bavier@posteo.net's message of "Fri, 25 Sep 2020 13:00:04 -0500")
Hi Eric,
bavier@posteo.net skribis:
> From: Eric Bavier <bavier@member.fsf.org>
>
> * tests/guix-archive.sh, tests/guix-build-branch.sh, tests/guix-build.sh,
> tests/guix-daemon.sh, tests/guix-download.sh, tests/guix-environment.sh,
> tests/guix-gc.sh, tests/guix-git-authenticate.sh, tests/guix-graph.sh,
> tests/guix-hash.sh, tests/guix-lint.sh, tests/guix-pack-relocatable.sh,
> tests/guix-pack.sh, tests/guix-package-aliases.sh, tests/guix-package-net.sh,
> tests/guix-package.sh: Use the shell '!' keyword to negate command exit status
> in place of 'if ...; then false; else true; fi'
[...]
> -if guix archive something-that-does-not-exist
> -then false; else true; fi
> +! guix archive something-that-does-not-exist
I have a vague recollection that I came to the conclusion that the ‘if’
was needed, but now I don’t see why.
If you’re confident please go ahead! It’s never too late for me to
improve my shell knowledge. :-)
Ludo’.
next prev parent reply other threads:[~2020-09-26 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 18:00 [bug#43616] [PATCH] tests: Simplify shell exit status negation; bavier
2020-09-26 21:12 ` Ludovic Courtès [this message]
2020-09-29 2:23 ` bug#43616: " Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgb4fdj3.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43616@debbugs.gnu.org \
--cc=bavier@member.fsf.org \
--cc=bavier@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).