* [bug#44019] add dbus-cxx
@ 2020-10-15 17:19 tiregram arthur
2020-10-19 14:32 ` Miguel Ángel Arruga Vivas
0 siblings, 1 reply; 7+ messages in thread
From: tiregram arthur @ 2020-10-15 17:19 UTC (permalink / raw)
To: 44019
From c3804aca21c496e66e44ba48fd150501154dfb6d Mon Sep 17 00:00:00 2001
From: ruhtra <ruhtra.mar@gmail.com>
Date: Thu, 15 Oct 2020 18:58:46 +0200
Subject: [PATCH] to add dbus-cxx package add gnu/packages/dbus-cxx.scm
---
gnu/packages/dbus-cxx.scm | 52 +++++++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
create mode 100644 gnu/packages/dbus-cxx.scm
diff --git a/gnu/packages/dbus-cxx.scm b/gnu/packages/dbus-cxx.scm
new file mode 100644
index 0000000000..4ec08fb4ac
--- /dev/null
+++ b/gnu/packages/dbus-cxx.scm
@@ -0,0 +1,52 @@
+;;; Copyright © 2020 Arthur Margerit <ruhtra.mar@gmail.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages dbus-cxx)
+ #:use-module (guix packages)
+ #:use-module (guix git-download)
+ #:use-module (guix build-system cmake)
+ #:use-module (guix licenses)
+ #:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages m4)
+ #:use-module ((gnu packages glib) #:select (dbus libsigc++)))
+
+(define-public dbus-cxx
+ (package
+ (name "dbus-cxx")
+ (version "0.12.0")
+ (source (origin
+ (file-name (git-file-name name version))
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/dbus-cxx/dbus-cxx")
+ (commit "ea7f8e361d11dc7d41d9ae2c4128aed2cdadd84e")))
+ (sha256
+ (base32
+ "1sa448icfvl08rnik0lnk4scmkwhfyd3mrxh36jh8x7xndp90khp"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:tests? #f))
+ (inputs `(("dbus-glib", dbus) ("libsigc++", libsigc++)))
+ (native-inputs `(("pkg-config", pkg-config) ("m4", m4)))
+ (synopsis "C++ wrapper for dbus")
+ (description "Dbus-cxx is a C++ wrapper for dbus.
+It exposes the C API to allow direct manipulation and
+relies on sigc++ to provide an OO interface.
+Also included is dbus-cxx-xml2cpp to generate proxy and adapter
+ interfaces from DBus XML introspection-like documents.")
+ (home-page "https://dbus-cxx.github.io/")
+ (license gpl3)))
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#44019] add dbus-cxx
2020-10-15 17:19 [bug#44019] add dbus-cxx tiregram arthur
@ 2020-10-19 14:32 ` Miguel Ángel Arruga Vivas
2020-10-19 16:04 ` tiregram arthur
0 siblings, 1 reply; 7+ messages in thread
From: Miguel Ángel Arruga Vivas @ 2020-10-19 14:32 UTC (permalink / raw)
To: tiregram arthur; +Cc: 44019
Hi Arthur,
Thank you very much for your patch. Nonetheless, there is already a
package named dbus-c++ and that can be found in gnu/packages/glib.scm
and the description fits almost exactly this one, but it's being used
currently only by libring (Jami). Even if they are different projects
(dbus-c++ and dbus-cxx), they should belong together in the source code
(gnu/packages/glib.scm).
Could you confirm that they are different code bases, and also move that
definition there for the patch if that's the case?
Happy hacking!
Miguel
tiregram arthur <ruhtra.mar@gmail.com> writes:
>>From c3804aca21c496e66e44ba48fd150501154dfb6d Mon Sep 17 00:00:00 2001
> From: ruhtra <ruhtra.mar@gmail.com>
> Date: Thu, 15 Oct 2020 18:58:46 +0200
> Subject: [PATCH] to add dbus-cxx package add gnu/packages/dbus-cxx.scm
>
> ---
> gnu/packages/dbus-cxx.scm | 52 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
> create mode 100644 gnu/packages/dbus-cxx.scm
>
> diff --git a/gnu/packages/dbus-cxx.scm b/gnu/packages/dbus-cxx.scm
> new file mode 100644
> index 0000000000..4ec08fb4ac
> --- /dev/null
> +++ b/gnu/packages/dbus-cxx.scm
> @@ -0,0 +1,52 @@
> +;;; Copyright © 2020 Arthur Margerit <ruhtra.mar@gmail.com>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages dbus-cxx)
> + #:use-module (guix packages)
> + #:use-module (guix git-download)
> + #:use-module (guix build-system cmake)
> + #:use-module (guix licenses)
> + #:use-module (gnu packages pkg-config)
> + #:use-module (gnu packages m4)
> + #:use-module ((gnu packages glib) #:select (dbus libsigc++)))
> +
> +(define-public dbus-cxx
> + (package
> + (name "dbus-cxx")
> + (version "0.12.0")
> + (source (origin
> + (file-name (git-file-name name version))
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/dbus-cxx/dbus-cxx")
> + (commit "ea7f8e361d11dc7d41d9ae2c4128aed2cdadd84e")))
> + (sha256
> + (base32
> + "1sa448icfvl08rnik0lnk4scmkwhfyd3mrxh36jh8x7xndp90khp"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:tests? #f))
> + (inputs `(("dbus-glib", dbus) ("libsigc++", libsigc++)))
> + (native-inputs `(("pkg-config", pkg-config) ("m4", m4)))
> + (synopsis "C++ wrapper for dbus")
> + (description "Dbus-cxx is a C++ wrapper for dbus.
> +It exposes the C API to allow direct manipulation and
> +relies on sigc++ to provide an OO interface.
> +Also included is dbus-cxx-xml2cpp to generate proxy and adapter
> + interfaces from DBus XML introspection-like documents.")
> + (home-page "https://dbus-cxx.github.io/")
> + (license gpl3)))
> --
> 2.28.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#44019] add dbus-cxx
2020-10-19 14:32 ` Miguel Ángel Arruga Vivas
@ 2020-10-19 16:04 ` tiregram arthur
2020-10-19 17:24 ` Miguel Ángel Arruga Vivas
0 siblings, 1 reply; 7+ messages in thread
From: tiregram arthur @ 2020-10-19 16:04 UTC (permalink / raw)
To: Miguel Ángel Arruga Vivas; +Cc: 44019
[-- Attachment #1: Type: text/plain, Size: 4064 bytes --]
Hi, thanks for the answer
https://www.freedesktop.org/wiki/Software/DBusBindings/
As you can, read in the cpp binding section they are many dbus binding.
And they are différents code base.
I will move the définition to glib.scm.
Le lun. 19 oct. 2020 à 16:33, Miguel Ángel Arruga Vivas <
rosen644835@gmail.com> a écrit :
> Hi Arthur,
>
> Thank you very much for your patch. Nonetheless, there is already a
> package named dbus-c++ and that can be found in gnu/packages/glib.scm
> and the description fits almost exactly this one, but it's being used
> currently only by libring (Jami). Even if they are different projects
> (dbus-c++ and dbus-cxx), they should belong together in the source code
> (gnu/packages/glib.scm).
>
> Could you confirm that they are different code bases, and also move that
> definition there for the patch if that's the case?
>
> Happy hacking!
> Miguel
>
> tiregram arthur <ruhtra.mar@gmail.com> writes:
>
> >>From c3804aca21c496e66e44ba48fd150501154dfb6d Mon Sep 17 00:00:00 2001
> > From: ruhtra <ruhtra.mar@gmail.com>
> > Date: Thu, 15 Oct 2020 18:58:46 +0200
> > Subject: [PATCH] to add dbus-cxx package add gnu/packages/dbus-cxx.scm
> >
> > ---
> > gnu/packages/dbus-cxx.scm | 52 +++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 52 insertions(+)
> > create mode 100644 gnu/packages/dbus-cxx.scm
> >
> > diff --git a/gnu/packages/dbus-cxx.scm b/gnu/packages/dbus-cxx.scm
> > new file mode 100644
> > index 0000000000..4ec08fb4ac
> > --- /dev/null
> > +++ b/gnu/packages/dbus-cxx.scm
> > @@ -0,0 +1,52 @@
> > +;;; Copyright © 2020 Arthur Margerit <ruhtra.mar@gmail.com>
> > +;;;
> > +;;; This file is part of GNU Guix.
> > +;;;
> > +;;; GNU Guix is free software; you can redistribute it and/or modify it
> > +;;; under the terms of the GNU General Public License as published by
> > +;;; the Free Software Foundation; either version 3 of the License, or
> (at
> > +;;; your option) any later version.
> > +;;;
> > +;;; GNU Guix is distributed in the hope that it will be useful, but
> > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > +;;; GNU General Public License for more details.
> > +;;;
> > +;;; You should have received a copy of the GNU General Public License
> > +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> > +
> > +(define-module (gnu packages dbus-cxx)
> > + #:use-module (guix packages)
> > + #:use-module (guix git-download)
> > + #:use-module (guix build-system cmake)
> > + #:use-module (guix licenses)
> > + #:use-module (gnu packages pkg-config)
> > + #:use-module (gnu packages m4)
> > + #:use-module ((gnu packages glib) #:select (dbus libsigc++)))
> > +
> > +(define-public dbus-cxx
> > + (package
> > + (name "dbus-cxx")
> > + (version "0.12.0")
> > + (source (origin
> > + (file-name (git-file-name name version))
> > + (method git-fetch)
> > + (uri (git-reference
> > + (url "https://github.com/dbus-cxx/dbus-cxx")
> > + (commit
> "ea7f8e361d11dc7d41d9ae2c4128aed2cdadd84e")))
> > + (sha256
> > + (base32
> > +
> "1sa448icfvl08rnik0lnk4scmkwhfyd3mrxh36jh8x7xndp90khp"))))
> > + (build-system cmake-build-system)
> > + (arguments
> > + `(#:tests? #f))
> > + (inputs `(("dbus-glib", dbus) ("libsigc++", libsigc++)))
> > + (native-inputs `(("pkg-config", pkg-config) ("m4", m4)))
> > + (synopsis "C++ wrapper for dbus")
> > + (description "Dbus-cxx is a C++ wrapper for dbus.
> > +It exposes the C API to allow direct manipulation and
> > +relies on sigc++ to provide an OO interface.
> > +Also included is dbus-cxx-xml2cpp to generate proxy and adapter
> > + interfaces from DBus XML introspection-like documents.")
> > + (home-page "https://dbus-cxx.github.io/")
> > + (license gpl3)))
> > --
> > 2.28.0
>
[-- Attachment #2: Type: text/html, Size: 5752 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#44019] add dbus-cxx
2020-10-19 16:04 ` tiregram arthur
@ 2020-10-19 17:24 ` Miguel Ángel Arruga Vivas
[not found] ` <CAHBH9LAGDi2TiTayM41e5uL2DJjzivd_yvEafZacP=WP92062Q@mail.gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Miguel Ángel Arruga Vivas @ 2020-10-19 17:24 UTC (permalink / raw)
To: tiregram arthur; +Cc: 44019
Hi,
tiregram arthur <ruhtra.mar@gmail.com> writes:
> https://www.freedesktop.org/wiki/Software/DBusBindings/
> As you can, read in the cpp binding section they are many dbus binding.
> And they are différents code base.
Thank you very much for the info, I didn't look there.
> I will move the définition to glib.scm.
And thank you very much for your effort. :-)
Happy hacking!
Miguel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#44019] add dbus-cxx
[not found] ` <CAHBH9LAGDi2TiTayM41e5uL2DJjzivd_yvEafZacP=WP92062Q@mail.gmail.com>
@ 2020-10-22 16:26 ` Miguel Ángel Arruga Vivas
[not found] ` <CAHBH9LA_VWsJXXsGRCKa2UGrpLjgqWpNNmcP3_nR9zCsvg6hyw@mail.gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Miguel Ángel Arruga Vivas @ 2020-10-22 16:26 UTC (permalink / raw)
To: tiregram arthur; +Cc: 44019
Hi,
The list was lost at some point in this email, I add it again.
I've checked the code of the library and I'm almost sure it's a fork of
the (unmantained) dbus-c++ project, but I'm not sure about changing the
dependency for jami and its compatibility, so I think it's worth keeping
it as a separate package, at least for now.
Reading and testing your patch I've found several issues about it, all
of them have an easy solution. :-)
tiregram arthur <ruhtra.mar@gmail.com> writes:
> From 8664346cc76e728806c1a797fc59b47d66b603ef Mon Sep 17 00:00:00 2001
> From: ruhtra <ruhtra.mar@gmail.com>
> Date: Tue, 20 Oct 2020 18:52:37 +0200
> Subject: [PATCH] add dbus-cxx package
The commit message title should be with "gnu: Add dbus-cxx."
Also, changelog information is required in the body of the commit, e.g.:
* gnu/packages/glib.scm (dbux-cxx): New package.
> ---
> gnu/packages/glib.scm | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
> index cde95b13eb..c79060cf8b 100644
> --- a/gnu/packages/glib.scm
> +++ b/gnu/packages/glib.scm
> @@ -13,6 +13,7 @@
> ;;; Copyright © 2019 Giacomo Leidi <goodoldpaul@autistici.org>
> ;;; Copyright © 2019, 2020 Marius Bakke <mbakke@fastmail.com>
> ;;; Copyright © 2020 Nicolò Balzarotti <nicolo@nixo.xyz>
> +;;; Copyright © 2020 Arthur Margerit <ruhtra.mar@gmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -61,10 +62,12 @@
> #:use-module (gnu packages xml)
> #:use-module (gnu packages xorg)
> #:use-module (guix build-system gnu)
> + #:use-module (guix build-system cmake)
> #:use-module (guix build-system meson)
> #:use-module (guix build-system perl)
> #:use-module (guix build-system python)
> #:use-module (guix download)
> + #:use-module (guix git-download)
This shouldn't be needed, there is a tarball for the release on the
sourceforge page.
> #:use-module ((guix licenses) #:prefix license:)
> #:use-module (guix packages)
> #:use-module (guix utils)
> @@ -932,6 +935,35 @@ programming language. It also contains the utility
> (home-page "https://sourceforge.net/projects/dbus-cplusplus/")
> (license license:lgpl2.1+)))
>
> +
That extra line break should be removed.
> +(define-public dbus-cxx
> + (package
> + (name "dbus-cxx")
> + (version "0.12.0")
> + (source (origin
> + (file-name (git-file-name name version))
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/dbus-cxx/dbus-cxx")
> + (commit "ea7f8e361d11dc7d41d9ae2c4128aed2cdadd84e")))
Here it should point to the tarball from sourceforge (like the one for
dbus-c++):
"mirror://sourceforge/dbus-cxx/dbus-cxx/0.12.0/dbus-cxx-0.12.0.tar.gz"
> + (sha256
> + (base32
> + "1sa448icfvl08rnik0lnk4scmkwhfyd3mrxh36jh8x7xndp90khp"))))
The sha256 for the tarball would be
"1acsgpkd9v7b9jdc79ijmh9dbdfrzgkwkaff518i3zpk7y6g5mzw".
> + (build-system cmake-build-system)
> + (arguments
> + `(#:tests? #f))
We should run tests as much as possible as the software is going to be
distributed. For that, -DENABLE_TESTS=ON must be provided through
#:build-arguments, and #:tests? #f removed.
Also, the description doesn't match the options default options,
-DENABLE_TOOLS=ON has to be provided to generate dbus-cxx-xml2cpp and
dbus-cxx-introspection.
There is a third option that could be interesting, -DENABLE_GLIBMM=ON,
but I'm not sure what it really does, apart from generating extra
headers and libs.
> + (inputs `(("dbus-glib", dbus) ("libsigc++", libsigc++)))
The comma (,) there is reader syntax, so it applies to the right side,
not the left one: ,libsigc++ expands to the contents of the variable
libsigc++ inside the quasiquote (`). Also, they should be one on each
line, and I would change dbus-glib for dbus too. To build the tools you
need expat, already available, and popt from (gnu packages popt), like
this code:
(inputs `(("dbus" ,dbus)
("expat" ,expat)
("libsigc++" ,libsigc++)
("popt" ,popt)))
If the glibmm option worths it, it has to be added to that list too.
> + (native-inputs `(("pkg-config", pkg-config) ("m4", m4)))
Same indentation problems, one line per dependency, comma with the
variable, not on the left.
> + (synopsis "C++ wrapper for dbus")
> + (description "Dbus-cxx is a C++ wrapper for dbus.
> +It exposes the C API to allow direct manipulation and
> +relies on sigc++ to provide an OO interface.
> +Also included is dbus-cxx-xml2cpp to generate proxy and adapter
> + interfaces from DBus XML introspection-like documents.")
This has been directly copied from the web page. If you don't have any
idea on what to write, the dbus-c++ package description has better
formatting at least. :-)
> + (home-page "https://dbus-cxx.github.io/")
> + (license license:gpl3)))
> +
> +
There's an extra line here too.
The main two issues are the compilation options and the description.
Would you mind to send a new version of the patch with these fixes?
Happy hacking!
Miguel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#44019] add dbus-cxx
[not found] ` <CAHBH9LAjetjdp_HbnhTGBESopH2vomSMdaL9kZOFsnD-B0YdRg@mail.gmail.com>
@ 2020-10-23 14:28 ` Miguel Ángel Arruga Vivas
2020-10-24 1:02 ` bug#44019: " Miguel Ángel Arruga Vivas
0 siblings, 1 reply; 7+ messages in thread
From: Miguel Ángel Arruga Vivas @ 2020-10-23 14:28 UTC (permalink / raw)
To: tiregram arthur; +Cc: 44019
Hi,
tiregram arthur <ruhtra.mar@gmail.com> writes:
>> update.
>> i remove newline.
>> i move to tar
>> i add compilation option for test, tools and glibmm
>> i modified description
>> i indent the code as expected.
>>
>> you can find the new version atach to this email.
Thank you very much, this version looks superb! :-)
> I just get the warning about softwareheritage.
> Who is in charge of this part?
I still need an answer for this. As soon as I have it, I hope sooner
than later, I'll push this with the right origin, as you provided both
versions already.
Thank you again,
Miguel
---
From e3dcfc10dcd9fff1486b282b3d77309411c44ac9 Mon Sep 17 00:00:00 2001
From: ruhtra <ruhtra.mar@gmail.com>
Date: Fri, 23 Oct 2020 14:40:20 +0200
Subject: [PATCH] gnu: Add dbus-cxx.
---
gnu/packages/glib.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
index cde95b13eb..898b44a9e4 100644
--- a/gnu/packages/glib.scm
+++ b/gnu/packages/glib.scm
@@ -13,6 +13,7 @@
;;; Copyright © 2019 Giacomo Leidi <goodoldpaul@autistici.org>
;;; Copyright © 2019, 2020 Marius Bakke <mbakke@fastmail.com>
;;; Copyright © 2020 Nicolò Balzarotti <nicolo@nixo.xyz>
+;;; Copyright © 2020 Arthur Margerit <ruhtra.mar@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -53,6 +54,7 @@
#:use-module (gnu packages package-management)
#:use-module (gnu packages perl)
#:use-module (gnu packages perl-check)
+ #:use-module (gnu packages popt)
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages python)
#:use-module (gnu packages python-xyz)
@@ -61,6 +63,7 @@
#:use-module (gnu packages xml)
#:use-module (gnu packages xorg)
#:use-module (guix build-system gnu)
+ #:use-module (guix build-system cmake)
#:use-module (guix build-system meson)
#:use-module (guix build-system perl)
#:use-module (guix build-system python)
@@ -932,6 +935,45 @@ programming language. It also contains the utility
(home-page "https://sourceforge.net/projects/dbus-cplusplus/")
(license license:lgpl2.1+)))
+(define-public dbus-cxx
+ (package
+ (name "dbus-cxx")
+ (version "0.12.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://sourceforge/dbus-cxx/dbus-cxx/"
+ version "/dbus-cxx-" version ".tar.gz"))
+ (sha256
+ (base32
+ "1acsgpkd9v7b9jdc79ijmh9dbdfrzgkwkaff518i3zpk7y6g5mzw"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:configure-flags '("-DENABLE_TESTS=ON"
+ "-DENABLE_TOOLS=ON"
+ "-DENABLE_GLIBMM=ON")))
+ (inputs `(("dbus-glib" ,dbus)
+ ("libsigc++" ,libsigc++)
+ ("glibmm" ,glibmm)
+ ("python" ,python)
+ ("popt" ,popt)
+ ("expat" ,expat)))
+ (native-inputs `(("pkg-config" ,pkg-config)
+ ("m4" ,m4)))
+ (synopsis "C++ wrapper for dbus")
+ (description "Dbus-cxx is a C++ wrapper for dbus.\n
+It exposes the C API to allow direct manipulation and
+relies on sigc++ to provide an Oriented Object interface.\n
+This package provide 2 utils:
+@enumerate
+@item @command{dbus-cxx-xml2cpp} to generate proxy and adapter
+@item @command{dbus-cxx-introspect} to introspect a dbus interface
+@end enumerate
+
+Some codes examples can be find at:
+@url{https://dbus-cxx.github.io/examples.html}")
+ (home-page "https://dbus-cxx.github.io/")
+ (license license:gpl3)))
+
(define-public appstream-glib
(package
(name "appstream-glib")
--
2.28.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#44019: add dbus-cxx
2020-10-23 14:28 ` Miguel Ángel Arruga Vivas
@ 2020-10-24 1:02 ` Miguel Ángel Arruga Vivas
0 siblings, 0 replies; 7+ messages in thread
From: Miguel Ángel Arruga Vivas @ 2020-10-24 1:02 UTC (permalink / raw)
To: tiregram arthur; +Cc: 44019-done
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
Hi again,
Miguel Ángel Arruga Vivas <rosen644835@gmail.com> writes:
> I still need an answer for this. As soon as I have it, I hope sooner
> than later, I'll push this with the right origin, as you provided both
> versions already.
I've been checking this thread[1] and I've decided to keep url-fetch for
consistency inside the same file.
It has been pushed to master[2] with the indentation proposed by
etc/indent-code.el and a minor change there:
> + (inputs `(("dbus-glib" ,dbus)
I changed the name of the input from "dbus-glib" (that it's a different
library in the same file) to "dbus".
Again, thank you very much for your contribution. :-)
Happy hacking!
Miguel
[1] https://lists.gnu.org/archive/html/guix-devel/2020-05/msg00224.html and
[2] https://git.savannah.gnu.org/cgit/guix.git/commit/?id=4fbd3c36c6a6db8fc648ecdcc612c0e14a55a523.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 658 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-24 1:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-15 17:19 [bug#44019] add dbus-cxx tiregram arthur
2020-10-19 14:32 ` Miguel Ángel Arruga Vivas
2020-10-19 16:04 ` tiregram arthur
2020-10-19 17:24 ` Miguel Ángel Arruga Vivas
[not found] ` <CAHBH9LAGDi2TiTayM41e5uL2DJjzivd_yvEafZacP=WP92062Q@mail.gmail.com>
2020-10-22 16:26 ` Miguel Ángel Arruga Vivas
[not found] ` <CAHBH9LA_VWsJXXsGRCKa2UGrpLjgqWpNNmcP3_nR9zCsvg6hyw@mail.gmail.com>
[not found] ` <CAHBH9LAjetjdp_HbnhTGBESopH2vomSMdaL9kZOFsnD-B0YdRg@mail.gmail.com>
2020-10-23 14:28 ` Miguel Ángel Arruga Vivas
2020-10-24 1:02 ` bug#44019: " Miguel Ángel Arruga Vivas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).