From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6m7YC08Xl1/JVwAA0tVLHw (envelope-from ) for ; Mon, 26 Oct 2020 18:37:03 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kGVTB08Xl19PDAAAB5/wlQ (envelope-from ) for ; Mon, 26 Oct 2020 18:37:03 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id C4BD86800B7 for ; Mon, 26 Oct 2020 18:37:02 +0000 (UTC) Received: from localhost ([::1]:36740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX7Mb-0004eY-QS for larch@yhetil.org; Mon, 26 Oct 2020 14:37:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX6zP-00084n-1B for guix-patches@gnu.org; Mon, 26 Oct 2020 14:13:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57947) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kX6zO-0007ND-M6 for guix-patches@gnu.org; Mon, 26 Oct 2020 14:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kX6zO-0001jF-Ee for guix-patches@gnu.org; Mon, 26 Oct 2020 14:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44191] gnu: Add kristall Resent-From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Oct 2020 18:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44191 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Christopher Baines Cc: 44191@debbugs.gnu.org, nicolo@nixo.xyz Received: via spool by 44191-submit@debbugs.gnu.org id=B44191.16037359696626 (code B ref 44191); Mon, 26 Oct 2020 18:13:02 +0000 Received: (at 44191) by debbugs.gnu.org; 26 Oct 2020 18:12:49 +0000 Received: from localhost ([127.0.0.1]:41260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX6zB-0001io-G9 for submit@debbugs.gnu.org; Mon, 26 Oct 2020 14:12:49 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:54066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX6z9-0001iZ-EB for 44191@debbugs.gnu.org; Mon, 26 Oct 2020 14:12:48 -0400 Received: by mail-wm1-f46.google.com with SMTP id d78so12618714wmd.3 for <44191@debbugs.gnu.org>; Mon, 26 Oct 2020 11:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=qEnMzPhHekX3qgkAY0yD4rIcx0hcx4ynWXCQtLhxbe8=; b=CNYpjz0tz/RQMKz3fMbdWRWSfjwhVHO2WenqleZd2wMp8alfKqkBHp/QUd45hyBZNs KcsVyWONDug7ViFqxaHFzAj+qv/j4zZnrw2+pVRaBT7CZMzIxCMbp9aycqfaUbWY49uq ekews2sK0pRaxX7yye6gtIqdItALbUcs8Y1hjwtadOLonAZFcNHpuGLrwvc50IpUESV1 /pozh41vk3hApjGcfqmx1un2MjrtK5ClKH5LI1bv4D3IZeKrYmrvkiSggH4azJyaLlrp rGDNojWKT0xN5rbZ/riGsNY4GfvM12RgbejuXM51dABWSlcIAKZM3wtnsOnn5S2HCqOn r9HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=qEnMzPhHekX3qgkAY0yD4rIcx0hcx4ynWXCQtLhxbe8=; b=VkpfZAa4ZYjveYOX1n33Y7MFog4oiSXy8w7JmYbOsZaTlHzf907JE8ftQI8GirRKdr 1GmZoOMgBx8J2gP8aA17aJd1e78q+cGq+cD9EmgHmkPM/hqg2u91OIG4afF2VDcVZWYM mmGvSy6J88k+sv+XlPY1vKPUEV//fZj4mrZN7TQS+ahhB/EebeB9tZQ2mQCfi57MBCcd vh0KZaiF44pASqARR7tcy4uVa9wb7cVHTj7LGYmvBumfPD5sgzCLYkhFI8ltA8j8uNoz DxRFt5dK3w8AdCSa5jXZZYe4Xz15tO+2Bmw6F7bDs6DKSWxxbqL2FOXTmhYQN5UM9DEd jgwg== X-Gm-Message-State: AOAM530h6IYxTu9wb1cyXfwy9RdwbqwVFkQF54YBsTPBVEBsZYes2LAy UMJVAwig7y/GiO4dJfUSaQ8= X-Google-Smtp-Source: ABdhPJwAkbzMmQoniKD87rLDpvtMTuNwF/3qn6610HX04kjK+rnLGca31+6DQI6zG7rU2uQaGjzNuA== X-Received: by 2002:a7b:c181:: with SMTP id y1mr17132809wmi.58.1603735961634; Mon, 26 Oct 2020 11:12:41 -0700 (PDT) Received: from guixSD (host-87-8-141-238.retail.telecomitalia.it. [87.8.141.238]) by smtp.gmail.com with ESMTPSA id q7sm23142800wrr.39.2020.10.26.11.12.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 11:12:40 -0700 (PDT) From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti In-Reply-To: <87imaxym37.fsf@cbaines.net> References: <8736233h7h.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87o8kqab7i.fsf@cbaines.net> <87tuui1ce2.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87imaxym37.fsf@cbaines.net> Date: Mon, 26 Oct 2020 19:12:39 +0100 Message-ID: <87sga0n9ew.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 2.0 (++) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: 1.0 (+) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx2.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=CNYpjz0t; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx2.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: Ys1GQPb7BLJ3 Just linking to it would be easier. However, the file markdownrenderer requires access to implementation details of the struct cmark_node (it includes the file node.h, which is not installed by cmark, and fails with: ../src/renderers/markdownrenderer.cpp:83:23: error: invalid use of in= complete type =E2=80=98const cmark_node {aka const struct cmark_node}=E2=80= =99) I replaced references such as `node.as.heading.level` to `cmark_node_get_heading_level(node)` and so on. I could compile it (by also adding -I/gnu/store and -lcmark to the build process), and markdown seems to be working (tested here gemini://tilde.team/~supernova/blog/this-is-a-test-of-using-markdown.md). I'm going to send a patch to the author, linking to this mail exchange. I'll let you know. Christopher Baines writes: > Nicol=C3=B2 Balzarotti writes: > >> Hi Chris! >> >> Thanks for the review. >> >> I tried, but: >> 1. breeze is a different package from the ones in the repo (url is >> https://github.com/Alexhuszagh/BreezeStyleSheets). It does not seems to >> be compiled, I can try to package it. >> 2. there are files in lib/cmark that are not present in the cmark >> distribution (thei are .h files generated by their .h.in), so I cannot >> extract our cmark source directly >> - I tried keeping those files, but build fails [[failed-build]]. Not= sure if it's >> a patched version or if it's an older one. But I can investigate >> probably > > I think you might be overcomplicating this. kristall shouldn't be trying > to build cmark, as it's a library, it should just be linking against > it. Therefore, you shouldn't need to keep the .h.in files. > > Making kristall use cmark, rather than the copy in the kristall source > probably requires adapting/fixing src/kristall.pro. > > It hopefully isn't that difficult, but I don't know what this .pro file > is, it also looks pretty odd in parts, especially the references to > /home/felix/... ! > > It doesn't look like the copy of cmark in the kristall source has been > modified much, which also raises the question of why there is a copy of > the cmark source inside kristall?