From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KJ+AA06WnF9QdQAA0tVLHw (envelope-from ) for ; Fri, 30 Oct 2020 22:40:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aLMXO02WnF/TXQAA1q6Kng (envelope-from ) for ; Fri, 30 Oct 2020 22:40:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 77321940222 for ; Fri, 30 Oct 2020 22:40:13 +0000 (UTC) Received: from localhost ([::1]:58024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYd48-0001hw-9o for larch@yhetil.org; Fri, 30 Oct 2020 18:40:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYd3y-0001hj-B9 for guix-patches@gnu.org; Fri, 30 Oct 2020 18:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYd3y-0007rt-1Q for guix-patches@gnu.org; Fri, 30 Oct 2020 18:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYd3x-0003pD-UX for guix-patches@gnu.org; Fri, 30 Oct 2020 18:40:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44321] [PATCH 5/6] transformations: Raise '&formatted-message' exceptions instead of 'leave'. Resent-From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 30 Oct 2020 22:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44321 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 44321@debbugs.gnu.org Received: via spool by 44321-submit@debbugs.gnu.org id=B44321.160409756814658 (code B ref 44321); Fri, 30 Oct 2020 22:40:01 +0000 Received: (at 44321) by debbugs.gnu.org; 30 Oct 2020 22:39:28 +0000 Received: from localhost ([127.0.0.1]:60071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYd3Q-0003oM-8y for submit@debbugs.gnu.org; Fri, 30 Oct 2020 18:39:28 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:36160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYd3O-0003o8-5c for 44321@debbugs.gnu.org; Fri, 30 Oct 2020 18:39:26 -0400 Received: by mail-wm1-f67.google.com with SMTP id e2so4260584wme.1 for <44321@debbugs.gnu.org>; Fri, 30 Oct 2020 15:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pJJl8p66gMbjcM9AC5AuNr9tWd+h8hVN8mUznTCjo54=; b=FgxqwjvXQsDrzOd8cUnlP0fdL/nvLRxN4ZY48fxrAem/ZMg3pgENBBaJn8JJ4foW5i u08FWWNAeWecTZjqyRhk0IbDucUHALzpTXP1DcpL5rg7cBfJ+ep7CjK4ug/t6vn3HDAR 4GDjoMQ4hdKKMcGuRXbSEsOiBsRhm93Yc4287S4M50htJylpF5xTU7ctAH16MQw56Q6i NqnkIMw8r7V9qDZKB4k5zw6HUaPZRmKnIB8VK/8oidDo6GFQQBEuXHypIdJQWRzGZZeU rrGRbKcZbhZE2Wj6Ih3AKOLFYZDs9b0k4ugDI1Fm8YV5xlojrnaj3vFnqLE6D9bpU6Zr QOYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=pJJl8p66gMbjcM9AC5AuNr9tWd+h8hVN8mUznTCjo54=; b=deTo1AOsCjLrlJIRt5PxLJ4pa7ffAvqWlu+uKQ9fa8X1RYl5iFnvkbC26+YEE0aJo7 o5taURPVbkxoIARYX7koPG0kdUhzTYNqLNCEJVjjgZCTe381D0AYS/s+afZt32DjIx89 uu7uZpC91XBNIHrpDYUTcGfXXGeeUMVCIjQx3ySUit13HxulINYwDBa9yXUGiLygPcmu W6mpCH094UBQifUvopLVuGjnszOLaQvL5f2LYuqsh/AxoBN72I/qJndbqeBeXQxgtI3Z 0TctvOHC1GyXOkqAOV4bIUVruMFmSzgx3/p0bPMDLBerpuNNzbBXTf8u5VrroKvGFsuJ h2Ew== X-Gm-Message-State: AOAM5336D4A/7+CjdBdD2Jn2rYtqM+oEJLsnB7KMp49wMIdUN0l6353L NL6gwKdRC2Arrcf82pFp5VTs49+13KO1CEsO X-Google-Smtp-Source: ABdhPJz/0fPqmE/5WbabtmFfwkqnNMG/Ev0GYLqoyIcXN2cIXVW6JLyNdXNUqCntdhRylgxETc0wZg== X-Received: by 2002:a1c:9695:: with SMTP id y143mr4818385wmd.146.1604097560146; Fri, 30 Oct 2020 15:39:20 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id g4sm6193176wmh.13.2020.10.30.15.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 15:39:19 -0700 (PDT) From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas References: <20201029231000.14568-1-ludo@gnu.org> <20201029231000.14568-5-ludo@gnu.org> <878sbo6ku6.fsf@gmail.com> Date: Fri, 30 Oct 2020 23:39:03 +0100 In-Reply-To: <878sbo6ku6.fsf@gmail.com> (zimoun's message of "Fri, 30 Oct 2020 11:59:13 +0100") Message-ID: <87sg9v49vc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.8 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=FgxqwjvX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.01 X-TUID: xAnowIhSX41X --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi simon and Ludo, zimoun writes: > Hi, > > On Fri, 30 Oct 2020 at 00:09, Ludovic Court=C3=A8s wrote: > >> (transform-package-toolchain): Use 'raise' and 'formatted-message' >> instead of 'leave'. > > Naive question: what is the difference? Other said why? And so why not > replaces =E2=80=99leave=E2=80=99 here and there by =E2=80=99raise=E2=80= =99+=E2=80=99formatted-message=E2=80=99? Probably Ludo can explain better, but the main difference I see is that leave (guix diagnostics) calls exit, so the client code now can handle these errors and it isn't forced to exit. The patch LGTM. Just one extra comment, this changes some format strings, so we shouldn't forget to send the latest pot files to TP as soon as we generate the branch for the release. Happy hacking! Miguel --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+clggACgkQY0xuiXn6 vsJBZAv+OdtyADLMw1hQfuA6ZLgxlcOhsmldH6wlOlF9PqDIP+6C1rmiqFE6NYvz 6rZkseIZUTvZVoDgJJrUwNGj7zIDSCfxLpy7tuolHxFd8uJLlObuYVjXfllFnNPs dIxh7V2/WJQiks7V+0zy5a0F2eeXzrF2EmqfmrwkZv34WKircjYpP/DHmytiGpfY StvcPwjKgIR2wMK+SY11ipKj2rTEtCduoasVuADgga8ivtoL3DL1RyuLckHgYllm 6LUFBWlqtECcmse8b1mFvx6oC3UfyXuqHR0MyVscBLLIvA9uWc4VobXkaHfDNcBh qKDUV3kC5G4tE/tVFyBTO/zwi91QjemSC4mR6J2mRFB/x+R8ho1gM7tM5PDVJ1Ym 1PYDgSwjsO5LdeyrkBzoP0pD7hoXk1PP6pDGc/ds4imqrvrbjzGlYEqtQ3r0IU8P /6ORhPte4AJb83aeq8BT3bpxsRWTPagR88AxOO+1/RKw/44tr6JkvzWeLG6rfNXR 0tnkPpRS =D73t -----END PGP SIGNATURE----- --=-=-=--