unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Stefan Reichör" <stefan@xsteve.at>
Cc: 46996-done@debbugs.gnu.org
Subject: bug#46996: [PATCH] gnu: Add emacs-tup-mode.
Date: Mon, 08 Mar 2021 00:16:27 +0100	[thread overview]
Message-ID: <87sg564ks4.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20210307215741.477828-1-stefan@xsteve.at> ("Stefan Reichör"'s message of "Sun, 7 Mar 2021 22:57:41 +0100")

Hello,

Stefan Reichör <stefan@xsteve.at> writes:

> * gnu/packages/emacs-xyz.scm (emacs-tup-mode): New variable.

Applied. Thank you.

> +(define-public emacs-tup-mode
> +  (package
> +    (name "emacs-tup-mode")
> +    (version "1.3.1")
> +    (home-page "https://github.com/ejmr/tup-mode")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url home-page)

Nitpick: I'm not a big fan of this hack, since modifying the home-page
can break the build. So I moved it changed it.

> +    (synopsis "An Emacs major mode for editing Tup files")

I changed the synopsis so it does not start with "An" anymore (see "guix
lint")

> +    (description
> +     "Major mode for Emacs made for editing ‘tupfiles’.  These are files used
> +by the Tup build system.")

I used full sentences for the description.

Regards,
-- 
Nicolas Goaziou




      reply	other threads:[~2021-03-07 23:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-07 21:57 [bug#46996] [PATCH] gnu: Add emacs-tup-mode Stefan Reichör
2021-03-07 23:16 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg564ks4.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=46996-done@debbugs.gnu.org \
    --cc=stefan@xsteve.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).