From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ZFDlC4G/DGHD0gAAgWs5BA (envelope-from ) for ; Fri, 06 Aug 2021 06:50:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eGEBB4G/DGF7ZQAA1q6Kng (envelope-from ) for ; Fri, 06 Aug 2021 04:50:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 53C4515725 for ; Fri, 6 Aug 2021 06:50:08 +0200 (CEST) Received: from localhost ([::1]:56412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBro6-0004tR-R7 for larch@yhetil.org; Fri, 06 Aug 2021 00:50:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBro2-0004sz-P3 for guix-patches@gnu.org; Fri, 06 Aug 2021 00:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37317) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBro2-0002Jv-Ii for guix-patches@gnu.org; Fri, 06 Aug 2021 00:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBro2-00026I-9N for guix-patches@gnu.org; Fri, 06 Aug 2021 00:50:02 -0400 Subject: bug#41790: [PATCH] Update emacs-direnv Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 06 Aug 2021 04:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41790 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Katherine Cox-Buday Cc: Oleg Pykhalov , 41790-done@debbugs.gnu.org, Nicolas Goaziou Mail-Followup-To: 41790@debbugs.gnu.org, maxim.cournoyer@gmail.com, cox.katherine.e@gmail.com Received: via spool by 41790-done@debbugs.gnu.org id=D41790.16282254018060 (code D ref 41790); Fri, 06 Aug 2021 04:50:02 +0000 Received: (at 41790-done) by debbugs.gnu.org; 6 Aug 2021 04:50:01 +0000 Received: from localhost ([127.0.0.1]:48861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBro0-00025v-Ur for submit@debbugs.gnu.org; Fri, 06 Aug 2021 00:50:01 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]:34649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBrnz-00025i-IB for 41790-done@debbugs.gnu.org; Fri, 06 Aug 2021 00:49:59 -0400 Received: by mail-qt1-f175.google.com with SMTP id e15so2950463qtx.1 for <41790-done@debbugs.gnu.org>; Thu, 05 Aug 2021 21:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1jutYLmFpHAW49hlNvnX2jbYIX9F/HaAzAtApBtcpio=; b=RnfrjqRM9g5y9qze6+Cp36YqWqaeIkOIPtlqqKNJqaFdIEKEJ6yFcVCRQMH4GdSNsd jHUxc5pFFxRf1BHOIkwkwlU1u7OBR8l8ZaVOFreuLKjro3sLXMjWwc5Y7TvvSSJ4L0wD 3zqlR/T5EuKSNF4wa5+zQnhnmku1tR/U5ognztRZM+RFTGFBT9/2aO3ea77a1+0nMDUj gyOfzENo4T5Se68sSf+shl5tdLdWFDIUCgpGIEwFfx5F86uQ0Ra5veTlBkpADd5BvIuL 6wDJd5b2BdX4xg0/+rsjz268ax7ESUqIvGkLmbXCmw67e7OhCVVBJ7VTMtY7oJXn7uwB hc4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=1jutYLmFpHAW49hlNvnX2jbYIX9F/HaAzAtApBtcpio=; b=baeuoysG36t/kTq88gyvo2SM77yUO5LZicrxEoUdcR3ebAkRAfC2Ig4ufOE6Nj2qSV qdRA+fLNkCC7C1/uzQtORRSxCINWggpTNxTOym5nWfpq992sVxIv/zQn//EvyOGFwIpp ISroN+cWOR5qUba4R9BG9ccvydTTfZEcyfiRj8URTHBaGk1w/X4HxG5eBNSiK6JhHRSX 9VQaaLhN6jlJZtj1HBYwgvyFaO3UaQZRJojurQ5FRxzWS342iExv+4Rzl9CAAvoqvvT8 L6IJTNu+YW0rm3Jz4pQddn0inaoS1l5QH08ZO3FIkz+LwATG2SNd9yXn8nbcbJ6h0Cfp VLyQ== X-Gm-Message-State: AOAM533y232fxqVXjzNVcRBqt3vXZz98B1yVVZ/2P/gSs4kaNXx/hj4J kXUE5I7bheQQ2Q9BaDBQ/bE= X-Google-Smtp-Source: ABdhPJyMNaCRBqRCxuhO3oKQzW5MU5nLCAG4N/dldTGK37qdW1dvMXs+UKrhlI2vaZGRW885521DSA== X-Received: by 2002:ac8:7e86:: with SMTP id w6mr7647540qtj.194.1628225394012; Thu, 05 Aug 2021 21:49:54 -0700 (PDT) Received: from hurd (dsl-151-109.b2b2c.ca. [66.158.151.109]) by smtp.gmail.com with ESMTPSA id x14sm3099120qts.13.2021.08.05.21.49.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 21:49:53 -0700 (PDT) From: Maxim Cournoyer References: <871rmmoq7u.fsf@nicolasgoaziou.fr> <87pna6zy3l.fsf@gmail.com> <87k10e92tg.fsf@gmail.com> <87eeql8xws.fsf@gmail.com> Date: Fri, 06 Aug 2021 00:49:52 -0400 In-Reply-To: <87eeql8xws.fsf@gmail.com> (Katherine Cox-Buday's message of "Thu, 11 Jun 2020 09:44:35 -0500") Message-ID: <87sfznjhxr.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628225408; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=1jutYLmFpHAW49hlNvnX2jbYIX9F/HaAzAtApBtcpio=; b=K3dupDZCfAJwXDbyk3To9ezjLzPsUsGVQZUhSVVNyqQOzKGR3Zb6TsTyQsPduDvIgTi1Z6 +7DNx/4S7ajhnra33WAiFh5FxO65uPNTS/hx7Q0zEZrIoD3GII0XVyW0zi+jPnHN7y5fjP uV8e7RZnQfx2p6Bg7Oi5mK3bouHHqhsg5Wgt8nWM7DFR5bA7cQS/VyfqgN/Lv6EuDqShnB eNtMRG9ZVaIZgJOuzFDhjgY4G7TfX76wj5IpqHJvVTgfQiMT2T9utF9ERcp16egQJ0eAMK zp/KrbTC5GSyqWAXrWt4j+a76NtpQX1Mj2KtOytC6WUiglRGpYXUiNZxqaj6Pw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628225408; a=rsa-sha256; cv=none; b=a2iyQTJMFqxPXqx0hqx6uL4mSEggFEtj6FDvQuhpXC+6hjJbsuZ8jTE8NVZ8ArGhs9tYB1 7LwZ0ugeFUacAKzrZ8dhrjt2emY078tYSl73nEJRE7MkFAFwx0+tMGJHUwiYKUEnB/luHF ztC6x0KFIOQ9VJ78DUsyFo1y1S7uYq6hDuZRP4A8tuDUTQi5wnlMtLIMHAVYhPndbpp2IC G5Bl5agwRuoz+55QlkyVdUEuZJagW4HFo+oM18Bu/jRMHyZ+oTjFFJ/danYrfx99gB9BYj Ljq8P51XYnGCwqTvug0/gkdOf8RuESwlD6tUG2JfpkHSH2nxJBYg6vAsJUjk/Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=RnfrjqRM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=RnfrjqRM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 53C4515725 X-Spam-Score: 0.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: CTjb+O+xXUTX Hello, Katherine Cox-Buday writes: [...] > (build-system emacs-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-in-direnv > + (lambda* (#:key inputs #:allow-other-keys) > + (let* ((direnv-path (assoc-ref inputs "direnv")) > + (direnv-bin (string-append > + "\"" direnv-path "/bin/direnv\""))) > + (substitute* "direnv.el" > + (("\"direnv\"") direnv-bin)))))))) > + (inputs > + `(("direnv" ,direnv))) > (propagated-inputs > `(("dash" ,emacs-dash) > ("with-editor" ,emacs-with-editor))) Thanks to Nicolas and Oleg for the thoughtful review. They had good comments about was propagation was not the best way to make the package usable out of the box. Now that the above does the same but in a functional way, I think it is a good addition. I applied the above hunk (the package had already been updated) as commit 0d72f24ac084acf9d69e147a692e5d8bcb2ea21b. Thank you! Closing. Maxim