unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Katherine Cox-Buday <cox.katherine.e@gmail.com>
Cc: Oleg Pykhalov <go.wigust@gmail.com>,
	41790-done@debbugs.gnu.org,
	Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: bug#41790: [PATCH] Update emacs-direnv
Date: Fri, 06 Aug 2021 00:49:52 -0400	[thread overview]
Message-ID: <87sfznjhxr.fsf_-_@gmail.com> (raw)
In-Reply-To: <87eeql8xws.fsf@gmail.com> (Katherine Cox-Buday's message of "Thu, 11 Jun 2020 09:44:35 -0500")

Hello,

Katherine Cox-Buday <cox.katherine.e@gmail.com> writes:

[...]

>      (build-system emacs-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-in-direnv
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let* ((direnv-path (assoc-ref inputs "direnv"))
> +                    (direnv-bin (string-append
> +                                 "\"" direnv-path "/bin/direnv\"")))
> +               (substitute* "direnv.el"
> +                 (("\"direnv\"") direnv-bin))))))))
> +    (inputs
> +     `(("direnv" ,direnv)))
>      (propagated-inputs
>       `(("dash" ,emacs-dash)
>         ("with-editor" ,emacs-with-editor)))

Thanks to Nicolas and Oleg for the thoughtful review.  They had good
comments about was propagation was not the best way to make the package
usable out of the box.  Now that the above does the same but in a
functional way, I think it is a good addition.

I applied the above hunk (the package had already been updated) as
commit 0d72f24ac084acf9d69e147a692e5d8bcb2ea21b.

Thank you!

Closing.

Maxim




      parent reply	other threads:[~2021-08-06  4:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 15:12 [bug#41790] [PATCH] Update emacs-direnv Katherine Cox-Buday
2020-06-10 16:11 ` Nicolas Goaziou
2020-06-10 16:26   ` Katherine Cox-Buday
2020-06-10 18:05     ` Nicolas Goaziou
2020-06-10 18:31       ` Katherine Cox-Buday
2020-06-10 18:46     ` Oleg Pykhalov
2020-06-11 14:44       ` Katherine Cox-Buday
2020-06-11 20:03         ` Oleg Pykhalov
2020-06-11 20:31         ` Oleg Pykhalov
2021-08-06  4:49         ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfznjhxr.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=41790-done@debbugs.gnu.org \
    --cc=cox.katherine.e@gmail.com \
    --cc=go.wigust@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).