From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KD2sLwsQNWHiCgAAgWs5BA (envelope-from ) for ; Sun, 05 Sep 2021 20:44:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oCUeKwsQNWEEOwAAbx9fmQ (envelope-from ) for ; Sun, 05 Sep 2021 18:44:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1D7EE4820 for ; Sun, 5 Sep 2021 20:44:27 +0200 (CEST) Received: from localhost ([::1]:53652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMx7x-0002Lc-8E for larch@yhetil.org; Sun, 05 Sep 2021 14:44:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMx7a-0002Ki-7l for guix-patches@gnu.org; Sun, 05 Sep 2021 14:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39476) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMx7Z-0007H1-UY for guix-patches@gnu.org; Sun, 05 Sep 2021 14:44:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mMx7Z-0002jj-T4 for guix-patches@gnu.org; Sun, 05 Sep 2021 14:44:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50375] [PATCH v2] gnu: Add mlterm. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 05 Sep 2021 18:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50375 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: iKaSeRo , 50375@debbugs.gnu.org Cc: iKaSeRo Received: via spool by 50375-submit@debbugs.gnu.org id=B50375.163086743210497 (code B ref 50375); Sun, 05 Sep 2021 18:44:01 +0000 Received: (at 50375) by debbugs.gnu.org; 5 Sep 2021 18:43:52 +0000 Received: from localhost ([127.0.0.1]:51022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMx7Q-0002jF-E9 for submit@debbugs.gnu.org; Sun, 05 Sep 2021 14:43:52 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:44350 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMx7N-0002iy-QU for 50375@debbugs.gnu.org; Sun, 05 Sep 2021 14:43:51 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1630867420; bh=ePgw99f2kZaafvDIsrfHK5KdTU3qYnjWrgDbjBwQWKU=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=SehXgFdp6lBhPGfj1h4gNOYCWPzghKRMuyKRt0QpyV0H4hDtnRyUh9fyzQvgL2Phc jc4vFak3+zqqpSNX5WzPtAVR4U6f32twFlQRIKoMHCDi2l5REnmHKwN7MK1gso27j3 GU0LxhPj/iV3CaKIU7/9zavUuaHvtt3KmcN3cSQM= In-Reply-To: <20210905113102.9467-1-ahmed@ikasero.com> References: <87mtos3yt9.fsf@yoctocell.xyz> <20210905113102.9467-1-ahmed@ikasero.com> Date: Sun, 05 Sep 2021 20:43:08 +0200 Message-ID: <87sfyi3ltv.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630867467; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=TfJIQNYEHlkqUwURDasspyLSahzzkYMRYeBvlpLdKRw=; b=ojxguZCOrycpjIJvrtAUVykrzIHMUmbTDA/NERrSUOE+VbH68XBaKqf2cYLFEqYbjG3D3z bv2BdjKpBLtHQxa6742QL780He/XG8kZM84T8vZHIDwCDqMwXDbMn8dCHcpvhYle8+xj6+ o1gdjCZsoaC9kycmSe/0841wQZwr6TFx+ldeR3ElXPcY7ft1XuGkhUOww8LA8FCK8k3IbJ uwr08IoFr1p7kJ6bv5ZTLD4MRNcN/TgyYi9ZeoFnr/4ZanahlVZwNSCUebHfBunA1bccz8 ABF0ZNEEOMLARVQNt2p2QNFA8efXRCqlnhN+q6FaIOP3mhPoEcQQXOmYFsfuNw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630867467; a=rsa-sha256; cv=none; b=ixbGxM8sKfqGjP/TZ/GRU4FngumWYCKk4CjAwn9G7aX5vvzSF/R7lSSLn0xaMuHgRGd9un f66nyHeqsK7pI+d9IzUoVgO3Io7YUVFskQHMbYva7zVkKLPfNEMUeQcja0UHljY3boFLXD 8gs5g9LHUacpffIFKEMUTMcIKCY+BUs3sirP2+EtbZjBVnD/GaxIDScFbXqnkMlYUTELzJ sFq2wNCQnNfCMJ4+YZLMSsMC6Jn0CFXqZDQduM8OirNxUYfkxi6eW1cbJdAWOh31pxbly1 ocC/zbTy4si/ONOllFC0pEvrkycZhPxiMLk8dErAQFhtzkVMUgnu424qUDyaGA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=SehXgFdp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=SehXgFdp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1D7EE4820 X-Spam-Score: -3.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: y1hPMyWWt8rR --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sun, Sep 05 2021, iKaSeRo wrote: > * gnu/packages/terminals.scm (mlterm): New variable. > --- > Xinglu Chen writes: > >>> * gnu/packages/terminals.scm (mlterm): New variable. >>> --- >>> gnu/packages/terminals.scm | 40 ++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 40 insertions(+) >>> >>> diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm >>> index 1cdf0e1831..037504ee4f 100644 >>> --- a/gnu/packages/terminals.scm >>> +++ b/gnu/packages/terminals.scm >>> @@ -25,6 +25,7 @@ >>> ;;; Copyright =C2=A9 2020 Leo Famulari >>> ;;; Copyright =C2=A9 2021 Ekaitz Zarraga >>> ;;; Copyright =C2=A9 2021 Rapha=C3=ABl M=C3=A9lotte >>> +;;; Copyright =C2=A9 2021 ikasero >>> ;;; >>> ;;; This file is part of GNU Guix. >>> ;;; >>> @@ -66,6 +67,7 @@ >>> #:use-module (gnu packages docbook) >>> #:use-module (gnu packages fontutils) >>> #:use-module (gnu packages freedesktop) >>> + #:use-module (gnu packages fribidi) >>> #:use-module (gnu packages gettext) >>> #:use-module (gnu packages ghostscript) >>> #:use-module (gnu packages gl) >>> @@ -1458,3 +1460,41 @@ ephemeral serial ports. It features automatic p= ort detection, port enumeration, >>> support for non-standard baud rates, the ability to wait for ports to = appear, >>> and the ability to read and write via stdin and stdout.") >>> (license license:expat))) >>> + >>> +(define-public mlterm >>> + (package >>> + (name "mlterm") >>> + (version "3.9.1") >>> + (source >>> + (origin >>> + (method url-fetch) >>> + (uri (string-append "mirror://sourceforge/mlterm/01release/mlte= rm-" >>> + version "/mlterm-" version ".tar.gz")) >>> + (sha256 >>> + (base32 >>> + "03fnynwv7d1aicwk2rp31sgncv5m65agvygqvsgn59v9di40gnnb")))) >>> + (build-system gnu-build-system) >>> + (arguments `(#:tests? #f >> >> What=E2=80=99s the reason for disabling tests; there should be a comment= with a >> short explanation. >> > Because there are no tests, Now I added a comment thanks! >> Nit: This is usually on its own line >> >> (arguments >> `(#:tests? #f >> #:configure-flags >> ...)) >> > Didn't know that, fixed >>> + #:configure-flags >>> + (list (string-append "--prefix=3D" (assoc-ref %output= s "out")) >>> + "--disable-static" >>> + "--enable-optimize-redrawing" >>> + "--with-imagelib=3Dgdk-pixbuf"))) >>> + (native-inputs >>> + `(("gettext" ,gettext-minimal) >>> + ("pkg-config" ,pkg-config))) >>> + (inputs >>> + `(("cairo" ,cairo) >>> + ("fontconfig" ,fontconfig) >>> + ("freetype" ,freetype) >>> + ("fribidi" ,fribidi) >>> + ("gdk-pixbuf" ,gdk-pixbuf) >>> + ("gtk+" ,gtk+) >>> + ("libx11" ,libx11) >>> + ("libxext" ,libxext) >>> + ("libxft" ,libxft))) >>> + (home-page "http://mlterm.sourceforge.net/") >>> + (synopsis "Multi Lingual TERMinal emulator") >>> + (description "mlterm is a multi-lingual terminal emulator which su= pports >>> +various character sets and encodings in the world.") >>> + (license license:bsd-3))) >>> --=20 >>> 2.33.0 >> >> The package builds fine, and the rest LGTM! > Thanks for the review! You are welcome! The updated patch looks good, but I don=E2=80=99t have co= mmit access. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmE1D70VHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5aroP/RbhxUIt4q3crtI12TLFpk+RDegx Mtql2A+YzlUb/3GXZKeTxLXoaSpa/PMXip+jDc9Nq/dudq+eq8OtWwKdvNfw/UB4 AGAkxXcTlVbwfqpO2hf5MIzlCr9otKbWwASYRaS9FGnAJlgYyvzLd8JVH9RS7JAd 2flWXOfyKIphlUpX8c/jZ5cH93nlKegBraqsVu2U0GGTsChXR9Rn46qTA+ahHEiK /169FzVwpJAxLaosOPLTflB1wZrxaNmG3wycltbe+4ElLlvN7n/B3TDpkjmSYZgB BTQspHT/h3pEZ+YwOC2z/21oCnOP8ioSeA8XBQ9wpfwHPhRnmZ2QCbROvSrS19Gb s28TgWETJMiqyYHLOALTssf/XUtq3kBy8FtiQMhIv89kv2e9GJNpp5dKWOrOdXvi oQW//dZ22KfaybiamIRiK0rtWZBPk1cYgFkBPWQgUypGOPadXXal348V7eqhp/TX y04L1oAqoZGMZohw7/JoL60pcpfgqpnyX0RrMavsmTlFg0J/bMiploAWizBT0srN /TIgXgUmyhjG6COPamJsRAvbb+lFxBTQHzaOr65M0m6VlUITJr9wWPzxA6RSdSQc XmNi8YDSl+fsH2mEBFAchXks2rAVilgDHooM+eBFL923ss+tR5rAGFzOjpJTYhjt r7TvkoGn5+Yaw5tX =4Xrq -----END PGP SIGNATURE----- --=-=-=--