From: Xinglu Chen <public@yoctocell.xyz>
To: 50930@debbugs.gnu.org
Cc: jgart <jgart@dismail.de>
Subject: [bug#50930] [PATCH] gnu: Add guile-pipe.
Date: Fri, 01 Oct 2021 16:04:20 +0200 [thread overview]
Message-ID: <87sfxklu3f.fsf@yoctocell.xyz> (raw)
In-Reply-To: <20211001083028.8694-1-jgart@dismail.de>
[-- Attachment #1: Type: text/plain, Size: 2121 bytes --]
On Fri, Oct 01 2021, jgart via Guix-patches via wrote:
> * gnu/packages/guile-xyz.scm (guile-pipe): New variable.
> ---
> gnu/packages/guile-xyz.scm | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index 7188058b42..f5c5ccd8da 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -256,6 +256,32 @@ more.")
> (home-page "https://www.gnu.org/software/artanis/")
> (license (list license:gpl3+ license:lgpl3+)))) ;dual license
>
> +(define-public guile-pipe
> + (let ((commit "0746ec38d19d844dff0c6f62f209b2b6c8d8872e")
> + (revision "0"))
There should be a comment stating why a commit and not a tag is used.
In this case it seems that upstream is lacking tags.
> + (package
> + (name "guile-pipe")
> + (version (git-version "0.0.0" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/joshwalters/guile-pipe")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))))
> + (build-system guile-build-system)
> + (native-inputs
> + `(("guile" ,guile-3.0)))
> + (home-page "https://github.com/joshwalters/guile-pipe")
> + (synopsis "Guile pipe macros for functional chaining")
> + (description
> +"Guile pipe macros for functional chaining, similar to the UNIX pipe
> +@command{|} operator. Provides identical functionality to Clojure's function
> +threading macros @command{->} and @command{->>}.")
s/@command/@code/
The description should consist of full sentences (see “16.4.4 Synopses
and Descriptions” in the manual); both sentences are lacking a subject.
I suggest:
This package provides macros for functional chaining in Guile, similar
to UNIX pipes (@code{|}) and Clojure's threading macros (@code{->} and
@code{->>}).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-10-01 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 8:21 [bug#50930] [PATCH] gnu: Add guile-pipe jgart via Guix-patches via
2021-10-01 8:30 ` jgart via Guix-patches via
2021-10-01 14:04 ` Xinglu Chen [this message]
2021-10-01 14:33 ` jgart via Guix-patches via
2021-10-01 14:33 ` jgart via Guix-patches via
2021-10-01 16:49 ` Xinglu Chen
2021-10-01 18:30 ` bug#50930: " Liliana Marie Prikler
2021-10-01 20:24 ` [bug#50930] " jgart via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfxklu3f.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=50930@debbugs.gnu.org \
--cc=jgart@dismail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).