unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Filip Staffa <gnu@filipstaffa.net>
Cc: 51064@debbugs.gnu.org
Subject: [bug#51064] [PATCH] gnu: fish: Update to 3.3.1
Date: Fri, 15 Oct 2021 17:16:17 +0200	[thread overview]
Message-ID: <87sfx2iaim.fsf@gnu.org> (raw)
In-Reply-To: <iNtZ-xDmyJB_mago4_JD6sT0cUYD5m351B-TsCT-a1NPTh7CTI5mGvzb-NVXzBYvneInJaywETDpaphG3gmGSKwzJ7wjyi8cuPBC6X747JA=@filipstaffa.net> (Filip Staffa's message of "Tue, 12 Oct 2021 19:31:20 +0000")

Hi Filip,

Filip Staffa <gnu@filipstaffa.net> skribis:

> thanks for checking the patch. It worked on my machine, so I have
> checked the test itself. It looks like in your case it failed on a
> precondition. It checks the environment for processes matching Z*, and
> if it find any it fails.  Specifically this command (found here:
> https://github.com/fish-shell/fish-shell/blob/Integration_3.3.1/tests/checks/jobs.fish#L9
> ): ps -o s | string match 'Z*' | count

Builds happen in an isolated environment, specifically in a separate PID
namespace.  So what’s running on my machine shouldn’t matter.

> Would you be able to stop all such processes/run it in environment
> where this command returns 0? If not I would propose to close this
> patch and wait for next version of fish shell, it looks like they
> fixed the test to be less flaky on Fish master branch.

Alternatively, if you prefer, we can apply upstream’s patch in Guix.

Let me know!

Thanks,
Ludo’.




  reply	other threads:[~2021-10-15 15:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 18:17 [bug#51064] [PATCH] gnu: fish: Update to 3.3.1 Filip Staffa via Guix-patches via
2021-10-12 15:02 ` Ludovic Courtès
2021-10-12 19:31   ` Filip Staffa via Guix-patches via
2021-10-15 15:16     ` Ludovic Courtès [this message]
2021-10-15 15:42       ` Filip Staffa via Guix-patches via
2021-10-15 22:26         ` bug#51064: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfx2iaim.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=51064@debbugs.gnu.org \
    --cc=gnu@filipstaffa.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).