From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YLFeJvUybWF3mgAAgWs5BA (envelope-from ) for ; Mon, 18 Oct 2021 10:40:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0M0NIvUybWGvCgAAB5/wlQ (envelope-from ) for ; Mon, 18 Oct 2021 08:40:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0DB3B2B7E3 for ; Mon, 18 Oct 2021 10:40:21 +0200 (CEST) Received: from localhost ([::1]:32870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcOBw-0001Z7-8v for larch@yhetil.org; Mon, 18 Oct 2021 04:40:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcOBe-0001Ys-QX for guix-patches@gnu.org; Mon, 18 Oct 2021 04:40:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcOBe-0002BR-Hy for guix-patches@gnu.org; Mon, 18 Oct 2021 04:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcOBe-0001IV-FQ for guix-patches@gnu.org; Mon, 18 Oct 2021 04:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51091] [PATCH v2] guix: opam: Do not fail when refreshing. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 18 Oct 2021 08:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51091 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 51091@debbugs.gnu.org, Xinglu Chen Received: via spool by 51091-submit@debbugs.gnu.org id=B51091.16345463544914 (code B ref 51091); Mon, 18 Oct 2021 08:40:02 +0000 Received: (at 51091) by debbugs.gnu.org; 18 Oct 2021 08:39:14 +0000 Received: from localhost ([127.0.0.1]:45913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcOAr-0001HB-QJ for submit@debbugs.gnu.org; Mon, 18 Oct 2021 04:39:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcOAq-0001H0-PI for 51091@debbugs.gnu.org; Mon, 18 Oct 2021 04:39:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59946) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcOAk-0001MT-Nb; Mon, 18 Oct 2021 04:39:06 -0400 Received: from [193.50.110.252] (port=58232 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcOAk-0005qV-DT; Mon, 18 Oct 2021 04:39:06 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20211008050310.407d6b23@tachikoma.lepiller.eu> <87y272lepg.fsf@yoctocell.xyz> <871r4nrc9t.fsf_-_@gnu.org> <20211016041009.5b4ddff0@tachikoma.lepiller.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 =?UTF-8?Q?Vend=C3=A9miaire?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 18 Oct 2021 10:39:04 +0200 In-Reply-To: <20211016041009.5b4ddff0@tachikoma.lepiller.eu> (Julien Lepiller's message of "Sat, 16 Oct 2021 04:10:09 +0200") Message-ID: <87sfwybuc7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634546421; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=7fZ8/LuGho3W8ppS2ersWmtrClW266Yx2ZWg0CWKK3k=; b=YWEdrmLjCz+s28Xqsh/VrmU/N2PfxI1r+DO9I8zY9P0FEGNOGHQw3bRJ9CPGMW01wIXH5v 5NLFXUu0qRz34Za8o3hxE1ODPHbwZenRZ9sKX8IPwWF6YXA+zlle7fO2pMkZsLiNmDy9T4 wURO8EI+4W6gIB/WFgBhK/QUPmMtOIyI/1bljen7bWR6F6Cgl6bOQMEzDR417rQuPWzzAU ojCeHhHI2sOzaidIEtKHOGEZpcszPhZnNBhwo0Z29Np1LLfWCKcQ0p/WVs0WxKszmCBfwS 7yev1/5bnpySbiCb2DintGf0i8KjHObY77WBW2zRFyoxiowZuSDWygK27BH/tw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634546421; a=rsa-sha256; cv=none; b=PEDDOeBoQJP9b+r1eT3FiSpYSzm8wqlRlzOsQllxo6B5g4bFJ/tOc8CO0UsGclGZ475HZp N7K+6cGatyC44bcHQ7DNgCIIOEknCk2j3bzBp/qQ3t4QCN+awaYo3XyMUuaZehuwgmNSfJ Byy0kiPyWgBJZAIeN0WcxY1LNY+WOF08aUy3GjdbEeWS6fIJT/5tcH1GO5wma3fCFCtkVA ++XAwHnM8pnj76AHZShr3tVZ5/dVfMuc3XXyDrzJpfsi9fdgHpTLiHQXq8fNH+FyXu8afr Ig15BkiNYeI3JIURrAPPp+oc27ozvGJwVnid1N18mwh+PfCoxbFV/6R/eMv3mQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0DB3B2B7E3 X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: jmrxefZXe8px Hi! Julien Lepiller skribis: > Thanks for the reviews! I've managed to use conditions, which was not > easy because I didn't notice there was already a "condition" defined, > and that lead to weird error messages. Attached is the updated patch. Oh, I see. > From 0cadac6c3dabea8b986cd59d97c84beaf7a33325 Mon Sep 17 00:00:00 2001 > Message-Id: <0cadac6c3dabea8b986cd59d97c84beaf7a33325.1634350078.git.juli= en@lepiller.eu> > From: Julien Lepiller > Date: Fri, 8 Oct 2021 04:58:27 +0200 > Subject: [PATCH] import: opam: Do not fail when refreshing. > > Because we throw an error when a package is not in the opam repository, > the updater would crash when encountering a package that is not in opam > but uses the ocaml-build-system, such as opam itself. This catches the > error and continues without updating said package, and lets us update > the rest of the packages. > > * guix/scripts/import/opam.scm (guix-import-opam): Catch not-found > condition and leave. > * guix/import/opam.scm (&opam-not-found-error): New condition type. > (opam-fetch): Raise condition instead of leaving. > (latest-release): Catch not-found condition and warn. > (conditional): Rename from `condition'. > * tests/opam.scm (parse-conditions): Change accordingly. LGTM, thanks! Ludo=E2=80=99.