From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YAMVNzM18WFPBAEAgWs5BA (envelope-from ) for ; Wed, 26 Jan 2022 12:49:07 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ADQHLjM18WG0uwAAG6o9tA (envelope-from ) for ; Wed, 26 Jan 2022 12:49:07 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 558FA3D614 for ; Wed, 26 Jan 2022 12:49:07 +0100 (CET) Received: from localhost ([::1]:32892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCgnS-0006wA-GH for larch@yhetil.org; Wed, 26 Jan 2022 06:49:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCgnO-0006vr-2d for guix-patches@gnu.org; Wed, 26 Jan 2022 06:49:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58193) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nCgnN-0005Eq-Mc for guix-patches@gnu.org; Wed, 26 Jan 2022 06:49:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nCgnN-0004Pd-LB for guix-patches@gnu.org; Wed, 26 Jan 2022 06:49:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53523] [PATCH 2/2] gnu: Add neovim-luajit. Resent-From: Luis Henrique Gomes Higino Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 26 Jan 2022 11:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53523 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 53523@debbugs.gnu.org Received: via spool by 53523-submit@debbugs.gnu.org id=B53523.164319768516899 (code B ref 53523); Wed, 26 Jan 2022 11:49:01 +0000 Received: (at 53523) by debbugs.gnu.org; 26 Jan 2022 11:48:05 +0000 Received: from localhost ([127.0.0.1]:51096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCgmS-0004OV-NG for submit@debbugs.gnu.org; Wed, 26 Jan 2022 06:48:04 -0500 Received: from mail-vk1-f174.google.com ([209.85.221.174]:45737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCgmQ-0004Nj-Nb for 53523@debbugs.gnu.org; Wed, 26 Jan 2022 06:48:03 -0500 Received: by mail-vk1-f174.google.com with SMTP id w5so14165736vke.12 for <53523@debbugs.gnu.org>; Wed, 26 Jan 2022 03:48:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=o5EwhBVnilAqRqAWjZYev+GUyn9vIN+/VEdE1xTl45Y=; b=iwoMs10ku2uvNSYo0NjEmXoQkih+XGUuJ9DnxRRJu1MbPEbHn/HI9VvhAXCOO0LAc7 ++ZUMb+n85HquAp/DxiPWBC2GGhRsvOn231CmifP4Xo1XA/iqhbZYZ5juqN3qAMWuknf 0LaujC51PIcfVSMboed1kxviGEx194jhLOYFpR1niE6jqMYvqcaF56Xd5yPkuWWnxruy FLoQcMhnw/qdpeXGXIqRMLi7QbVDnwgQA5d/s1r46M4AtCzUVgizk4eQkCb7xeCgtud6 ySJHJtsnyOE9nBFJiK8Y1dixX3R1aomQwfghvl5NOxhNkFHad80oBdQoXzn6tiTaNpnN l0uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=o5EwhBVnilAqRqAWjZYev+GUyn9vIN+/VEdE1xTl45Y=; b=nt0W69nafxyZk5Bow1U4ViinBWkT831r289d1KV/wBY/t830u/P2XsPHR3TIemt4Kj ggDIlsvJo6zDZEHz4zNMXzyUtJDdoLpkeQJ2D3VHbq7upMHS4jIqygdWegwUqgr681Bs 6h31QrOCHZ12Squ0r3QDXI0yjJkEtycU1bFWz30pGDnGIYpsEF4G9tUx0W/DWFwlpVqd YaeIfJGOnF1QgY4z7cedWY7fs+mlULb4j867kHLxrQcqpbZun+f69JTirTncGvSi7Ct4 qL1+ND/RsrWiQPapDE4ivYSIHz5a+O+85a3inF8bgmtfU9BH6Zn7jMS1g8cSa6VX3Ji3 o4LQ== X-Gm-Message-State: AOAM530ufscmAp97I+SEoc8UGDQ9N3cOVeN8iTdfCz6Q6X3y/M8aKUxJ R84RWcZLGDvIQpEfv34w5zM1AJD6CaFJlvKq X-Google-Smtp-Source: ABdhPJyS5ojLIHzFsQR5WAxbMwrCBPt8ZKKCl7Fhssw1U04RVx97vexz1if0VClL/2H8rBDQTRKOKw== X-Received: by 2002:a05:6122:21a7:: with SMTP id j39mr4380227vkd.32.1643197676857; Wed, 26 Jan 2022 03:47:56 -0800 (PST) Received: from LenovoGuix ([2804:7f2:2785:15d6:4ff3:5510:693f:e90a]) by smtp.gmail.com with ESMTPSA id q22sm93091vsj.23.2022.01.26.03.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jan 2022 03:47:56 -0800 (PST) References: <5d93b3a5c97096e5ae10adada97ea9800d057195.1643129740.git.luishenriquegh2701@gmail.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Luis Henrique Gomes Higino Date: Wed, 26 Jan 2022 08:28:20 -0300 In-reply-to: Message-ID: <87sftapvku.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643197747; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=o5EwhBVnilAqRqAWjZYev+GUyn9vIN+/VEdE1xTl45Y=; b=Iwma3HGjAmVeTnVLDWJTJIJ6Ha0gi4eNE4O/itloJn1t/j0nJAFocCzSE9GH7wdrN6miYO 7dsQIpcmMJMVo4XX9N6WRjjaXTuHxTleIiJ511+WQe4iCA69uec9C/Thk/oIWaGE4AnqSr RERFyxUp3r88slIafopKsaFE9OJXDzt9NyhK+5NZ1J9ycOQDz1IG7sp7rYZFRZC/mkyqNQ CsSfcCUrTKwulkARcSdiM1My0tU+KiAZ6K4W5K5Y5mkDeHz+W1k9oor9AouhPjPe2cpe+l iUO9zkB82wLmAnKkeJUyaErEMKHgZAdSk2fiWXc8Kmh4vjrmraH/eZaXQajg6g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643197747; a=rsa-sha256; cv=none; b=igDIrSqSiY3EKID+MkdfPDuRRKtXiU/uhi2bH6VWSGrbt/4rGt8XuKttrLRh17bYCuu1Mg Tw3YKHGVvwRRVWHYSpRfKmILCid/unLTaTd5BOrSKMVE17hgOChrzDokARPNkk/y41xROB pozMpBryZ2oHCrgLtMBS6B6DsVaHWhqGqqMKyeAwWMn2ZhzTc8/dpPVJGLELfSnY/mDxxU xvtNXhaOw1H/u5XYHRQrKtlDXyvJk+xQywWZSca05Z5ZMir77MmQ7/uvdsxzGHQ3pZlESw R30hICvzi7eXfUS+PHncEQ6SDJnGpExVQ4elJT3/O6THkZ7KCRkNT+uvDZ328Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=iwoMs10k; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=iwoMs10k; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 558FA3D614 X-Spam-Score: -2.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: PgUQI0ZAvuE0 Maxime Devos writes: > [[PGP Signed Part:Undecided]] > Luis Henrique Gomes Higino schreef op di 25-01-2022 om 13:56 > [-0300]: >> * gnu/packages/vim.scm (neovim-luajit): New variable. >> +(define-public neovim-luajit >> + (package >> + (inherit neovim) >> + (name "neovim-luajit") >> + (inputs (modify-inputs (package-inputs neovim) >> + (replace "lua" luajit))) >> + (arguments >> + (substitute-keyword-arguments (package-arguments neovim) >> + ((#:configure-flags cf) `(delete >> "-DPREFER_LUA:BOOL=YES" >> + ,cf)))) >> + (synopsis >> + "Fork of vim focused on extensibility and agility - built >> with LuaJIT"))) > > Does this need to be a separate package? I.e., can we use > luajit > in the 'neovim' package on systems that support luajit, so not > for > powerpc)? > > Greetings, > Maxime. > > [[End of PGP Signed Part]] I initially choose a package variant because it seemed the easiest way to permit both, but I think we can choose which implementation of Lua to use based on the target's architecture and it is possibly a better solution. My only problem with it is that I'm not sure this conforms to the reproducible building mindset. If choosing a dependency based on hardware is OK for Guix, I'll configure `qemu-binfmt-service-type` and try to implement this. -- Regards, Luis H. Higino