unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: efraim@flashner.co.il, zimoun <zimon.toutoune@gmail.com>
Cc: 51319@debbugs.gnu.org, Jean-Baptiste Volatier <jbv@pm.me>
Subject: [bug#51319] [PATCH 0/2] Better interoperability between guix and Julia built-in package manager
Date: Thu, 10 Mar 2022 00:33:24 +0100	[thread overview]
Message-ID: <87sfrq1z23.fsf_-_@gnu.org> (raw)
In-Reply-To: <20211112142328.28400-1-jbv@pm.me> (Jean-Baptiste Volatier's message of "Fri, 12 Nov 2021 14:23:46 +0000")

Hello!

Efraim, zimoun: I just stumbled upon this patch series by Jean-Baptiste,
which seems to have fallen through the cracks:

  https://issues.guix.gnu.org/51319

Could you take a look and apply them if appropriate?

Thanks in advance!

Ludo’.

Jean-Baptiste Volatier <jbv@pm.me> skribis:

> On Monday, November 8th, 2021 at 8:30 AM, Efraim Flashner <efraim@flashner.co.il> wrote:
>
>> Thanks for the patch series! I'm really looking forward to this working
>> out in Guix, being able to use Julia to download as-yet unpackaged julia
>> packages will make using Julia much easier.
>
> Me too! Then we can concentrate first on the JLL packages since
> source only packages are likely to work as is.
>
> I forgot to mention that for this patch to work, the link-depot
> phase needs to be called before the source is modified.
> So in this new version, I have modified all packages that where
> modifiying the source after unpack to do it after link-depot instead.
>
>> I had to wrap this with '(when (file-exists? "Project.toml")' since we
>> do have some packages that pre-date the use of Project.toml. Building
>> julia-bufferedstreams will test both a package with and without a
>> Project.toml.
>
> I added a julia-package-uuid keyword argument like julia-package-name
> for packages without a Project.toml. I also modified the packages
> that needed it.
>
>> Here you have a '~a' to use uuid but package-dir isn't used anywhere. Is
>> package-dir not needed or is there a missing substitution?
>
> This was some left over from a previous iteration.
>
>
> Jean-Baptiste Volatier (2):
>   build-system/julia: Enable Julia Pkg to find installed packages
>   gnu: Add julia-sundials-jull
>
>  gnu/packages/julia-jll.scm        | 176 ++++++++++++++++++------------
>  gnu/packages/julia-xyz.scm        |  69 ++++++------
>  gnu/packages/julia.scm            |   2 +-
>  gnu/packages/maths.scm            |  24 ++++
>  guix/build-system/julia.scm       |   5 +-
>  guix/build/julia-build-system.scm |  49 ++++++++-
>  6 files changed, 217 insertions(+), 108 deletions(-)
>
>
> base-commit: 6e67c701a88064babd1aef93b58890aed2dcd0aa
> --
> 2.33.1




  parent reply	other threads:[~2022-03-09 23:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 13:06 [bug#51319] [PATCH 0/2] Better interoperability between guix and Julia built-in package manager Jean-Baptiste Volatier via Guix-patches via
2021-10-21 13:09 ` Jean-Baptiste Volatier via Guix-patches via
2021-10-21 13:09   ` [bug#51319] [PATCH 1/2] build-system/julia: Enable Julia Pkg to find installed packages Jean-Baptiste Volatier via Guix-patches via
2021-11-08  7:30     ` Efraim Flashner
2021-11-12 14:23       ` [bug#51319] [PATCH v2 0/2] Better interoperability between guix and Julia built-in package manager Jean-Baptiste Volatier via Guix-patches via
2021-11-12 14:23         ` [bug#51319] [PATCH v2 1/2] build-system/julia: Enable Julia Pkg to find installed packages Jean-Baptiste Volatier via Guix-patches via
2021-11-12 14:24         ` [bug#51319] [PATCH v2 2/2] gnu: Add julia-sundials-jull Jean-Baptiste Volatier via Guix-patches via
2022-03-09 23:33         ` Ludovic Courtès [this message]
2022-03-09 23:59           ` bug#51319: [PATCH 0/2] Better interoperability between guix and Julia built-in package manager zimoun
2021-10-21 13:10   ` [bug#51319] [PATCH 2/2] gnu: Add julia-sundials-jull Jean-Baptiste Volatier via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfrq1z23.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=51319@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=jbv@pm.me \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).