From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wDwNHrSeMGJuKwEAgWs5BA (envelope-from ) for ; Tue, 15 Mar 2022 15:12:04 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OAiBFrSeMGILLwAAG6o9tA (envelope-from ) for ; Tue, 15 Mar 2022 15:12:04 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E41002A3FD for ; Tue, 15 Mar 2022 15:12:03 +0100 (CET) Received: from localhost ([::1]:32932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nU7u6-000417-Le for larch@yhetil.org; Tue, 15 Mar 2022 10:12:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU2Kc-0001jZ-98 for guix-patches@gnu.org; Tue, 15 Mar 2022 04:15:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53588) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nU2Kb-0008AV-Ul for guix-patches@gnu.org; Tue, 15 Mar 2022 04:15:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nU2Kb-0005kn-Pl for guix-patches@gnu.org; Tue, 15 Mar 2022 04:15:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54337] [PATCH v2 2/3] gnu: Add boost-for-cryfs. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Mar 2022 08:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54337 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 'Brendan Tildesley Cc: Maxime Devos , 54337@debbugs.gnu.org Received: via spool by 54337-submit@debbugs.gnu.org id=B54337.164733205322041 (code B ref 54337); Tue, 15 Mar 2022 08:15:01 +0000 Received: (at 54337) by debbugs.gnu.org; 15 Mar 2022 08:14:13 +0000 Received: from localhost ([127.0.0.1]:47485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nU2Jo-0005jR-Qp for submit@debbugs.gnu.org; Tue, 15 Mar 2022 04:14:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nU2Jm-0005j6-EK for 54337@debbugs.gnu.org; Tue, 15 Mar 2022 04:14:10 -0400 Received: from [2001:470:142:3::e] (port=60740 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU2Jg-0007y2-GP; Tue, 15 Mar 2022 04:14:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=7qLiGkoI/+4pKykuIuuMDDZotmZoOldGtHpnhgg4afs=; b=r0Cw0QOIE3bCAIWWYGYa oQndwV37WvRxJcmjXLpGuBH1Gli/mHgB02NUwrq4+U6WCcY2MXP52/4MbaQ+56qb3Iqqf4FABJ6C/ 9MpgZXQcsx1gWl5eWsWShPSeDF68zB3FAdT03VDbKrHjugUogqnGkCGndAyRanigN5WcFHIymQRbV IvhOHyY0ivIq7jTMYBTF3xD662J5H2JdkvnPHvmqLRN/sNqA1Jw3PdrVQ7y73D8HPENn8P7XN88Fb 8Op1j+a/KDBaLJGg3K/6FEofko9cWb9Lrq5Mu7aR0KbS9ncHKJT/YVLvklvyQuyQxS7j4drSf3xXR 04TREXcPoOQZdQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=38530 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU2Jf-0002z4-Th; Tue, 15 Mar 2022 04:14:04 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220314093550.16580-1-mail@brendan.scot> <20220314093550.16580-2-mail@brendan.scot> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 =?UTF-8?Q?Vent=C3=B4se?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 15 Mar 2022 09:14:01 +0100 In-Reply-To: <20220314093550.16580-2-mail@brendan.scot> (Brendan Tildesley's message of "Mon, 14 Mar 2022 20:35:49 +1100") Message-ID: <87sfrjocom.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Tue, 15 Mar 2022 10:11:51 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647353523; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7qLiGkoI/+4pKykuIuuMDDZotmZoOldGtHpnhgg4afs=; b=g3lERAVnnvbLtDq5gAQB0SQB+e7lmWkM3o14hndd4i9a853VX2dxbSRa7oA9rWkpCLbJkZ uo/nXrjkqQobbDQnZEJgpp3+SzvEpA8yza2XB+4ANi+JTiY1M6DIqZVkSEF80pVArT0kPd 7BXVGDZKFs5f44CMTZIEBT3cPzeJHSfZDp8c0jz5xlo2IvvdHraCMh3e+yT3Zn5oBt/i4l AQ1yk9f5k1sl4Fvcrf8FYCSD6/uxPDEJh2G+ZW3RpnSXQzlMfcdbHKHc3U2ij7t+DZOy8I KxEQTxSD9zyhfZ2sTvpOQeiwjnj5PSlhZC61HUUfDOQr1m3XVrFvFTGGyUtk4Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647353523; a=rsa-sha256; cv=none; b=hv8sqZoeaDm6ahv1Jn83ZH/MS5mipRdUmWibR+AS4y+D527DFV1zyKQo6puKGZ8fnVjUGY Hs0WBNsy0RW7Uy8knwn6GKCAzBhaB4ODTs1nlO4AblChp0J0OGmziQ7avxQYSHiJhm1RTc 7BbDHd75Xq+b9Pma+Oz01qa43LJRh/IyphTu/llfriNiCW4Xbu8/wPhME4EvsP1AfcHuIl IwseIN/r9nCTaeTZvvvT/xpvvqurkVRX4j30ygR5zLfLrGUCGDigVhwveuwuL8vaYo9dSt 2V9AiELTIMbFlXEsyX3OisquP2svfBZTusgGAMMDzUyxq4YHrGW+xeA3TygmDQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=r0Cw0QOI; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=r0Cw0QOI; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E41002A3FD X-Spam-Score: -4.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: 8ZXgRdQdYnyE Hi, 'Brendan Tildesley skribis: > From: Brendan Tildesley > > * gnu/packages/boost.scm (boost-for-cryfs): New variable. Since > updating boost would resulting in building 1000s of rebuilds, add a > temporary variant to fixing a missing import resulting in "error: > 'transform' is not a member of 'std'" when building cryfs. See: > https://github.com/boostorg/process/commit/e08374ed95ac33865bda40602c9490= 9e7cd9607f > > * gnu/packages/patches/boost-wchar-include-algorithm.patch: New > file. > * gnu/local.mk: Reference patch. [...] > +(define-public boost-for-cryfs > + ;; This patch applies for boost 1.77. Should not be needed in later re= leases. > + ;; See: https://github.com/boostorg/process/commit/e08374ed95ac33865b= da40602c94909e7cd9607f > + (package/inherit boost > + (name "boost-for-cryfs") > + (source (origin > + (inherit (package-source boost)) > + (patches (search-patches "boost-wchar-include-algorithm.pa= tch")))))) > + > ;; Sadly, this is needed for irods. It won't link with 1.69 or later. > (define-public boost-for-irods > (package > diff --git a/gnu/packages/patches/boost-wchar-include-algorithm.patch b/g= nu/packages/patches/boost-wchar-include-algorithm.patch > new file mode 100644 > index 0000000000..c174dc5cd2 > --- /dev/null > +++ b/gnu/packages/patches/boost-wchar-include-algorithm.patch > @@ -0,0 +1,11 @@ > +--- a/boost/process/detail/traits/wchar_t.hpp > ++++ b/boost/process/detail/traits/wchar_t.hpp > +@@ -12,6 +12,8 @@ > + #include > + #include > +=20 > ++#include =E2=80=98guix lint=E2=80=99 must complain that this patch lacks a comment a= t the top. :-) Since this affect only cryfs, and since it=E2=80=99s just a missing include= , I wonder if we could instead add =E2=80=9C#include =E2=80=9D in th= e cryfs source file(s) that include(s) Boost headers? That way, we wouldn=E2=80=99t need an extra Boost build. Thoughts? Ludo=E2=80=99.