From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2DFnB328PWI0xQAAgWs5BA (envelope-from ) for ; Fri, 25 Mar 2022 13:58:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iDeSOny8PWJl7QAAG6o9tA (envelope-from ) for ; Fri, 25 Mar 2022 13:58:36 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A67F188B6 for ; Fri, 25 Mar 2022 13:58:35 +0100 (CET) Received: from localhost ([::1]:43790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXjWU-0005pH-Gm for larch@yhetil.org; Fri, 25 Mar 2022 08:58:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXjVy-0005mb-UF for guix-patches@gnu.org; Fri, 25 Mar 2022 08:58:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56566) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nXjVy-000607-6b for guix-patches@gnu.org; Fri, 25 Mar 2022 08:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nXjVy-0000lE-4Q for guix-patches@gnu.org; Fri, 25 Mar 2022 08:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53523] [PATCH v7 1/2] gnu: Add tree-sitter. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 25 Mar 2022 12:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53523 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Luis Henrique Gomes Higino Cc: 53523@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 53523@debbugs.gnu.org Received: via spool by 53523-submit@debbugs.gnu.org id=B53523.16482130312833 (code B ref 53523); Fri, 25 Mar 2022 12:58:02 +0000 Received: (at 53523) by debbugs.gnu.org; 25 Mar 2022 12:57:11 +0000 Received: from localhost ([127.0.0.1]:50459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXjV9-0000jd-00 for submit@debbugs.gnu.org; Fri, 25 Mar 2022 08:57:11 -0400 Received: from mout.gmx.net ([212.227.17.21]:53129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nXjV6-0000jO-Re for 53523@debbugs.gnu.org; Fri, 25 Mar 2022 08:57:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1648213022; bh=1hqgyFQqgcMGBc06p61wPPAnwHsiYIX9RdvnEGO067o=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=gplmkla1z6Hmq67qSN9pDQLsnFdCpb5bGFLrEwU6K5+q9tpJ1gTrNe8h+f3REGmWQ JqliDdBs+rXGYUjktEsGlduzUhA8f8OVVobyW0b0F6XbuviSzTuGSHzKVjmkSs+MI0 Hb2FojVXVANi6tsFTAAZgAaGfkHbqiB9ViP/bgqU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MryXN-1nsAHY3Tkr-00nvZW; Fri, 25 Mar 2022 13:57:01 +0100 References: <98a6180737981490316bca8c03c787289dbddcb6.1643120885.git.luishenriquegh2701@gmail.com> <1e4edd37cfd4e6724ef6b65547da01efdf023d71.1647558246.git.luishenriquegh2701@gmail.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Pierre Langlois Date: Fri, 25 Mar 2022 12:49:02 +0000 In-reply-to: <1e4edd37cfd4e6724ef6b65547da01efdf023d71.1647558246.git.luishenriquegh2701@gmail.com> Message-ID: <87sfr66vhg.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:PcMNdrHNB5sQA4uMPXyAhZ6Egyf51cPQKrj22iJrUoiYQFYhEkL FOmd3jZaBrKNTJJ2ATfUvxNlK0xufnx2ADdyar3KVmbypAdDbcQhgvTOBi7qqZQW02MPG+G 9rp2ML8LB6seFblSpwP2nSD0ip2IL4UdO5m3cGwYk37qPeUUjpE55oydezruXbnma2YSoQ1 +jMD8lvRUOCKCOApvQFFQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:H3vSrJYhBjg=:+cZEHrcNAHlIw0fG7Vouve ewbdEo60BOsqq34lf5N336SnG34ZBRUrIry3hyvz7iGWIOa4AptaPZw/NHLvlmcSe3uyKYmy4 RYuvaYM8MbhpbUVzwxAxwEouHqeNhhHiyfoY0gXhqcW1OAu90yvdOx3dgiXwXafON3+6mnn8r Hh3x/s+g8buMA+NRY+8s0dZLvshrb5xSbeVcw0lNNBJNeMM/mRnfOZBz+Z76BJGo8R8TyY9/h 3RqMP0Eo9Gh8yWvHpq2qxxsQgSwnJMpeT0+bDHsPMYt7+vf0I7HZc1qPr/cyUYjeH7E+fvDgj Z5NMJAj2pPl1Y67m7yZLJpR2H+uNgpmFhSj+pO6K79RXq8UuDAmdLcpMLAIW1XQOQNNan6Byh cRYQpJYH4fDwu0P10gVDhUeNfwwFngDLBkscJ3veJy3FnUBRgU0lZBw8tYOs6ztpzGND7TRhS vXo9g2ZD8MTZ0HPQyT0Cwh1BaCG6sQed66F5zSTx05+vaQKDZaJ9oMyFQACMfl25pTfsZu+iU 3csol/rP8Nh+RRdN4+YQhMj6i2qbo+aOjjtTzGs1IIZ/ELdB8p7PiAGbCErC2eHddk6EQhCgY cQlDxoUdPR06evzqgwqIvc2WL5PhokuiO/25IeZYYJNWyRjury4FCBPsyqHHsAOA5rArlEAUz 6btkicTuLn7Q2UsiO3b3g5asI0LTR5l/O6LfR251QgnWIHPF6tx5JGxmvKSaCHjskazATUtui 3xuAasLh65/k6R9cO7VZlTdRtMzZbs4cu0m7vuuuUSAaiJ4PeG8bvUn23Y4k6u6NsPqSh2Qzy 859fs5WGawZi2Bb6uumn+wj75VNXfbUZKppTrwUA0bxxxfMT5SB6eNrJKZRdBNwYe3hQUnxtx RKn+vTG/S9HmsJVvUAM9wzP6iiLkmouh+q4+tuj3dbSYQc3XYufU31B/VJefgKMNiEPm5GOtB E1j+zNS7TpEBGb+xmq1OFvgn1eBejhzTF41HuQe1qtbY4ApOh5PUjwhq1O2i2ugM4O5BqkN+Y mCgbbKSoqmUHf4WlD45yZXWQNYaCro5NXkmaUTUkDxZOOX6a6yCRMmNRKS34TLN/JNBu6Oa/I oldIx51Cs4C1Gs= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648213115; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=h1oFTYVw2MtWpmCC6CjwBFFUXDc5pxRj44Iq7ev/OwI=; b=kIW6slzQFfrARfo+zlzgB6spMgVMqcJmfhMd1wWQ8V+cjRuVuKUVFBKmckj2C7QoOG9T2D ndGj7jJJE+Ub8qd0IlaogiEgYB/5II5Rtpss6B8dn9Ab7TIkUJIcF3SvpFFPcSI6owf4SZ nznqkxjYHTdc0vpANYx1mUPyJoTrWb5GC7CYBW8bd8ypdSLmGMwDCOWzlPe/rph7cVNO38 XAma0qRDCtnr6r7prj1Z+3IKihoQNH0rtOEJMVnDoRBzwb+JisWd3iIk+v7E7/7D49kRmW 7OJsaWFJnoRpPRc9GFyG+uPeh9WXTtIUDbEdS3ssspcmFOD0Rq1lYhydLjr1YQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648213115; a=rsa-sha256; cv=none; b=R2M5mIZTdyq2UfmteqQvqxTL1dyxpNLe6Y5hsYljs0QwsFiFb7ARNBT3SILuYy3xuw62YH VVLe0YsRWs9KwWk/tOIByiSFJo2mXHnKOKBCm0rYCc19bxQ6ftu+/jxP+KgsdFLt45qY/a 6ImIkIgz3+y0eS3p71e2F7LGLT8G913uOtP/jZ2q6hwnoZaAvAQtffKbK4n/QmBIbiSr6w b72YH3qLGCamOKCw+sCeAuPF/jmwr7iIxOcOoekhHDkyxe2fsMjMthrHes8OpEjeSeROIX OC8XEHW61C51s+7p92bdgqhcfC2I+IxLlqzL8VZeJl8kcEwiGCqQUkzcqQ7hRA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=gplmkla1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.11 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmx.net header.s=badeba3b8450 header.b=gplmkla1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmx.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8A67F188B6 X-Spam-Score: 3.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: R14QtYifCgB2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! > * gnu/packages/text-editors.scm (tree-sitter): New variable. I applied the patch locally and tested it, just one small nit otherwise LGTM.=20=20 Tested-by: Pierre Langlois Reviewed-by: Pierre Langlois Luis Henrique Gomes Higino writes: > --- > gnu/packages/text-editors.scm | 54 +++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm > index 45cc61765a..d6ec000dc6 100644 > --- a/gnu/packages/text-editors.scm > +++ b/gnu/packages/text-editors.scm > @@ -17,6 +17,7 @@ > ;;; Copyright =C2=A9 2021 Leo Famulari > ;;; Copyright =C2=A9 2021 Pierre Langlois > ;;; Copyright =C2=A9 2021 Calum Irwin > +;;; Copyright =C2=A9 2022 Luis Henrique Gomes Higino > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -39,6 +40,7 @@ (define-module (gnu packages text-editors) > #:use-module (guix gexp) > #:use-module (guix git-download) > #:use-module (guix utils) > + #:use-module (guix build utils) I don't think you need this import right? You'll have probably noticed a warning: WARNING: (gnu packages text-editors): `which' imported from both (guix bu= ild utils) and (gnu packages base) =20=20 When this happens we can resolve the conflict with a prefix, so we can have the `which' procedure and the `base::which' package. #:use-module ((gnu packages base) #:prefix base:) =20=20 In this case though we just don't need the import at all though I think. Thanks! Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmI9vBsYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31Ua/AH/0xSp1o4SV278YRMOvXhkcj9 2Hqg8k4EYpH5E0ceLiB/wm9BtLCMwHFVdDr9pzP8OjM0JxOmG/jyhkwnT8EQjQif VR7qu04Km7gnG5KGrC3VGj1YR7yT4VqE5z8VattyH05v2HBSDEZlmrx39ZR1KzzT aHmr/5B0u+7Pl0/wLk3Y5YXDoiW7kP200ea61s+Lq1MwSl61oPAxTUGKSGWmjCHm VrXt0NqlcagiV4tPUCBJYzGd7c5+7Iz/C04c79xyOo3V8Oz5b9Bftz6V1xn//rJW ynLVOR6wyhhyXBUU4gi1mOWPAI1TTWJNmHg6gvxFb+eKDlaz24Hd7i90HrLfK14= =GQ7v -----END PGP SIGNATURE----- --=-=-=--