From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kHKbDD9cUGLh2gAAgWs5BA (envelope-from ) for ; Fri, 08 Apr 2022 18:01:03 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wLMJCj9cUGK+dwEA9RJhRA (envelope-from ) for ; Fri, 08 Apr 2022 18:01:03 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C532C2B3AB for ; Fri, 8 Apr 2022 18:01:02 +0200 (CEST) Received: from localhost ([::1]:58082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncr2j-00040n-BY for larch@yhetil.org; Fri, 08 Apr 2022 12:01:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncr1n-0003zn-Ju for guix-patches@gnu.org; Fri, 08 Apr 2022 12:00:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ncr1n-00041o-A3 for guix-patches@gnu.org; Fri, 08 Apr 2022 12:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ncr1n-0008D2-5G for guix-patches@gnu.org; Fri, 08 Apr 2022 12:00:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54780] [PATCH] gnu: lttng-ust: Fix dependencies. Resent-From: Olivier Dion Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Apr 2022 16:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54780 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 54780@debbugs.gnu.org Received: via spool by 54780-submit@debbugs.gnu.org id=B54780.164943359131507 (code B ref 54780); Fri, 08 Apr 2022 16:00:03 +0000 Received: (at 54780) by debbugs.gnu.org; 8 Apr 2022 15:59:51 +0000 Received: from localhost ([127.0.0.1]:35683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncr1b-0008C6-4L for submit@debbugs.gnu.org; Fri, 08 Apr 2022 11:59:51 -0400 Received: from smtp.polymtl.ca ([132.207.4.11]:35130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncr1Z-0008Bs-Fo for 54780@debbugs.gnu.org; Fri, 08 Apr 2022 11:59:50 -0400 Received: from localhost (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 238FxcbF026236 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 Apr 2022 11:59:43 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 238FxcbF026236 In-Reply-To: <7a376302aab455dae361205a491a4e5fd5bd5922.camel@telenet.be> References: <3afb4ed9e9446906504f781dcf047160491ddfff.1649377087.git.olivier.dion@polymtl.ca> <871qy7wt52.fsf@laura> <87v8vjvecz.fsf@laura> <7a376302aab455dae361205a491a4e5fd5bd5922.camel@telenet.be> Date: Fri, 08 Apr 2022 11:59:38 -0400 Message-ID: <87sfqnva51.fsf@laura> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Poly-FromMTA: (modemcable094.169-200-24.mc.videotron.ca [24.200.169.94]) at Fri, 8 Apr 2022 15:59:38 +0000 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Olivier Dion X-ACL-Warn: , Olivier Dion via Guix-patches From: Olivier Dion via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649433663; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=NzwuzOdeyI9ENt7rTYzpw4twm7mBxPLdesHfDOjX6vg=; b=LpJ9JMii6ORJQBr1J5bwpPg6nGrJpL+F1ogKILD0egkhNYnjAUAfZAHLIpsfYW5aSufBI2 y0Tql7dt61+5Coh+77w1LV/oq5aWArYHo3WdmUhRFnVtxzRaxe+k7x0kPKVgccTZzmhsy1 usWweFxcK8YYn39qOblqz6/aEYf6vk1u7BUw3Gabqj8oauJO8aJNkC5mVmM4HMpPoUYC+D k7lz/ULzfJXBtWKpAEKrXXp6lS7z1hJ56e4Vpus5xcn32F9pEG9Tz1mGRHzne0Y3hlJCnh 4xqEL9udOUMyUoxFMoXfNU2hmTXcjn3mkLxawil59HEjZD7AWXmhdFnvEnlCxA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649433663; a=rsa-sha256; cv=none; b=a5KxrjNSEtzVHSB2why+lMgZywlaPtkIBHF3U867+7VMF3kEyMZ/dl4V2gta7y0BW7vIET k4guIXP2S0AkMyFcXB9EhNMkfp87o0gb9uo9w9oRLYTajZmhVAQlnkktYoX44DlgrbRtjW wK0rD+N+fzmyZXhJyrLO9vTTuEZyfECPxNaYB65HDSmFQ/vZ7SCfJk4neMPXnhv7ABzMOZ MvXHI37WVym3RUukdE60eNwXABJNHbqFAysh8sjh5tKyLUXmqBAKeG+bG84/xkCz3vJKVa eGmH4t9Y/o+HxSwbCoj/MPudsOi+YCkacpDi69afmND44E/S+zBIQXVXBeduVw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.27 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C532C2B3AB X-Spam-Score: -3.27 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZgZ6Nr8HXyFr On Fri, 08 Apr 2022, Maxime Devos wrote: > Olivier Dion schreef op vr 08-04-2022 om 10:28 [-0400]: >> =C2=A0and don't fully understand it. > > lttn-ust probably has some header > /gnu/store/...-lttng-unst-VERSION/include/lttng.h or the like. > It would look something like: > > [...] > #include > int lttng_foo(urcu_stuff *bar); > [..] > > Then the 'patch-header-inclusion' phase detects the #include > , looks for include/liburcu.h in the package inputs, and > finds /gnu/store/...-liburcu-VERSION/include/liburcu.h. It then > replaces liburcu.h by /gnu/store/...-liburcu-VERSION/include/liburcu.h: > > [...] > #include > int lttng_foo(urcu_stuff *bar); > [...] > > Now, suppose I build an application dependning on lttng-ust. Then the > C compiler will =E2=80=98include=E2=80=99 'lttng.h' in the {CROSS_,}C_INL= UDE_PATH.=20 > Then it sees: > > #include > > Now, as this is an absolute /gnu/store/... file name, the compiler > knows where to find it without looking into {CROSS_,}C_INCLUDE_PATH, so > it will find the header even though it might not be in > {CROSS_,}C_INCLUDE_PATH. > > It's the same system as doing some 'substitute*' to bake in the > absolute file name of some executable into the compiled application to > avoid relying on PATH, except applied to C headers instead of > executables and {CROSS_,}C_CINCLUDE_PATH instead of PATH. Okay cool! Thanks for the details. I will change my patch with your substitute. --=20 Olivier Dion oldiob.dev