From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: "Ludovic Courtès" <ludo@gnu.org>,
"GNU Debbugs" <control@debbugs.gnu.org>,
46182@debbugs.gnu.org
Subject: [bug#46182] [PATCH] lint: Add 'check-git-protocol' checker.
Date: Sun, 22 May 2022 00:15:21 -0400 [thread overview]
Message-ID: <87sfp26w4m.fsf_-_@gmail.com> (raw)
In-Reply-To: <87zgz9uxwu.fsf@gnu.org> ("Ludovic Courtès"'s message of "Thu, 11 Mar 2021 23:29:37 +0100")
tags 46182 +moreinfo
thanks
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!
>
> Leo Famulari <leo@famulari.name> skribis:
>
>> We could also make it warn about use of the HTTP protocol (as opposed to
>> HTTPS). Your thoughts?
>>
>> * guix/lint.scm (check-git-protocol): New procedure.
>> (%local-checkers): Add 'git-protocol' checker.
>> * doc/guix.texi (Invoking guix lint): Document it.
>
> Nice! I think it’s OK to use ‘eqv?’ here (‘eq?’, even).
>
> One nit: it would be nice to add a positive and a negative test in
> tests/lint.scm. You can run “make check TESTS=tests/lint.scm” then.
>
> Otherwise LGTM!
Gentle ping to Leo :-).
It looks near ready.
Thank you!
Maxim
prev parent reply other threads:[~2022-05-22 4:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 1:04 [bug#46182] [PATCH] lint: Add 'check-git-protocol' checker Leo Famulari
2021-03-11 0:14 ` zimoun
2021-03-11 1:46 ` Leo Famulari
2021-03-11 9:44 ` zimoun
2023-10-20 2:22 ` Maxim Cournoyer
2023-10-20 12:45 ` Simon Tournier
2023-10-20 15:37 ` Maxim Cournoyer
2021-03-11 22:29 ` Ludovic Courtès
2022-05-22 4:15 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfp26w4m.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=46182@debbugs.gnu.org \
--cc=control@debbugs.gnu.org \
--cc=leo@famulari.name \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).