From: "Ludovic Courtès" <ludo@gnu.org>
To: kuba@kadziolka.net, Efraim Flashner <efraim@flashner.co.il>
Cc: Ricardo Wurmus <rekado@elephly.net>, 54910@debbugs.gnu.org
Subject: [bug#54910] [PATCH] guix: import: Convert inputs to the new format.
Date: Mon, 23 May 2022 15:37:13 +0200 [thread overview]
Message-ID: <87sfp05q0m.fsf_-_@gnu.org> (raw)
In-Reply-To: <87r160vtjy.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 14 Apr 2022 12:33:43 +0200")
Hey Efraim & Jakub,
Ricardo Wurmus <rekado@elephly.net> skribis:
> Thanks for the patch!
>
> This looked good to me, so I applied it locally. I then ran the test
> suite and noticed that tests/go.scm and tests/crate.scm have failing
> tests.
>
> The failure in tests/go.scm is harmless and can easily be fixed. But
> the failure in tests/crate.scm indicates a real problem, I think. The
> build system expects that inputs are placed in the #:cargo-inputs field
> in (arguments …), and this seems to expect old-style labelled inputs.
>
> I don’t know if the build system would work with the new-style plain
> lists in the arguments field, so I’m Cc-ing contributors to the build
> system.
>
> @Jakub and @Efraim: could you please comment on this?
A friendly ping. :-)
I think it’s important to make sure the current Rust packaging strategy
does not “hold us back”.
Thanks,
Ludo’.
prev parent reply other threads:[~2022-05-23 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 12:30 [bug#54910] [PATCH] guix: import: Convert inputs to the new format Attila Lendvai
2022-04-14 10:33 ` Ricardo Wurmus
2022-05-23 13:37 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfp05q0m.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=54910@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=kuba@kadziolka.net \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).