From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cIzbNsBs1mJxIAEAbAwnHQ (envelope-from ) for ; Tue, 19 Jul 2022 10:35:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MIvWNsBs1mKz8AAA9RJhRA (envelope-from ) for ; Tue, 19 Jul 2022 10:35:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B9F4020849 for ; Tue, 19 Jul 2022 10:35:12 +0200 (CEST) Received: from localhost ([::1]:43888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDihD-0004w6-PY for larch@yhetil.org; Tue, 19 Jul 2022 04:35:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDih4-0004vB-28 for guix-patches@gnu.org; Tue, 19 Jul 2022 04:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDih3-0008Jx-Pp for guix-patches@gnu.org; Tue, 19 Jul 2022 04:35:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDih3-0000df-Lt for guix-patches@gnu.org; Tue, 19 Jul 2022 04:35:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Jul 2022 08:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51427 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 51427@debbugs.gnu.org, Maxim Cournoyer , zimoun Received: via spool by 51427-submit@debbugs.gnu.org id=B51427.16582196822426 (code B ref 51427); Tue, 19 Jul 2022 08:35:01 +0000 Received: (at 51427) by debbugs.gnu.org; 19 Jul 2022 08:34:42 +0000 Received: from localhost ([127.0.0.1]:52760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDigk-0000d3-9s for submit@debbugs.gnu.org; Tue, 19 Jul 2022 04:34:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDigi-0000cr-Pv for 51427@debbugs.gnu.org; Tue, 19 Jul 2022 04:34:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60072) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDigd-0008IN-GA; Tue, 19 Jul 2022 04:34:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ShdcWf6k2+ajdsyZbkaTC4r3oCuahS6eFR234UdLv4s=; b=TVfIZ9PMBuLAUouZ7LyF B1leaGllxzg7NH5sO5JTEaVV+Fly6lPeazzYnFDnyzuCrFZU3X6XEGmilNub+NGvpjzLdQ9rlsj1Z 3zAL9/3L1RH14LYy2KpGxgQ2+aP9lpO6dZUhJ5B4OBRcP0QUqIn5p9DEO6MhOtPSQeOENCenk+ZJ0 nwBNdIOIc5eWIq01NPaW00DNTL/3L+2rt9bAeoJCjsDgRvfC3iMebt2ob2F93OhkW4i6Jw/MWydh7 1JeP4iBs2xTTpwyZJ3LQ+XIZqisDKRNklpKA78GaNFVmM3/bYIWhveh3fJ7kbULwJf/qOFNsy7gqY bvVbE0YtINXPnQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=52028 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDigd-0006Ui-2r; Tue, 19 Jul 2022 04:34:35 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20211027034918.4591-1-maxim.cournoyer@gmail.com> <87o8795j61.fsf@gnu.org> <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@gmail.com> <87h7cxp9tl.fsf@gnu.org> <87sfwg7w9z.fsf@gmail.com> <87ee7tmdbd.fsf@gnu.org> <86k0hhnqss.fsf@gmail.com> <871r3f2j7y.fsf@gnu.org> <867dd7roi2.fsf@gmail.com> <87o7xmy14l.fsf_-_@gnu.org> <2441c768fea8faee800947a17aef896c35173845.camel@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Primidi 1 Thermidor an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de =?UTF-8?Q?l'=C3=89pautre?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 19 Jul 2022 10:34:33 +0200 In-Reply-To: <2441c768fea8faee800947a17aef896c35173845.camel@gmail.com> (Liliana Marie Prikler's message of "Mon, 18 Jul 2022 19:03:30 +0200") Message-ID: <87sfmxv6ue.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658219712; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ShdcWf6k2+ajdsyZbkaTC4r3oCuahS6eFR234UdLv4s=; b=kpqnEmCVD/B7rmzCzk274OQn3YBGzKncsW+2gJhE1WS564Mch6cHioOJfnb4ZH+XkN2/BS l0evSZfuJiBIjxBTwYPh9dz7Ldbf2WZVIz+/wkpPEGJ2rCS4qB6wvKFgCT0xVF9LBu2Tmr TZXOKpwwFOQ6r4Mryc1kTdvvigSdfZCU5b8zD1mRrjz8FQfVBDM2S3rQqp2JdGM2o/FkAP Vb4w6Rmpmdxe4VFmICOVlOGfghaHe6gyYwcRGbe34YpwyzOsMQWGFpf/0FKpwmsccx0DS5 +UYu9XCuiwc5kp8jLRCfCyfPqGqfh9qgmvZDqZ2SXpwoqVNKJXQe9D9Q5+//XQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658219712; a=rsa-sha256; cv=none; b=LZ7Qagh/qYNxs4ZNPWSp7vcIvbpbtcMLnuJZFYXMiAyg97aXe9f8lV4AEGdrdhBHjop3sT LwgPypggRvqP4xTcVO15vAk1z8HQ/TkIsb636JbnLcMEfJEuWOPDutHy16Mw0tY470+xXH G+EzddTosHVZcVM2tT0H2AHAowrUQGVhr48OeOKLRzNWmVbuequSYn3hox9OruXigdjdYh 9AEvDcrKQTbmyLQAQeOFJFt694QpiFPR50UPOQGpWEuDxSTl54pwFP9fowz4SE3Wuc4LNE bVhHxMJwV4L+ZtlEhaVdxNIAjPKK/CLoHcMadBsX1e0KVBqABEuictScn14ljA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=TVfIZ9PM; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.23 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=TVfIZ9PM; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B9F4020849 X-Spam-Score: -3.23 X-Migadu-Scanner: scn0.migadu.com X-TUID: gAiQzIHWKn0n Hi, Liliana Marie Prikler skribis: > Am Montag, dem 18.07.2022 um 15:57 +0200 schrieb Ludovic Court=C3=A8s: >> Hello, >>=20 >> With commit 472a0e82a52a3d5d841e1dfad6b13e26082a5750 (Nov. 2021), >> partially fixing , there is >> hopefully less pressure to skip the remove-unused-links phase. >>=20 >> Should we close this issue? > As a hard disk user, I'm leaning towards "no". At the REPL, could you do: ,use(ice-9 ftw) ,t (length (scandir "/gnu/store/.links")) ? On my SSD I get: $4 =3D 438356 ;; 24.613712s real time, 10.195698s run time. 1.805636s spent in GC. This =E2=80=98scandir=E2=80=99 call is a good approximation of the cost of = the remove-unused-links phase. Ludo=E2=80=99.