unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
Cc: Nicolas Graves <ngraves@ngraves.fr>, 57426-done@debbugs.gnu.org
Subject: bug#57426: [PATCH] gnu: Add emacs-consult-org-roam.
Date: Sat, 27 Aug 2022 10:18:54 +0200	[thread overview]
Message-ID: <87sflip09d.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87zgfr5eb2.fsf@ngraves.fr> (Nicolas Graves via Guix-patches via's message of "Fri, 26 Aug 2022 15:23:29 +0200")

Hello,

Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-consult-org-roam): New variable.

Applied with the changes below. Thank you.

> +(define-public emacs-consult-org-roam
> +  (let* ((commit "9b51aed939054c54934a6969290ad78587051cde")

I used latest commit instead.

> +         (revision "0"))
> +    (package
> +      (name "emacs-consult-org-roam")
> +      (version (git-version "0" revision commit))

Base version is "0.1" according to "Version:" keyword.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/jgru/consult-org-roam.git")

I removed the ".git" suffix from URL.

> +      (propagated-inputs (list emacs-org-roam emacs-consult))

I sorted inputs alphabetically.

> +      (description
> +       "This is a set of functions to use org-roam with consult.  This
> +packages replaces org-roam's own completing read functions with equivalent
> +versions utilizing consult's internal API.  By doing so, one gains all
> +advantages of consult which enhances Emacs' own completing-read
> +funcionality.")

I removed last sentence, which didn't seem useful in a description.
Also, I used capitalization for project's names (e.g., Consult).

> +      (license license:gpl3))))

License is actually GPL3+.

Regards,
-- 
Nicolas Goaziou




      reply	other threads:[~2022-08-27  8:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26 13:23 [bug#57426] [PATCH] gnu: Add emacs-consult-org-roam Nicolas Graves via Guix-patches via
2022-08-27  8:18 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sflip09d.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=57426-done@debbugs.gnu.org \
    --cc=guix-patches@gnu.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).