From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MKLFEvlPJGPwfQAAbAwnHQ (envelope-from ) for ; Fri, 16 Sep 2022 12:29:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4HSsEvlPJGNTagEAauVa8A (envelope-from ) for ; Fri, 16 Sep 2022 12:29:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA9513D0BE for ; Fri, 16 Sep 2022 12:29:12 +0200 (CEST) Received: from localhost ([::1]:36986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZ8as-0003gA-Vy for larch@yhetil.org; Fri, 16 Sep 2022 06:29:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ8ak-0003g0-Sr for guix-patches@gnu.org; Fri, 16 Sep 2022 06:29:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42721) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZ8ak-0000nZ-Em for guix-patches@gnu.org; Fri, 16 Sep 2022 06:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZ8aj-0006QU-U9 for guix-patches@gnu.org; Fri, 16 Sep 2022 06:29:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57756] [PATCH 2/2] * gnu/packages/wm.scm: Add sbcl-stumpwm-notify Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Sep 2022 10:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57756 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Trev Cc: 57756@debbugs.gnu.org Received: via spool by 57756-submit@debbugs.gnu.org id=B57756.166332408324634 (code B ref 57756); Fri, 16 Sep 2022 10:29:01 +0000 Received: (at 57756) by debbugs.gnu.org; 16 Sep 2022 10:28:03 +0000 Received: from localhost ([127.0.0.1]:41799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ8Zn-0006PG-BD for submit@debbugs.gnu.org; Fri, 16 Sep 2022 06:28:03 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ8Zl-0006Or-Ik for 57756@debbugs.gnu.org; Fri, 16 Sep 2022 06:28:02 -0400 Received: from localhost (unknown [134.157.22.165]) by mira.cbaines.net (Postfix) with ESMTPSA id CD70827BBE9; Fri, 16 Sep 2022 11:27:59 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id eb1d5826; Fri, 16 Sep 2022 10:27:58 +0000 (UTC) References: <87r10e8jwt.fsf@cbaines.net> <871qsddiof.fsf@codinator.mail-host-address-is-not-set> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines Date: Fri, 16 Sep 2022 12:25:37 +0200 In-reply-to: <871qsddiof.fsf@codinator.mail-host-address-is-not-set> Message-ID: <87sfkrsjf8.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663324153; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=SIz5icZWOIpL1vUubNZEzdrbxCBcsZ/vk6nYzz5+8Cc=; b=Z1uhUmL5SqQHWtNe59ph49rk1exR2nb1Gd7nGQ5Y0LYlYNHV50lVipCv0zmFJV2f1fDyNQ EbXKRVKLQP3r4ltd4626XSZptVIEq4bnNLI78OPT9NJ35868yFeu/9n8KvXhUIckr26KNw H0L5QSKz+L8jnpbOKTQ3GGVaGxjNkSH5hRjcst14Jv9k5zecHWe6+ufKH8qZ2PU3lWCiRC 18RgBwJcMfmscgZqz/FHr1lE4SFQZAt0a3AoOvty7FZM+5Xgya9a2EMH0O/NAm2XCMDIuk 4VDRh15JL07kkf8HcJosyY58vYy3wGaBiCJc8dKyB0EKg8oEFc2f/tvVTyfrkA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663324153; a=rsa-sha256; cv=none; b=QOD+fMWrzQIthV3eVkb2qXRyVJ88UxFs9VDvV2OsHPqpwYxpg2LziR3gtE59TJUHyycwoc vfjUkAyCBYnGlnWi8SXUvYz7s9/DIzc06KWjhX9gn8LJaSAJ5XFcNOP7WxpUyUtnnuZzff uEwbeUOFxFtWNkKc7tUon7yNXBF2hcFY8hqO9xSjebw4NW/Rl79n9jlZZ9xrBrdmfrvqlo 0/MXrIcFT3nNtffM+VVCM1Gb0nwOeyrRTBlq/mGlkxeKGt6IDRES2WszNvp3mQ/5EXdF/6 Hlg7r2PHsXoNTTcCeIDn7C5jLkKVV/fqQgrVn7NFoZtxVaTcZLSZ7ma5162++A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DA9513D0BE X-Spam-Score: -3.43 X-Migadu-Scanner: scn1.migadu.com X-TUID: puYN559cQ+Et --=-=-= Content-Type: text/plain Trev writes: > Christopher Baines writes: > >>> --- >>> gnu/packages/wm.scm | 24 ++++++++++++++++++++++++ >>> 1 file changed, 24 insertions(+) >> >> Hi Trevor, >> >> The commit message for adding a package like this one would generally >> look like: >> >> gnu: Add sbcl-stumpwm-notify. >> >> * gnu/packages/wm.scm (sbcl-stumpwm-notify): New variable. >> >> >> You're mostly there. >> > > Thank you for this feedback! I had been following the guidelines > described in the documentation: > > https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html > > It states to write patches in the "changelog" format described here: > > https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs > > Is there documentation somewhere that might help me adapt my strategy > for future contributions? I do prefer the tighter format you're asking > for :) I'm no expert on the changelog format, but I think you were just missing the descriptive first line of the commit. Looking at how other commits are written is the only recommendation I can give for writing commit messages. Also don't worry about it too much :) Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmMkT6tfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xc5rhAAugaf4WrBFZ07+6GsGCjTlSMJprV5v5gy 6qM3OlIvftL8C/mxl9kM+ReA432bGQdRE5yRKIgAKvS6WrNVcO+0mLwGsHwy9Oea mLefo1x9gRE6E+RyONUMgyjgEbNrzBvYvnornRjwZyl7SHb6kWQRIV+hhf8oybtQ v/Hr/hIL8rW8Up34wHaG2HW/ddM5TvdMeN3s68Y3X/21bkEyPawdA/He7f5t1/qW Nm/+j6ezd1BoxhLEnllFcLK7U+zLFHgAJou/OxRpICXATRtRQRyopQW3WjYMiA5V /Ct/1Nj1mbEcvaAP+WhMwTM14aMw4YVFIe0xmi00W2+hijD5hgZzD+ZV4qj1wM4k gHRUsALn6p8JlD0eUvH+NORq7w2x/ectxQ1kZY5b3CrCtyieYJ7m/P1MYnL0jARl M/dqA9aYujev3zxu9foNURVYdqMjLeeJIc8/3csuNfhKlFVQ4oB7y675/CinPZ4+ 4M3Qd98OV2t7Dl1QPQ0zn09YRAdDsuZCfXyLSEFNXCieG/DkomOo8cZJbNRKuGDC 3AUAKxu12FiQ+mHJ39Xj9LQMdkaMSpthNtlqfWeCSE708E9gXPXPMO4VfuUYAa+0 /KCVHUJXzTLb/BXGPS5wKVg1nVhXCdZDjVvok3yDyYp79/FbvG3bWEuEZOehr1yG rosxLnKJAng= =Z0n+ -----END PGP SIGNATURE----- --=-=-=--