unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Fredrik Salomonsson <plattfot@posteo.net>
To: Maxime Devos <maximedevos@telenet.be>,
	Nicolas Graves <ngraves@ngraves.fr>,
	Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 57891-done@debbugs.gnu.org
Subject: [bug#57891] [PATCH 1/1] gnu: Add emacs-org-roam-ui.
Date: Sun, 18 Sep 2022 23:24:23 +0000	[thread overview]
Message-ID: <87sfkow9js.fsf@posteo.net> (raw)
In-Reply-To: <b82f7831-9d31-18da-5cef-6dedb1be713c@telenet.be>

Maxime Devos <maximedevos@telenet.be> writes:

> On 18-09-2022 19:43, Fredrik Salomonsson wrote:
>> Nicolas Graves<ngraves@ngraves.fr>  writes:
>> 
>>> IIRC, there's an issue with packaging guidelines because the package
>>> contains minified js.
>>>
>>> I'm not sure that's possible, but we could try to re-generate those
>>> minified js files in a sub-package or something like that.
>>>
>> I couldn't find anything about this in the guidelines.
>
> Some relevant parts (mostly, it boils down to 'minified js' not counting 
> as source code, but binaries):
>
>   * (guix)Introduction:
>
>     [...] Guix makes it easy [...] to build packages from source, [...]
>
>   * (guix)Binary Installation
>
>     Note: If you do not enable substitutes, Guix will end up
>     building _everything_ from source on your machine,
>
>   * (guix)Features
>
>     When a pre-built binary for a ‘/gnu/store’ item is
>     available from an external source—a “substitute”, Guix just downloads
>     it and unpacks it; otherwise, it builds the package from source,
>
>   * (guix)Additional Build Options
>
>     Fetch and return the source of PACKAGE-OR-DERIVATION [...]
>
>   * (guix) Snippets versus Phases
>     Origin snippets are typically used to remove unwanted files such as
>     bundled libraries, [...]
>
>
>   * (guix)Submitting Patches
>
>    8. Make sure the package does not use bundled copies of software
>       already available as separate packages.
>
>       Sometimes, packages include copies of the source code of their
>       dependencies as a convenience for users.  However, as a
>       distribution, we want to make sure that such packages end up using
>       the copy we already have in the distribution, if there is one.
>       This [...], and allows the distribution to make transverse changes
>       such as applying security updates for a given software package in a
>       single place and have them affect the whole system—something that
>       bundled copies prevent.
>
>    ‘Minified JS that we don't know how to rebuild’ doesn't mesh well with
>    such 'transverse changes' and "guix build --source will return the
>    source code".

Ah, I didn't realize minified JS was generated and should be classified
as binaries. Or even that minified JS existed before it was pointed out
to me in this thread. It makes sense now though, thank you for clearing
that up.

Then I think it is probably best that this package gets removed from
guix, until it can be packaged properly.

-- 
s/Fred[re]+i[ck]+/Fredrik/g




  reply	other threads:[~2022-09-18 23:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-17 22:35 [bug#57891] [PATCH 0/1] Add emacs-org-roam-ui Fredrik Salomonsson
2022-09-17 22:41 ` [bug#57891] [PATCH 1/1] gnu: " Fredrik Salomonsson
2022-09-18  9:29   ` bug#57891: " Nicolas Goaziou
2022-09-18 16:16     ` [bug#57891] " Nicolas Graves via Guix-patches via
2022-09-18 17:43       ` Fredrik Salomonsson
2022-09-18 19:09         ` Maxime Devos
2022-09-18 23:24           ` Fredrik Salomonsson [this message]
2022-09-19 10:24             ` Nicolas Goaziou
2022-09-19 18:07               ` Fredrik Salomonsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfkow9js.fsf@posteo.net \
    --to=plattfot@posteo.net \
    --cc=57891-done@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=maximedevos@telenet.be \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).