From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: pinoaffe <pinoaffe@gmail.com>
Cc: 57171-done@debbugs.gnu.org
Subject: bug#57171: [PATCH v2] gnu: Add emacs-pdfgrep.
Date: Tue, 20 Sep 2022 21:38:47 +0200 [thread overview]
Message-ID: <87sfklx2d4.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <878rmf2kq3.fsf@gmail.com> (pinoaffe@gmail.com's message of "Mon, 19 Sep 2022 22:05:40 +0200")
Hello,
pinoaffe <pinoaffe@gmail.com> writes:
> Date: Sat, 13 Aug 2022 13:59:20 +0200
> From 28d500390c6eee5e89b9fb3c756300751b8af598 Mon Sep 17 00:00:00 2001
> * gnu/packages/emacs-xyz.scm (emacs-pdfgrep): New variable.
Thank you. Applied with the following changes.
> +(define-public emacs-pdfgrep
> + (let ((commit "a4ca0a1e6521de93f28bb6736a5344b4974d144c")
> + (revision "0"))
> + (package
> + (name "emacs-pdfgrep")
> + (version (git-version "0" revision commit))
Latest version is actually 1.4. I also downgraded the commit to the one
matching the version bump.
> + (url "https://github.com/jeremy-compostella/pdfgrep.git")
I removed the ".git" suffix from the URL.
> + (add-after
> + 'unpack
> + 'patch-pdfgrep-path
> + (lambda* (#:key inputs #:allow-other-keys)
> + (make-file-writable "pdfgrep.el")
> + (emacs-substitute-variables "pdfgrep.el"
> + ("pdfgrep-program"
> + (search-input-file inputs "bin/pdfgrep")))
> + #t)))))
I removed the trailing #t.
> + (synopsis "Run pdfgrep within Emacs and display the results.")
> + (description
> + "This package provides the Emacs \"grep\" facilities for the pdfgrep program.")
I used the description from the repository, which seemed more clear.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2022-09-20 22:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 12:08 [bug#57171] [PATCH] gnu: Add emacs-pdfgrep pinoaffe
2022-08-23 10:07 ` Ricardo Wurmus
2022-09-19 20:05 ` [bug#57171] [PATCH v2] " pinoaffe
2022-09-20 19:38 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfklx2d4.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=57171-done@debbugs.gnu.org \
--cc=pinoaffe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).