unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: "Mădălin Ionel Patrașcu" <madalinionel.patrascu@mdc-berlin.de>
Cc: 61838@debbugs.gnu.org
Subject: [bug#61838] [PATCH v2 01/13] gnu: Add r-simplermarkdown.
Date: Wed, 01 Mar 2023 12:07:20 +0100	[thread overview]
Message-ID: <87sfeog1x2.fsf@elephly.net> (raw)
In-Reply-To: <20230227204249.1906-1-madalinionel.patrascu@mdc-berlin.de>


Mădălin Ionel Patrașcu <madalinionel.patrascu@mdc-berlin.de> writes:

> * gnu/packages/cran.scm (r-simplermarkdown): New variable.

Thanks for the update.

Turns out we cannot easily patch references to the pandoc executable.  I
tried this:

--8<---------------cut here---------------start------------->8---
    (arguments
     (list
      #:phases
      #~(modify-phases %standard-phases
          (add-after 'unpack 'patch-pandoc-invocations
            (lambda* (#:key inputs #:allow-other-keys)
              (let ((pandoc (search-input-file inputs "/bin/pandoc")))
                (substitute* '("R/mdtangle.R"
                               "R/mdweave.R"
                               "R/mdweave_to.R")
                  (("'pandoc ")
                   (string-append "'" pandoc " ")))
                (substitute* "R/has_pandoc.R"
                  (("Sys.which\\(\"pandoc\"\\)")
                   (string-append "\"" pandoc "\"")))))))))
--8<---------------cut here---------------end--------------->8---

This works, but the resulting output no longer has any references to
/gnu/store/…-pandoc…/bin/pandoc.  That’s because none of these files
make it to the output.  Instead they all seemingly get squished into a
pair of simplermarkdown.rdx and .rdb files, which are compressed.

So it is safer to propagate pandoc.
This may point to a general problem with the r-build-system that we may
need to investigate later.

-- 
Ricardo




  reply	other threads:[~2023-03-01 11:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 10:24 [bug#61838] [PAtCH] gnu: Add r-simplermarkdown, r-rcppspdlog, r-n2r, r-sccore, r-leidenalg, r-drat, r-dendsort, r-pagoda2, r-conospanel, r-p2data, r-pma, r-rmumps and r-conos MadalinIonel.Patrascu
2023-02-27 10:28 ` [bug#61838] [PATCH 01/13] gnu: Add r-simplermarkdown Mădălin Ionel Patrașcu
2023-02-27 10:28   ` [bug#61838] [PATCH 02/13] gnu: Add r-rcppspdlog Mădălin Ionel Patrașcu
2023-02-27 19:12     ` Ricardo Wurmus
2023-02-27 10:28   ` [bug#61838] [PATCH 03/13] gnu: Add r-n2r Mădălin Ionel Patrașcu
2023-02-27 19:13     ` Ricardo Wurmus
2023-02-27 10:28   ` [bug#61838] [PATCH 04/13] gnu: Add r-sccore Mădălin Ionel Patrașcu
2023-02-27 19:14     ` Ricardo Wurmus
2023-02-27 10:28   ` [bug#61838] [PATCH 05/13] gnu: Add r-leidenalg Mădălin Ionel Patrașcu
2023-02-27 10:28   ` [bug#61838] [PATCH 06/13] gnu: Add r-drat Mădălin Ionel Patrașcu
2023-02-27 10:28   ` [bug#61838] [PATCH 07/13] gnu: Add r-dendsort Mădălin Ionel Patrașcu
2023-02-27 10:28   ` [bug#61838] [PATCH 08/13] gnu: Add r-pagoda2 Mădălin Ionel Patrașcu
2023-02-27 10:28   ` [bug#61838] [PATCH 09/13] gnu: Add r-conos Mădălin Ionel Patrașcu
2023-02-27 10:28   ` [bug#61838] [PATCH 10/13] gnu: Add r-conospanel Mădălin Ionel Patrașcu
2023-02-27 10:28   ` [bug#61838] [PATCH 11/13] gnu: Add r-p2data Mădălin Ionel Patrașcu
2023-02-27 10:28   ` [bug#61838] [PATCH 12/13] gnu: Add r-pma Mădălin Ionel Patrașcu
2023-02-27 10:28   ` [bug#61838] [PATCH 13/13] gnu: Add r-rmumps Mădălin Ionel Patrașcu
2023-02-27 19:10   ` [bug#61838] [PATCH 01/13] gnu: Add r-simplermarkdown Ricardo Wurmus
2023-03-01 13:20   ` bug#61838: " Ricardo Wurmus
2023-02-27 20:42 ` [bug#61838] [PATCH v2 " Mădălin Ionel Patrașcu
2023-03-01 11:07   ` Ricardo Wurmus [this message]
2023-02-27 21:17 ` [bug#61838] [PATCH v2 02/13] gnu: Add r-rcppspdlog Mădălin Ionel Patrașcu
2023-02-27 23:37 ` [bug#61838] [PATCH v2 03/13] gnu: Add r-n2r Mădălin Ionel Patrașcu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfeog1x2.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=61838@debbugs.gnu.org \
    --cc=madalinionel.patrascu@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).