unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: 62062@debbugs.gnu.org
Subject: [bug#62062] [PATCH] guix: Strip #:use-module lists.
Date: Fri, 10 Mar 2023 10:40:42 +0100	[thread overview]
Message-ID: <87sfed7xlx.fsf@gnu.org> (raw)
In-Reply-To: <86bkl2nrvy.fsf@gmail.com> (Simon Tournier's message of "Thu, 09 Mar 2023 11:25:21 +0100")

Hi Simon,

Simon Tournier <zimon.toutoune@gmail.com> skribis:

> On Thu, 09 Mar 2023 at 00:26, Ludovic Courtès <ludo@gnu.org> wrote:
>> This was obtained by setting up this environment:
>>
>>   guix shell -D guix --with-input=guile@3.0.9=guile-next \
>>     --with-commit=guile-next=e2ed33ef0445c867fe56c247054aa67e834861f2
>>     -- make -j5
>>
>> then adding 'unused-module' to (@@ (guix build compiler) %warnings),
>> building, and checking all the "unused module" warnings and removing
>> those that were definitely unused.
>
> Out of curiosity, well, I have not understood how you proceeded. :-)
> Could you explain a bit more what you meant by:
>
>     then adding 'unused-module' to (@@ (guix build compiler) %warnings),
>
> Adding where?

To the ‘%warnings’ variable in (guix build compile).

> Do you mean this ’unused-module’ is now part of the guile-next?

It’s in Guile ‘main’ yes.

> Well, Guile e2ed33ef0445c867fe56c247054aa67e834861f2 is also about
> removing unused modules in Guile itself.

Right; see the preceding commit.  :-)

> Last minor comment, is it expected that there is nothing under
> ’gnu/packages’?

This is left as an exercise to the reader.  :-)

That is, one can do the same with gnu/packages/*.scm.  It can be quite
tedious though due to “false positives” (not exactly false positives,
but cases where the compiler cannot tell for sure whether a module
really is unused).

Ludo’.




  reply	other threads:[~2023-03-10  9:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 23:26 [bug#62062] [PATCH] guix: Strip #:use-module lists Ludovic Courtès
2023-03-09  7:54 ` Christopher Baines
2023-03-13 14:19   ` Ludovic Courtès
2023-03-09 10:25 ` Simon Tournier
2023-03-10  9:40   ` Ludovic Courtès [this message]
2023-03-10 11:37     ` Simon Tournier
2023-07-25 17:10 ` bug#62062: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfed7xlx.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=62062@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).