From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8I5LJqPYfWSEIQEASxT56A (envelope-from ) for ; Mon, 05 Jun 2023 14:44:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mB0MJaPYfWT/EQAAG6o9tA (envelope-from ) for ; Mon, 05 Jun 2023 14:44:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA9B748B5 for ; Mon, 5 Jun 2023 14:44:18 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=buWvxf5J; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685969059; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RjB5md0Ulg9/xwIW6HRLWxkvtG5srV5Ixpb9YDlz0T0=; b=gmiXVn4yuXTgxexUnP4av3SAg1Sxsl+vHxfghYPiwcsvV8ddIXEisCNoTYfboxU31PPOBT IQcnTrsy5e5i4B0JTgnvI7e5L32iFtzrF+UuRrSY3f3Lq8Ttki4ovMwCS8Thd9ehZYE0rA waKNsF9f629NsjfHOw2Sj31vzDbxUjHub9Pj/empQYgIyLESupHSsYFLsZAGO6BdMSAw2p O9HyXEtuRZQDclzp5yqoaFwIj8PMl6ryUVCltakghyxiB2mbNpouQ/9J7MQsQNqwxMK7lE s8K/xcE8z15lV4QRNPi4o9MPDVGexcCq9/fboeVkslVsrmlp4A7tFS6oN3z4Dw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=buWvxf5J; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685969059; a=rsa-sha256; cv=none; b=r8/MCxdyBG+0ArGhbQ4joK3WhfVntxiLyFZ3eShUbOeQbI8pAO6+pZD0ckSapJZI4z0UXe bHd5Gn9jYoZw8OpSbSet0F/4ACJnsO0fzzs0ARe+Cc71tYLTcVsQYMRxxjeK4eUDGoinyc uqo/YebznXYQB5I4Wakc8NHXzAxXbyQlvFHxGDb9tBlnhy3rVvNTiBDslIGVLqEN4Idt0t dpAqgjUGnA8q90o5KsK8ZWnzbUltdVobVaC45AfuvR3tFlDY7X98pZ2R67ABTVUafbvNMx kNQlGegcxC1MXMiweAcdbohFCxLS9PrWbAarxQhdSyJKuE3njzs7O6kG5S72Zg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q69Z6-0007Rf-Oo; Mon, 05 Jun 2023 08:44:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q69Z4-0007RE-Ql for guix-patches@gnu.org; Mon, 05 Jun 2023 08:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q69Z4-0004s5-H1 for guix-patches@gnu.org; Mon, 05 Jun 2023 08:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q69Z4-000414-DH for guix-patches@gnu.org; Mon, 05 Jun 2023 08:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63647] [PATCH 0/2] Fix annoyance with "guix import go" Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Jun 2023 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63647 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: 63647@debbugs.gnu.org Received: via spool by 63647-submit@debbugs.gnu.org id=B63647.168596904115423 (code B ref 63647); Mon, 05 Jun 2023 12:44:02 +0000 Received: (at 63647) by debbugs.gnu.org; 5 Jun 2023 12:44:01 +0000 Received: from localhost ([127.0.0.1]:48396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q69Z3-00040g-2x for submit@debbugs.gnu.org; Mon, 05 Jun 2023 08:44:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q69Z0-00040P-Q3 for 63647@debbugs.gnu.org; Mon, 05 Jun 2023 08:43:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q69Yv-0004ri-I3; Mon, 05 Jun 2023 08:43:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=RjB5md0Ulg9/xwIW6HRLWxkvtG5srV5Ixpb9YDlz0T0=; b=buWvxf5Jt35CwuT6XjcR hH8xq3c+B7HIOR6BI2s5snTt9bati/t9iehVvAZc3SDpM/AVAto4wast51bFoXGYB1D1goT9sIJws vyyWbTZwrXGL7YzXqk8e59EmenR10wjLpMxMvDzd9RrP1zkT1L8lVZUu0BTequiJr8UbjCT7bI96f dEC29YI2IQ+7OvoclIkvWP+jGvTf3vgUkGPlIssJ27e9LX0uwTptTUWHO12cfqdCsu0hsYPD7O3Ac kj8OMZsXTDuSzf+ZVd+x6YsuG0mNapiNb612EMWFpPrZeJXOwhSYKC+k7/+L32v5rz3021qb4e66T PYMsS7qdnvTTmw==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q69Yv-0001kV-4t; Mon, 05 Jun 2023 08:43:53 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Mon, 05 Jun 2023 14:43:49 +0200 In-Reply-To: (Simon Tournier's message of "Thu, 25 May 2023 18:07:47 +0200") Message-ID: <87sfb6hyey.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: UNKNOWN X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.54 X-Spam-Score: -2.54 X-Migadu-Queue-Id: DA9B748B5 X-Migadu-Scanner: in3.migadu.com X-TUID: 28Imn2dWb4Ky Hi, Simon Tournier skribis: > * guix/import/go.scm (validate-version): Sort available versions. LGTM! > From: Stephen Paul Weber > > * guix/import/go.scm (vcs->origin): New argument module-path-subdirectory. > Use it to get Git tag as described by . > > Co-authored-by: Simon Tournier > Signed-off-by: Simon Tournier [...] > -(define (vcs->origin vcs-type vcs-repo-url version) > +(define (vcs->origin vcs-type vcs-repo-url module-path-subdirectory vers= ion) > "Generate the `origin' block of a package depending on what type of so= urce > control system is being used." Maybe just =E2=80=98subdirectory=E2=80=99? (In general =E2=80=98path=E2=80= =99 is used for search paths, not for file names, but I see this module already used the term with that meaning.) Also please mention it in the docstring. Should there be a test, or is it too tricky? Thanks, Ludo=E2=80=99.