From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id D1TONEs23WRqvgAASxT56A (envelope-from ) for ; Wed, 16 Aug 2023 22:49:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2HIsM0s23WTr6gAAG6o9tA (envelope-from ) for ; Wed, 16 Aug 2023 22:49:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6916A42DA8 for ; Wed, 16 Aug 2023 22:49:15 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=OxMjzzaV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692218955; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UGF/XTCgqetzSpYRfCCRTMYj1mMd5n+YNF+SZsJHszc=; b=hMWSI7oX8by9QLHJRHtTu5uGlPDB8LSDCYNd3t1Y9uBpnBIAvwNBu78ILcHrlc3IUUjJ9K 3d+9xWJW5TzN+aFmLzNKLjwGteCuiBFrzGk1zSBwmPDTdSk4xOcBJ+4PIwNDMnQRpn2Ket MyN27ml/mjQ0aXJRNeQV/fDtDFfeSBHs7+YnjdAikUI8kz/dc+FT+iaJbhdB2x6WTJsPqx ol6swuNH8o6apMc5iJbfWmsJzNONbnPb2FomZZnKv8DAiPBfkbGRgUNbIa/Vv/7rtCgM55 0S9nWO8skC0NtEqbTIZRLXJ/vKQKbC4IY539TdkiCXr6VAeRGUJ5wCS8z+xxGg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=OxMjzzaV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692218955; a=rsa-sha256; cv=none; b=SU2+JcuAlSn679DqY3Jcdnk9J3LIVd0V2G0VT940kwdMRGi64eD9BCXOt5XhO4wHdsPNcl I+SZttUmAxUSWFPc4yFX2Xv0x4M5T5kqgrV3lLa76V3Fhvgg5hqrFprl9ztR20xTsK/HIk Xh11Cy2gdTd9saDihhkwyozgBbewDIdySc6Sp+7UMSoFv4eS1tNZfrSiD9WCghJ8wvhJ6O RW6jm8BWJqwIOmeqPxy6Db+0j0lOBqBMNC81MYSVyR1XNjzrOrpdAjpIUS3NBUuXNsCUmr lK6kwimouMFGGS5KSUKB4PC2NgB3HUezwWcHL6TmZVLFrpNNpMZ1zVDEvw1OZQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWNRv-00006I-NF; Wed, 16 Aug 2023 16:49:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWNRu-00006A-74 for guix-patches@gnu.org; Wed, 16 Aug 2023 16:49:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWNRt-0001qm-RO for guix-patches@gnu.org; Wed, 16 Aug 2023 16:49:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWNRt-0002LG-Mr for guix-patches@gnu.org; Wed, 16 Aug 2023 16:49:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64765] [PATCH] gnu: home: zsh: Also load enviroment in non-login shells Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 16 Aug 2023 20:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64765 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Saku Laesvuori Cc: 64765@debbugs.gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by 64765-submit@debbugs.gnu.org id=B64765.16922189358982 (code B ref 64765); Wed, 16 Aug 2023 20:49:01 +0000 Received: (at 64765) by debbugs.gnu.org; 16 Aug 2023 20:48:55 +0000 Received: from localhost ([127.0.0.1]:42223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWNRn-0002Ko-7v for submit@debbugs.gnu.org; Wed, 16 Aug 2023 16:48:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWNRk-0002Ka-W7 for 64765@debbugs.gnu.org; Wed, 16 Aug 2023 16:48:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWNRf-0001nz-6r; Wed, 16 Aug 2023 16:48:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=UGF/XTCgqetzSpYRfCCRTMYj1mMd5n+YNF+SZsJHszc=; b=OxMjzzaVB9kooCfmgIca LlbLZnAXCxL1avkV3aQw+9u5zoFaLq8W2LOZGC3i+G96+Rnz7dDKk/pd3+bS70tC8MEh4lODzTe+H oRAdQiM/CJqYoLy0lS4KoeCqeMc2DluiYQuuSE3xg3k2hko/l4odB8DCc8tqBjzvVYow0kteH1tQj vaC3mdyH8x8myAJCDGtikiSW8rdiZtAx8dScMWBMf4lyqp7re99jFmaqooINAWjLqObNpJfkWrlrV Xj9s91E9ANFFfEPcMG+lpVa756VXEtASBG/NTkrI3kQfkyabjx6OwmvtG0eJIMqLO1lA5kg67q3f2 37ZCFcKWU6Ypag==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230721105801.10840-1-saku@laesvuori.fi> <87bkg5h1vp.fsf@envs.net> <20230721144458.w3we4ve6oqw4m7pn@X-kone> Date: Wed, 16 Aug 2023 22:48:44 +0200 In-Reply-To: <20230721144458.w3we4ve6oqw4m7pn@X-kone> (Saku Laesvuori's message of "Fri, 21 Jul 2023 17:44:58 +0300") Message-ID: <87sf8i3e8j.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 6916A42DA8 X-Migadu-Scanner: mx1.migadu.com X-Spam-Score: -6.89 X-Migadu-Spam-Score: -6.89 X-TUID: Jo6TUsyeU7CT Hi, Saku Laesvuori skribis: >> > * gnu/home/services/shells.scm (zsh-file-zshenv): Add snippet to source >> > profiles. >> > (zsh-file-zprofile): Remove profile sourcing snippet. >> > (zsh-get-configuration-files): Always add .zshenv as it is never empty. >> > Check that .zprofile is not empty before adding it. >> > --- >> > The service incorrectly assumed that shells are either login shells or >> > started from another shell. For example, ssh with a command argument >> > starts shells that aren't login shells nor started from another shell. >>=20 >> Hello, this looks reasonable to me, only one question: >> Will ~/.guix-home/profile/etc/profile be sourced multiple times with >> duplicated search-path entries? (eg: check 'env' in 'zsh' in 'zsh'). > > Yes, but I don't think it causes any problems aside from adding useless > data to the environment. This could be prevented by exporting > GUIX_PROFILE_SOURCED=3D1 or something similar and only sourcing profiles > if it isn't set. I doesn=E2=80=99t sound great though, and I=E2=80=99m sure it could break o= bscure things, like #include_next in C. Is there a way this could be avoided? (I=E2=80=99m not familiar with Zsh s= o I=E2=80=99m not offering to help; just looking for pending patches to apply. :-)) Thanks, Ludo=E2=80=99.